From: Lucas Stach <l.stach@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>, linux-pm@vger.kernel.org
Cc: Chris Health <cphealy@gmail.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Guenter Roeck <linux@roeck-us.net>,
Sebastian Reichel <sre@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] power: supply: Add driver for Microchip UCS1002
Date: Fri, 26 Apr 2019 16:43:44 +0200 [thread overview]
Message-ID: <1556289824.2584.36.camel@pengutronix.de> (raw)
In-Reply-To: <20190417084457.28747-3-andrew.smirnov@gmail.com>
Hi Andrey,
Am Mittwoch, den 17.04.2019, 01:44 -0700 schrieb Andrey Smirnov:
> Add driver for Microchip UCS1002 Programmable USB Port Power
> Controller with Charger Emulation. The driver exposed a power supply
> device to control/monitor various parameter of the device as well as a
> regulator to allow controlling VBUS line.
>
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Cc: Chris Health <cphealy@gmail.com>
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: Sebastian Reichel <sre@kernel.org>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
> ---
[...]
> + if (irq_a_det > 0) {
> > + ret = devm_request_threaded_irq(dev, irq_a_det, NULL,
> > + ucs1002_charger_irq,
> > + IRQF_TRIGGER_FALLING |
> > + IRQF_TRIGGER_RISING |
> > + IRQF_ONESHOT,
> > + "ucs1002-a_det", info);
> > + if (ret) {
> > + dev_err(dev, "failed to request A_DET threaded irq\n");
> > + return ret;
> > + }
> > + }
> +
> > + if (irq_alert > 0) {
> > + ret = devm_request_threaded_irq(dev, irq_alert, NULL,
> > + ucs1002_alert_irq,
> > + IRQF_TRIGGER_FALLING |
> > + IRQF_TRIGGER_RISING |
> > + IRQF_ONESHOT,
> > + "ucs1002-alert", info);
> > + if (ret) {
> > + dev_err(dev, "failed to request ALERT threaded irq\n");
> > + return ret;
> > + }
> > + }
Any reason to explicitly set the IRQ trigger type here? Normally I
would expect this to be set via the DT interrupt specifier.
Regards,
Lucas
next prev parent reply other threads:[~2019-04-26 14:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 8:44 [PATCH 0/3] Driver for UCS1002 Andrey Smirnov
2019-04-17 8:44 ` [PATCH 1/3] power: supply: core: Add POWER_SUPPLY_HEALTH_OVERCURRENT constant Andrey Smirnov
2019-04-26 16:12 ` Guenter Roeck
2019-04-17 8:44 ` [PATCH 2/3] power: supply: Add driver for Microchip UCS1002 Andrey Smirnov
2019-04-26 14:43 ` Lucas Stach [this message]
2019-04-28 22:24 ` Andrey Smirnov
2019-04-26 16:10 ` Guenter Roeck
2019-04-27 0:16 ` Andrey Smirnov
2019-04-26 16:51 ` Enric Balletbo Serra
2019-04-26 17:04 ` Guenter Roeck
2019-04-27 0:29 ` Andrey Smirnov
2019-04-17 8:44 ` [PATCH 3/3] dt-bindings: power: supply: Add bindings " Andrey Smirnov
2019-04-17 19:05 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556289824.2584.36.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).