From: Guenter Roeck <linux@roeck-us.net>
To: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
Linux PM list <linux-pm@vger.kernel.org>,
Chris Health <cphealy@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Sebastian Reichel <sre@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] power: supply: Add driver for Microchip UCS1002
Date: Fri, 26 Apr 2019 10:04:37 -0700 [thread overview]
Message-ID: <20190426170437.GA9087@roeck-us.net> (raw)
In-Reply-To: <CAFqH_53vo__70Xm5pOoLvqPG2iNN32VP5cbFCatDq=o0GLYzsA@mail.gmail.com>
On Fri, Apr 26, 2019 at 06:51:51PM +0200, Enric Balletbo Serra wrote:
> Hi Andrey,
>
> Many thanks to push this upstream. Actually this the fifth version [1]
> of this patchset. I think that is interesting for the maintainers
> maintain the history and the changelog.
>
> [1] https://lkml.org/lkml/2016/3/14/233
>
> Missatge de Andrey Smirnov <andrew.smirnov@gmail.com> del dia dc., 17
> d’abr. 2019 a les 10:46:
> >
> > Add driver for Microchip UCS1002 Programmable USB Port Power
> > Controller with Charger Emulation. The driver exposed a power supply
> > device to control/monitor various parameter of the device as well as a
> > regulator to allow controlling VBUS line.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Cc: Chris Health <cphealy@gmail.com>
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: Sebastian Reichel <sre@kernel.org>
> > Cc: linux-kernel@vger.kernel.org
> > Cc: linux-pm@vger.kernel.org
> > ---
...
> > + static const int bit_weights_uAh[BITS_PER_TYPE(u32)] = {
> > + 0, 0, 0, 0, 0, 0, 3, 5,
> > +
>
> nit: I personally don't like these empty lines here.
>
I stumbled over those as well, but then I realized that they
split up the 32 bit into bytes, so it does make some sense.
Guenter
next prev parent reply other threads:[~2019-04-26 17:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 8:44 [PATCH 0/3] Driver for UCS1002 Andrey Smirnov
2019-04-17 8:44 ` [PATCH 1/3] power: supply: core: Add POWER_SUPPLY_HEALTH_OVERCURRENT constant Andrey Smirnov
2019-04-26 16:12 ` Guenter Roeck
2019-04-17 8:44 ` [PATCH 2/3] power: supply: Add driver for Microchip UCS1002 Andrey Smirnov
2019-04-26 14:43 ` Lucas Stach
2019-04-28 22:24 ` Andrey Smirnov
2019-04-26 16:10 ` Guenter Roeck
2019-04-27 0:16 ` Andrey Smirnov
2019-04-26 16:51 ` Enric Balletbo Serra
2019-04-26 17:04 ` Guenter Roeck [this message]
2019-04-27 0:29 ` Andrey Smirnov
2019-04-17 8:44 ` [PATCH 3/3] dt-bindings: power: supply: Add bindings " Andrey Smirnov
2019-04-17 19:05 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426170437.GA9087@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=eballetbo@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).