* [PATCH] arm64: dts: imx8mq: Add a node for irqsteer
@ 2019-04-30 13:41 Guido Günther
2019-04-30 13:50 ` Lucas Stach
0 siblings, 1 reply; 3+ messages in thread
From: Guido Günther @ 2019-04-30 13:41 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Lucas Stach, Abel Vesa, Carlo Caione, Daniel Baluta,
Angus Ainslie (Purism),
Guido Günther, devicetree, linux-arm-kernel, linux-kernel
Add a node for the irqsteer interrupt controller found on the iMX8MQ
SoC.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 2cc939cfbd75..ce0e137ec8ee 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -798,6 +798,27 @@
};
};
+ bus@32c00000 { /* AIPS4 */
+ compatible = "fsl,imx8mq-aips-bus", "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x32c00000 0x32c00000 0x400000>;
+
+ irqsteer: interrupt-controller@32e2d000 {
+ compatible = "fsl,imx8m-irqsteer",
+ "fsl,imx-irqsteer";
+ reg = <0x32e2d000 0x1000>;
+ interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>;
+ clock-names = "ipg";
+ fsl,channel = <0>;
+ fsl,num-irqs = <64>;
+ interrupt-controller;
+ interrupt-parent = <&gic>;
+ #interrupt-cells = <1>;
+ };
+ };
+
gpu: gpu@38000000 {
compatible = "vivante,gc";
reg = <0x38000000 0x40000>;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: Add a node for irqsteer
2019-04-30 13:41 [PATCH] arm64: dts: imx8mq: Add a node for irqsteer Guido Günther
@ 2019-04-30 13:50 ` Lucas Stach
2019-04-30 17:16 ` Guido Günther
0 siblings, 1 reply; 3+ messages in thread
From: Lucas Stach @ 2019-04-30 13:50 UTC (permalink / raw)
To: Guido Günther, Rob Herring, Mark Rutland, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Abel Vesa, Carlo Caione, Daniel Baluta,
Angus Ainslie (Purism),
devicetree, linux-arm-kernel, linux-kernel
Am Dienstag, den 30.04.2019, 15:41 +0200 schrieb Guido Günther:
> Add a node for the irqsteer interrupt controller found on the iMX8MQ
> SoC.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 2cc939cfbd75..ce0e137ec8ee 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -798,6 +798,27 @@
> };
> };
>
> + bus@32c00000 { /* AIPS4 */
> + compatible = "fsl,imx8mq-aips-bus", "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x32c00000 0x32c00000 0x400000>;
> +
> + irqsteer: interrupt-controller@32e2d000 {
> + compatible = "fsl,imx8m-irqsteer",
> + "fsl,imx-irqsteer";
This fits on a single line, right?
> + reg = <0x32e2d000 0x1000>;
> + interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>;
> + clock-names = "ipg";
> + fsl,channel = <0>;
> + fsl,num-irqs = <64>;
> + interrupt-controller;
> + interrupt-parent = <&gic>;
This is wrong, the irqsteer upstream IRQ is routed through the GPC like
all the other peripheral interrupts. You can just drop this property.
With this fixed:
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Regards,
Lucas
> + #interrupt-cells = <1>;
> + };
> + };
> +
> gpu: gpu@38000000 {
> compatible = "vivante,gc";
> reg = <0x38000000 0x40000>;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: Add a node for irqsteer
2019-04-30 13:50 ` Lucas Stach
@ 2019-04-30 17:16 ` Guido Günther
0 siblings, 0 replies; 3+ messages in thread
From: Guido Günther @ 2019-04-30 17:16 UTC (permalink / raw)
To: Lucas Stach
Cc: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Abel Vesa, Carlo Caione, Daniel Baluta, Angus Ainslie (Purism),
devicetree, linux-arm-kernel, linux-kernel
Hi Lucas,
On Tue, Apr 30, 2019 at 03:50:04PM +0200, Lucas Stach wrote:
> Am Dienstag, den 30.04.2019, 15:41 +0200 schrieb Guido Günther:
> > Add a node for the irqsteer interrupt controller found on the iMX8MQ
> > SoC.
> >
> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 2cc939cfbd75..ce0e137ec8ee 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -798,6 +798,27 @@
> > };
> > };
> >
> > + bus@32c00000 { /* AIPS4 */
> > + compatible = "fsl,imx8mq-aips-bus", "simple-bus";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges = <0x32c00000 0x32c00000 0x400000>;
> > +
> > + irqsteer: interrupt-controller@32e2d000 {
> > + compatible = "fsl,imx8m-irqsteer",
> > + "fsl,imx-irqsteer";
>
> This fits on a single line, right?
It went past the 80 char limit but it seems the dts is not super picky
about that so I changed that in v2.
>
> > + reg = <0x32e2d000 0x1000>;
> > + interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>;
> > + clock-names = "ipg";
> > + fsl,channel = <0>;
> > + fsl,num-irqs = <64>;
> > + interrupt-controller;
> > + interrupt-parent = <&gic>;
>
> This is wrong, the irqsteer upstream IRQ is routed through the GPC like
> all the other peripheral interrupts. You can just drop this property.
Fixed in v2. Thanks,
-- Guido
>
> With this fixed:
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
>
> Regards,
> Lucas
>
> > + #interrupt-cells = <1>;
> > + };
> > + };
> > +
> > gpu: gpu@38000000 {
> > compatible = "vivante,gc";
> > reg = <0x38000000 0x40000>;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-30 17:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-30 13:41 [PATCH] arm64: dts: imx8mq: Add a node for irqsteer Guido Günther
2019-04-30 13:50 ` Lucas Stach
2019-04-30 17:16 ` Guido Günther
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).