From: Michael Schmitz <schmitzmic@gmail.com>
To: Finn Thain <fthain@telegraphics.com.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-m68k@lists.linux-m68k.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/11] macintosh: Resolve various PMU driver problems
Date: Sat, 28 Jul 2018 19:08:53 +1200 [thread overview]
Message-ID: <155756b2-d3cf-e47d-2ea1-58115a4cadc5@gmail.com> (raw)
In-Reply-To: <cover.1530519301.git.fthain@telegraphics.com.au>
No regressions on my PowerBook G4, so for this series:
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Am 02.07.2018 um 20:21 schrieb Finn Thain:
> This series of patches has the following aims.
>
> 1) Eliminate duplicated code. Linux presently has two drivers for
> the 68HC05-based PMU devices found in Macs: via-pmu and via-pmu68k.
> There's no value in having separate PMU drivers for each architecture.
>
> 2) Avoid further work on via-pmu68k that's not needed for via-pmu.
>
> 3) Fix some bugs in the via-pmu driver.
>
> 4) Enable the /dev/pmu and /proc/pmu/* userspace APIs on m68k Macs
> by adopting via-pmu.
>
> 5) Improve stability on early 100-series PowerBooks by loading no PMU
> driver at all. Neither via-pmu nor via-pmu68k supports the early
> M50753-based PMU device found in these models.
>
> 6) Assist the out-of-tree NuBus PowerMac port to support PMU designs
> shared with the m68k Mac port (e.g. PowerBooks 190 and 5300).
>
> This patch series has been regression tested on various PowerBooks
> (190, 520, 3400, Pismo G3) and PowerMacs (Beige G3, G5). These patches
> did not affect userland utilities. (Note that there is a userland-
> visible change to the contents of /proc/pmu/interrupts.)
>
> Changed since v1:
> 1) Added blank lines after 'break' statements in patch 10.
> 2) Improved patch description for patch 3.
> 3) Added reviewed-by tags.
> 4) Split patch 8 to make code review easier.
>
> Changed since v2:
> 1) Added reviewed-by tag.
> 2) Retained PMU_68K_V1 and PMU_68K_V2 symbols.
>
> Changed since v3:
> 1) Rebased on v4.18-rc2.
> 2) Omitted patch 10/12, since these RTC changes now conflict with mainline.
> It will be reworked once the mainline m68k/powerpc RTC code stabilizes.
>
>
> Finn Thain (11):
> macintosh/via-pmu: Fix section mismatch warning
> macintosh/via-pmu: Add missing mmio accessors
> macintosh/via-pmu: Don't clear shift register interrupt flag twice
> macintosh/via-pmu: Enhance state machine with new 'uninitialized'
> state
> macintosh/via-pmu: Replace via pointer with via1 and via2 pointers
> macintosh/via-pmu: Add support for m68k PowerBooks
> macintosh/via-pmu: Explicitly specify CONFIG_PPC_PMAC dependencies
> macintosh/via-pmu68k: Don't load driver on unsupported hardware
> macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver
> macintosh/via-pmu: Clean up interrupt statistics
> macintosh/via-pmu: Disambiguate interrupt statistics
>
> arch/m68k/configs/mac_defconfig | 2 +-
> arch/m68k/configs/multi_defconfig | 2 +-
> arch/m68k/mac/config.c | 2 +-
> arch/m68k/mac/misc.c | 54 +--
> drivers/macintosh/Kconfig | 19 +-
> drivers/macintosh/Makefile | 1 -
> drivers/macintosh/adb.c | 2 +-
> drivers/macintosh/via-pmu.c | 346 ++++++++++------
> drivers/macintosh/via-pmu68k.c | 850 --------------------------------------
> include/uapi/linux/pmu.h | 4 +-
> 10 files changed, 235 insertions(+), 1047 deletions(-)
> delete mode 100644 drivers/macintosh/via-pmu68k.c
>
prev parent reply other threads:[~2018-07-28 7:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 8:21 [PATCH v4 00/11] macintosh: Resolve various PMU driver problems Finn Thain
2018-07-02 8:21 ` [PATCH v4 02/11] macintosh/via-pmu: Add missing mmio accessors Finn Thain
2018-07-02 8:21 ` [PATCH v4 03/11] macintosh/via-pmu: Don't clear shift register interrupt flag twice Finn Thain
2018-07-02 8:21 ` [PATCH v4 05/11] macintosh/via-pmu: Replace via pointer with via1 and via2 pointers Finn Thain
2018-07-02 8:21 ` [PATCH v4 01/11] macintosh/via-pmu: Fix section mismatch warning Finn Thain
2018-07-02 10:35 ` Mathieu Malaterre
2018-07-02 12:07 ` Finn Thain
2018-08-01 5:23 ` [v4,01/11] " Michael Ellerman
2018-07-02 8:21 ` [PATCH v4 04/11] macintosh/via-pmu: Enhance state machine with new 'uninitialized' state Finn Thain
2018-07-02 8:21 ` [PATCH v4 07/11] macintosh/via-pmu: Explicitly specify CONFIG_PPC_PMAC dependencies Finn Thain
2018-07-02 8:21 ` [PATCH v4 06/11] macintosh/via-pmu: Add support for m68k PowerBooks Finn Thain
2018-07-02 8:21 ` [PATCH v4 09/11] macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver Finn Thain
2018-07-30 6:47 ` Michael Ellerman
2018-07-30 7:27 ` Geert Uytterhoeven
2018-07-30 13:32 ` Michael Ellerman
2018-07-30 7:26 ` Geert Uytterhoeven
2018-07-30 7:27 ` Geert Uytterhoeven
2018-07-02 8:21 ` [PATCH v4 11/11] macintosh/via-pmu: Disambiguate interrupt statistics Finn Thain
2018-07-02 8:21 ` [PATCH v4 08/11] macintosh/via-pmu68k: Don't load driver on unsupported hardware Finn Thain
2018-07-30 7:23 ` Geert Uytterhoeven
2018-07-02 8:21 ` [PATCH v4 10/11] macintosh/via-pmu: Clean up interrupt statistics Finn Thain
2018-07-28 7:08 ` Michael Schmitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155756b2-d3cf-e47d-2ea1-58115a4cadc5@gmail.com \
--to=schmitzmic@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=fthain@telegraphics.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).