From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Finn Thain <fthain@telegraphics.com.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [v4,01/11] macintosh/via-pmu: Fix section mismatch warning
Date: Wed, 1 Aug 2018 15:23:58 +1000 (AEST) [thread overview]
Message-ID: <41gMDG3RdFz9s3q@ozlabs.org> (raw)
In-Reply-To: <720e9899186bed184fb9b5cce070e2dc519f9665.1530519301.git.fthain@telegraphics.com.au>
On Mon, 2018-07-02 at 08:21:18 UTC, Finn Thain wrote:
> The pmu_init() function has the __init qualifier, but the ops struct
> that holds a pointer to it does not. This causes a build warning.
> The driver works fine because the pointer is only dereferenced early.
>
> The function is so small that there's negligible benefit from using
> the __init qualifier. Remove it to fix the warning, consistent with
> the other ADB drivers.
>
> Tested-by: Stan Johnson <userm57@yahoo.com>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/73f4447d43484224d7abfba0d9468d
cheers
next prev parent reply other threads:[~2018-08-01 5:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 8:21 [PATCH v4 00/11] macintosh: Resolve various PMU driver problems Finn Thain
2018-07-02 8:21 ` [PATCH v4 02/11] macintosh/via-pmu: Add missing mmio accessors Finn Thain
2018-07-02 8:21 ` [PATCH v4 03/11] macintosh/via-pmu: Don't clear shift register interrupt flag twice Finn Thain
2018-07-02 8:21 ` [PATCH v4 05/11] macintosh/via-pmu: Replace via pointer with via1 and via2 pointers Finn Thain
2018-07-02 8:21 ` [PATCH v4 01/11] macintosh/via-pmu: Fix section mismatch warning Finn Thain
2018-07-02 10:35 ` Mathieu Malaterre
2018-07-02 12:07 ` Finn Thain
2018-08-01 5:23 ` Michael Ellerman [this message]
2018-07-02 8:21 ` [PATCH v4 04/11] macintosh/via-pmu: Enhance state machine with new 'uninitialized' state Finn Thain
2018-07-02 8:21 ` [PATCH v4 07/11] macintosh/via-pmu: Explicitly specify CONFIG_PPC_PMAC dependencies Finn Thain
2018-07-02 8:21 ` [PATCH v4 06/11] macintosh/via-pmu: Add support for m68k PowerBooks Finn Thain
2018-07-02 8:21 ` [PATCH v4 09/11] macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver Finn Thain
2018-07-30 6:47 ` Michael Ellerman
2018-07-30 7:27 ` Geert Uytterhoeven
2018-07-30 13:32 ` Michael Ellerman
2018-07-30 7:26 ` Geert Uytterhoeven
2018-07-30 7:27 ` Geert Uytterhoeven
2018-07-02 8:21 ` [PATCH v4 11/11] macintosh/via-pmu: Disambiguate interrupt statistics Finn Thain
2018-07-02 8:21 ` [PATCH v4 08/11] macintosh/via-pmu68k: Don't load driver on unsupported hardware Finn Thain
2018-07-30 7:23 ` Geert Uytterhoeven
2018-07-02 8:21 ` [PATCH v4 10/11] macintosh/via-pmu: Clean up interrupt statistics Finn Thain
2018-07-28 7:08 ` [PATCH v4 00/11] macintosh: Resolve various PMU driver problems Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41gMDG3RdFz9s3q@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=fthain@telegraphics.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).