* [PATCH 1/7] drivers: gpio: rcar: pedantic formatting
@ 2019-06-17 16:49 Enrico Weigelt, metux IT consult
2019-06-17 16:49 ` [PATCH 2/7] drivers: gpio: amdpt: drop unneeded deref of &pdev->dev Enrico Weigelt, metux IT consult
` (6 more replies)
0 siblings, 7 replies; 15+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-06-17 16:49 UTC (permalink / raw)
To: linux-kernel
Cc: linus.walleij, bgolaszewski, orsonzhai, baolin.wang, zhang.lyra,
linux-gpio
A tab sneaked in, where it shouldn't be.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/gpio/gpio-rcar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 70e95fc..187984d 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -489,7 +489,7 @@ static int gpio_rcar_probe(struct platform_device *pdev)
irq_chip->irq_unmask = gpio_rcar_irq_enable;
irq_chip->irq_set_type = gpio_rcar_irq_set_type;
irq_chip->irq_set_wake = gpio_rcar_irq_set_wake;
- irq_chip->flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_MASK_ON_SUSPEND;
+ irq_chip->flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_MASK_ON_SUSPEND;
ret = gpiochip_add_data(gpio_chip, p);
if (ret) {
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/7] drivers: gpio: amdpt: drop unneeded deref of &pdev->dev
2019-06-17 16:49 [PATCH 1/7] drivers: gpio: rcar: pedantic formatting Enrico Weigelt, metux IT consult
@ 2019-06-17 16:49 ` Enrico Weigelt, metux IT consult
2019-06-25 9:05 ` Linus Walleij
2019-06-17 16:49 ` [PATCH 3/7] drivers: gpio: eic-sprd: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
` (5 subsequent siblings)
6 siblings, 1 reply; 15+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-06-17 16:49 UTC (permalink / raw)
To: linux-kernel
Cc: linus.walleij, bgolaszewski, orsonzhai, baolin.wang, zhang.lyra,
linux-gpio
We already have the struct device* pointer in a local variable,
so we can write this a bit shorter.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/gpio/gpio-amdpt.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-amdpt.c b/drivers/gpio/gpio-amdpt.c
index 1ffd7c2..2ec9d1f 100644
--- a/drivers/gpio/gpio-amdpt.c
+++ b/drivers/gpio/gpio-amdpt.c
@@ -91,7 +91,7 @@ static int pt_gpio_probe(struct platform_device *pdev)
pt_gpio->reg_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(pt_gpio->reg_base)) {
- dev_err(&pdev->dev, "Failed to map MMIO resource for PT GPIO.\n");
+ dev_err(dev, "Failed to map MMIO resource for PT GPIO.\n");
return PTR_ERR(pt_gpio->reg_base);
}
@@ -101,7 +101,7 @@ static int pt_gpio_probe(struct platform_device *pdev)
pt_gpio->reg_base + PT_DIRECTION_REG, NULL,
BGPIOF_READ_OUTPUT_REG_SET);
if (ret) {
- dev_err(&pdev->dev, "bgpio_init failed\n");
+ dev_err(dev, "bgpio_init failed\n");
return ret;
}
@@ -110,11 +110,11 @@ static int pt_gpio_probe(struct platform_device *pdev)
pt_gpio->gc.free = pt_gpio_free;
pt_gpio->gc.ngpio = PT_TOTAL_GPIO;
#if defined(CONFIG_OF_GPIO)
- pt_gpio->gc.of_node = pdev->dev.of_node;
+ pt_gpio->gc.of_node = dev->of_node;
#endif
ret = gpiochip_add_data(&pt_gpio->gc, pt_gpio);
if (ret) {
- dev_err(&pdev->dev, "Failed to register GPIO lib\n");
+ dev_err(dev, "Failed to register GPIO lib\n");
return ret;
}
@@ -124,7 +124,7 @@ static int pt_gpio_probe(struct platform_device *pdev)
writel(0, pt_gpio->reg_base + PT_SYNC_REG);
writel(0, pt_gpio->reg_base + PT_CLOCKRATE_REG);
- dev_dbg(&pdev->dev, "PT GPIO driver loaded\n");
+ dev_dbg(dev, "PT GPIO driver loaded\n");
return ret;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 3/7] drivers: gpio: eic-sprd: use devm_platform_ioremap_resource()
2019-06-17 16:49 [PATCH 1/7] drivers: gpio: rcar: pedantic formatting Enrico Weigelt, metux IT consult
2019-06-17 16:49 ` [PATCH 2/7] drivers: gpio: amdpt: drop unneeded deref of &pdev->dev Enrico Weigelt, metux IT consult
@ 2019-06-17 16:49 ` Enrico Weigelt, metux IT consult
2019-06-19 11:34 ` Baolin Wang
2019-06-25 9:12 ` Linus Walleij
2019-06-17 16:49 ` [PATCH 4/7] drivers: gpio: ep93xx: devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
` (4 subsequent siblings)
6 siblings, 2 replies; 15+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-06-17 16:49 UTC (permalink / raw)
To: linux-kernel
Cc: linus.walleij, bgolaszewski, orsonzhai, baolin.wang, zhang.lyra,
linux-gpio
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/gpio/gpio-eic-sprd.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
index 7709226..7b9ac4a 100644
--- a/drivers/gpio/gpio-eic-sprd.c
+++ b/drivers/gpio/gpio-eic-sprd.c
@@ -568,7 +568,6 @@ static int sprd_eic_probe(struct platform_device *pdev)
const struct sprd_eic_variant_data *pdata;
struct gpio_irq_chip *irq;
struct sprd_eic *sprd_eic;
- struct resource *res;
int ret, i;
pdata = of_device_get_match_data(&pdev->dev);
@@ -597,13 +596,9 @@ static int sprd_eic_probe(struct platform_device *pdev)
* have one bank EIC, thus base[1] and base[2] can be
* optional.
*/
- res = platform_get_resource(pdev, IORESOURCE_MEM, i);
- if (!res)
- continue;
-
- sprd_eic->base[i] = devm_ioremap_resource(&pdev->dev, res);
+ sprd_eic->base[i] = devm_platform_ioremap_resource(pdev, i);
if (IS_ERR(sprd_eic->base[i]))
- return PTR_ERR(sprd_eic->base[i]);
+ continue;
}
sprd_eic->chip.label = sprd_eic_label_name[sprd_eic->type];
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 4/7] drivers: gpio: ep93xx: devm_platform_ioremap_resource()
2019-06-17 16:49 [PATCH 1/7] drivers: gpio: rcar: pedantic formatting Enrico Weigelt, metux IT consult
2019-06-17 16:49 ` [PATCH 2/7] drivers: gpio: amdpt: drop unneeded deref of &pdev->dev Enrico Weigelt, metux IT consult
2019-06-17 16:49 ` [PATCH 3/7] drivers: gpio: eic-sprd: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
@ 2019-06-17 16:49 ` Enrico Weigelt, metux IT consult
2019-06-25 9:06 ` Linus Walleij
2019-06-17 16:49 ` [PATCH 5/7] drivers: gpio: grgpio: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
` (3 subsequent siblings)
6 siblings, 1 reply; 15+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-06-17 16:49 UTC (permalink / raw)
To: linux-kernel
Cc: linus.walleij, bgolaszewski, orsonzhai, baolin.wang, zhang.lyra,
linux-gpio
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/gpio/gpio-ep93xx.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
index 71728d6..a90870a 100644
--- a/drivers/gpio/gpio-ep93xx.c
+++ b/drivers/gpio/gpio-ep93xx.c
@@ -393,16 +393,13 @@ static int ep93xx_gpio_add_bank(struct gpio_chip *gc, struct device *dev,
static int ep93xx_gpio_probe(struct platform_device *pdev)
{
struct ep93xx_gpio *epg;
- struct resource *res;
int i;
- struct device *dev = &pdev->dev;
- epg = devm_kzalloc(dev, sizeof(*epg), GFP_KERNEL);
+ epg = devm_kzalloc(&pdev->dev, sizeof(*epg), GFP_KERNEL);
if (!epg)
return -ENOMEM;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- epg->base = devm_ioremap_resource(dev, res);
+ epg->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(epg->base))
return PTR_ERR(epg->base);
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 5/7] drivers: gpio: grgpio: use devm_platform_ioremap_resource()
2019-06-17 16:49 [PATCH 1/7] drivers: gpio: rcar: pedantic formatting Enrico Weigelt, metux IT consult
` (2 preceding siblings ...)
2019-06-17 16:49 ` [PATCH 4/7] drivers: gpio: ep93xx: devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
@ 2019-06-17 16:49 ` Enrico Weigelt, metux IT consult
2019-06-25 9:07 ` Linus Walleij
2019-06-17 16:49 ` [PATCH 6/7] drivers: gpio: janz-ttl: drop unneccessary temp variable dev Enrico Weigelt, metux IT consult
` (2 subsequent siblings)
6 siblings, 1 reply; 15+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-06-17 16:49 UTC (permalink / raw)
To: linux-kernel
Cc: linus.walleij, bgolaszewski, orsonzhai, baolin.wang, zhang.lyra,
linux-gpio
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/gpio/gpio-grgpio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
index 7df48e7..0937b60 100644
--- a/drivers/gpio/gpio-grgpio.c
+++ b/drivers/gpio/gpio-grgpio.c
@@ -329,7 +329,6 @@ static int grgpio_probe(struct platform_device *ofdev)
void __iomem *regs;
struct gpio_chip *gc;
struct grgpio_priv *priv;
- struct resource *res;
int err;
u32 prop;
s32 *irqmap;
@@ -340,8 +339,7 @@ static int grgpio_probe(struct platform_device *ofdev)
if (!priv)
return -ENOMEM;
- res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
- regs = devm_ioremap_resource(&ofdev->dev, res);
+ regs = devm_platform_ioremap_resource(ofdev, 0);
if (IS_ERR(regs))
return PTR_ERR(regs);
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 6/7] drivers: gpio: janz-ttl: drop unneccessary temp variable dev
2019-06-17 16:49 [PATCH 1/7] drivers: gpio: rcar: pedantic formatting Enrico Weigelt, metux IT consult
` (3 preceding siblings ...)
2019-06-17 16:49 ` [PATCH 5/7] drivers: gpio: grgpio: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
@ 2019-06-17 16:49 ` Enrico Weigelt, metux IT consult
2019-06-25 9:08 ` Linus Walleij
2019-06-17 16:49 ` [PATCH 7/7] drivers: gpio: vr41xx: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
2019-06-25 9:04 ` [PATCH 1/7] drivers: gpio: rcar: pedantic formatting Linus Walleij
6 siblings, 1 reply; 15+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-06-17 16:49 UTC (permalink / raw)
To: linux-kernel
Cc: linus.walleij, bgolaszewski, orsonzhai, baolin.wang, zhang.lyra,
linux-gpio
don't need the temporary variable "dev", directly use &pdev->dev
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/gpio/gpio-janz-ttl.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-janz-ttl.c b/drivers/gpio/gpio-janz-ttl.c
index 6b5b5a8..cdf50e4 100644
--- a/drivers/gpio/gpio-janz-ttl.c
+++ b/drivers/gpio/gpio-janz-ttl.c
@@ -140,18 +140,17 @@ static void ttl_setup_device(struct ttl_module *mod)
static int ttl_probe(struct platform_device *pdev)
{
struct janz_platform_data *pdata;
- struct device *dev = &pdev->dev;
struct ttl_module *mod;
struct gpio_chip *gpio;
int ret;
pdata = dev_get_platdata(&pdev->dev);
if (!pdata) {
- dev_err(dev, "no platform data\n");
+ dev_err(&pdev->dev, "no platform data\n");
return -ENXIO;
}
- mod = devm_kzalloc(dev, sizeof(*mod), GFP_KERNEL);
+ mod = devm_kzalloc(&pdev->dev, sizeof(*mod), GFP_KERNEL);
if (!mod)
return -ENOMEM;
@@ -177,9 +176,9 @@ static int ttl_probe(struct platform_device *pdev)
gpio->base = -1;
gpio->ngpio = 20;
- ret = devm_gpiochip_add_data(dev, gpio, NULL);
+ ret = devm_gpiochip_add_data(&pdev->dev, gpio, NULL);
if (ret) {
- dev_err(dev, "unable to add GPIO chip\n");
+ dev_err(&pdev->dev, "unable to add GPIO chip\n");
return ret;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 7/7] drivers: gpio: vr41xx: use devm_platform_ioremap_resource()
2019-06-17 16:49 [PATCH 1/7] drivers: gpio: rcar: pedantic formatting Enrico Weigelt, metux IT consult
` (4 preceding siblings ...)
2019-06-17 16:49 ` [PATCH 6/7] drivers: gpio: janz-ttl: drop unneccessary temp variable dev Enrico Weigelt, metux IT consult
@ 2019-06-17 16:49 ` Enrico Weigelt, metux IT consult
2019-06-25 9:10 ` Linus Walleij
2019-06-25 9:04 ` [PATCH 1/7] drivers: gpio: rcar: pedantic formatting Linus Walleij
6 siblings, 1 reply; 15+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-06-17 16:49 UTC (permalink / raw)
To: linux-kernel
Cc: linus.walleij, bgolaszewski, orsonzhai, baolin.wang, zhang.lyra,
linux-gpio
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
this driver deserves a bit more cleanup, to get rid of the global
variable giu_base, which makes it single-instance-only.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/gpio/gpio-vr41xx.c | 19 +++++--------------
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/gpio/gpio-vr41xx.c b/drivers/gpio/gpio-vr41xx.c
index b13a49c..98cd715 100644
--- a/drivers/gpio/gpio-vr41xx.c
+++ b/drivers/gpio/gpio-vr41xx.c
@@ -467,10 +467,9 @@ static int vr41xx_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
static int giu_probe(struct platform_device *pdev)
{
- struct resource *res;
unsigned int trigger, i, pin;
struct irq_chip *chip;
- int irq, ret;
+ int irq;
switch (pdev->id) {
case GPIO_50PINS_PULLUPDOWN:
@@ -489,21 +488,14 @@ static int giu_probe(struct platform_device *pdev)
return -ENODEV;
}
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -EBUSY;
-
- giu_base = ioremap(res->start, resource_size(res));
- if (!giu_base)
- return -ENOMEM;
+ giu_base = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(giu_base))
+ return PTR_ERR(giu_base);
vr41xx_gpio_chip.parent = &pdev->dev;
- ret = gpiochip_add_data(&vr41xx_gpio_chip, NULL);
- if (!ret) {
- iounmap(giu_base);
+ if (gpiochip_add_data(&vr41xx_gpio_chip, NULL))
return -ENODEV;
- }
giu_write(GIUINTENL, 0);
giu_write(GIUINTENH, 0);
@@ -534,7 +526,6 @@ static int giu_probe(struct platform_device *pdev)
static int giu_remove(struct platform_device *pdev)
{
if (giu_base) {
- iounmap(giu_base);
giu_base = NULL;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 3/7] drivers: gpio: eic-sprd: use devm_platform_ioremap_resource()
2019-06-17 16:49 ` [PATCH 3/7] drivers: gpio: eic-sprd: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
@ 2019-06-19 11:34 ` Baolin Wang
2019-06-25 9:12 ` Linus Walleij
1 sibling, 0 replies; 15+ messages in thread
From: Baolin Wang @ 2019-06-19 11:34 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: LKML, Linus Walleij, Bartosz Golaszewski, Orson Zhai,
Chunyan Zhang, open list:GPIO SUBSYSTEM
Hi,
On Tue, 18 Jun 2019 at 00:49, Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linaro.org>
--
Baolin Wang
Best Regards
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/7] drivers: gpio: rcar: pedantic formatting
2019-06-17 16:49 [PATCH 1/7] drivers: gpio: rcar: pedantic formatting Enrico Weigelt, metux IT consult
` (5 preceding siblings ...)
2019-06-17 16:49 ` [PATCH 7/7] drivers: gpio: vr41xx: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
@ 2019-06-25 9:04 ` Linus Walleij
6 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2019-06-25 9:04 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: linux-kernel, Bartosz Golaszewski, Orson Zhai, Baolin Wang,
Lyra Zhang, open list:GPIO SUBSYSTEM
On Mon, Jun 17, 2019 at 6:49 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
> A tab sneaked in, where it shouldn't be.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 2/7] drivers: gpio: amdpt: drop unneeded deref of &pdev->dev
2019-06-17 16:49 ` [PATCH 2/7] drivers: gpio: amdpt: drop unneeded deref of &pdev->dev Enrico Weigelt, metux IT consult
@ 2019-06-25 9:05 ` Linus Walleij
0 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2019-06-25 9:05 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: linux-kernel, Bartosz Golaszewski, Orson Zhai, Baolin Wang,
Lyra Zhang, open list:GPIO SUBSYSTEM
On Mon, Jun 17, 2019 at 6:49 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
> We already have the struct device* pointer in a local variable,
> so we can write this a bit shorter.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 4/7] drivers: gpio: ep93xx: devm_platform_ioremap_resource()
2019-06-17 16:49 ` [PATCH 4/7] drivers: gpio: ep93xx: devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
@ 2019-06-25 9:06 ` Linus Walleij
0 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2019-06-25 9:06 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: linux-kernel, Bartosz Golaszewski, Orson Zhai, Baolin Wang,
Lyra Zhang, open list:GPIO SUBSYSTEM
On Mon, Jun 17, 2019 at 6:49 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5/7] drivers: gpio: grgpio: use devm_platform_ioremap_resource()
2019-06-17 16:49 ` [PATCH 5/7] drivers: gpio: grgpio: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
@ 2019-06-25 9:07 ` Linus Walleij
0 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2019-06-25 9:07 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: linux-kernel, Bartosz Golaszewski, Orson Zhai, Baolin Wang,
Lyra Zhang, open list:GPIO SUBSYSTEM
On Mon, Jun 17, 2019 at 6:49 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 6/7] drivers: gpio: janz-ttl: drop unneccessary temp variable dev
2019-06-17 16:49 ` [PATCH 6/7] drivers: gpio: janz-ttl: drop unneccessary temp variable dev Enrico Weigelt, metux IT consult
@ 2019-06-25 9:08 ` Linus Walleij
0 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2019-06-25 9:08 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: linux-kernel, Bartosz Golaszewski, Orson Zhai, Baolin Wang,
Lyra Zhang, open list:GPIO SUBSYSTEM
On Mon, Jun 17, 2019 at 6:49 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
> don't need the temporary variable "dev", directly use &pdev->dev
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 7/7] drivers: gpio: vr41xx: use devm_platform_ioremap_resource()
2019-06-17 16:49 ` [PATCH 7/7] drivers: gpio: vr41xx: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
@ 2019-06-25 9:10 ` Linus Walleij
0 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2019-06-25 9:10 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: linux-kernel, Bartosz Golaszewski, Orson Zhai, Baolin Wang,
Lyra Zhang, open list:GPIO SUBSYSTEM
On Mon, Jun 17, 2019 at 6:49 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
>
> this driver deserves a bit more cleanup, to get rid of the global
> variable giu_base, which makes it single-instance-only.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 3/7] drivers: gpio: eic-sprd: use devm_platform_ioremap_resource()
2019-06-17 16:49 ` [PATCH 3/7] drivers: gpio: eic-sprd: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
2019-06-19 11:34 ` Baolin Wang
@ 2019-06-25 9:12 ` Linus Walleij
1 sibling, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2019-06-25 9:12 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: linux-kernel, Bartosz Golaszewski, Orson Zhai, Baolin Wang,
Lyra Zhang, open list:GPIO SUBSYSTEM
On Mon, Jun 17, 2019 at 6:49 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Patch applied with Baolin's review tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-06-25 9:12 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 16:49 [PATCH 1/7] drivers: gpio: rcar: pedantic formatting Enrico Weigelt, metux IT consult
2019-06-17 16:49 ` [PATCH 2/7] drivers: gpio: amdpt: drop unneeded deref of &pdev->dev Enrico Weigelt, metux IT consult
2019-06-25 9:05 ` Linus Walleij
2019-06-17 16:49 ` [PATCH 3/7] drivers: gpio: eic-sprd: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
2019-06-19 11:34 ` Baolin Wang
2019-06-25 9:12 ` Linus Walleij
2019-06-17 16:49 ` [PATCH 4/7] drivers: gpio: ep93xx: devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
2019-06-25 9:06 ` Linus Walleij
2019-06-17 16:49 ` [PATCH 5/7] drivers: gpio: grgpio: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
2019-06-25 9:07 ` Linus Walleij
2019-06-17 16:49 ` [PATCH 6/7] drivers: gpio: janz-ttl: drop unneccessary temp variable dev Enrico Weigelt, metux IT consult
2019-06-25 9:08 ` Linus Walleij
2019-06-17 16:49 ` [PATCH 7/7] drivers: gpio: vr41xx: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
2019-06-25 9:10 ` Linus Walleij
2019-06-25 9:04 ` [PATCH 1/7] drivers: gpio: rcar: pedantic formatting Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).