* [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA
@ 2019-06-24 14:38 Hoan Tran OS
2019-06-25 10:12 ` Will Deacon
0 siblings, 1 reply; 10+ messages in thread
From: Hoan Tran OS @ 2019-06-24 14:38 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: linux-arm-kernel, linux-kernel, Open Source Review, Hoan Tran OS
Some NUMA nodes have memory ranges that span other nodes.
Even though a pfn is valid and between a node's start and end pfns,
it may not reside on that node.
This patch enables NODES_SPAN_OTHER_NODES config for NUMA to support
this type of NUMA layout.
Signed-off-by: Hoan Tran <Hoan@os.amperecomputing.com>
---
arch/arm64/Kconfig | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 697ea05..21fc168 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -873,6 +873,13 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
config HOLES_IN_ZONE
def_bool y
+# Some NUMA nodes have memory ranges that span other nodes.
+# Even though a pfn is valid and between a node's start and end pfns,
+# it may not reside on that node.
+config NODES_SPAN_OTHER_NODES
+ def_bool y
+ depends on ACPI_NUMA
+
source "kernel/Kconfig.hz"
config ARCH_SUPPORTS_DEBUG_PAGEALLOC
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA
2019-06-24 14:38 [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA Hoan Tran OS
@ 2019-06-25 10:12 ` Will Deacon
2019-06-25 14:55 ` Hoan Tran OS
0 siblings, 1 reply; 10+ messages in thread
From: Will Deacon @ 2019-06-25 10:12 UTC (permalink / raw)
To: Hoan Tran OS
Cc: Catalin Marinas, Will Deacon, Open Source Review, linux-kernel,
linux-arm-kernel
On Mon, Jun 24, 2019 at 02:38:28PM +0000, Hoan Tran OS wrote:
> Some NUMA nodes have memory ranges that span other nodes.
> Even though a pfn is valid and between a node's start and end pfns,
> it may not reside on that node.
>
> This patch enables NODES_SPAN_OTHER_NODES config for NUMA to support
> this type of NUMA layout.
>
> Signed-off-by: Hoan Tran <Hoan@os.amperecomputing.com>
> ---
> arch/arm64/Kconfig | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 697ea05..21fc168 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -873,6 +873,13 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
> config HOLES_IN_ZONE
> def_bool y
>
> +# Some NUMA nodes have memory ranges that span other nodes.
> +# Even though a pfn is valid and between a node's start and end pfns,
> +# it may not reside on that node.
> +config NODES_SPAN_OTHER_NODES
> + def_bool y
> + depends on ACPI_NUMA
How come this is specific to ACPI?
It would be nice if this was the default, given that only ia64, mips and
sh appear to be the only NUMA-capable architectures which don't have it.
In other words, replace the #ifdef CONFIG_NODES_SPAN_OTHER_NODES in
mm/page_alloc.c with #ifdef CONFIG_NUMA.
Will
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA
2019-06-25 10:12 ` Will Deacon
@ 2019-06-25 14:55 ` Hoan Tran OS
0 siblings, 0 replies; 10+ messages in thread
From: Hoan Tran OS @ 2019-06-25 14:55 UTC (permalink / raw)
To: Will Deacon
Cc: Catalin Marinas, Will Deacon, Open Source Submission,
linux-kernel, linux-arm-kernel
Hi Will,
On 6/25/19 3:12 AM, Will Deacon wrote:
> On Mon, Jun 24, 2019 at 02:38:28PM +0000, Hoan Tran OS wrote:
>> Some NUMA nodes have memory ranges that span other nodes.
>> Even though a pfn is valid and between a node's start and end pfns,
>> it may not reside on that node.
>>
>> This patch enables NODES_SPAN_OTHER_NODES config for NUMA to support
>> this type of NUMA layout.
>>
>> Signed-off-by: Hoan Tran <Hoan@os.amperecomputing.com>
>> ---
>> arch/arm64/Kconfig | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 697ea05..21fc168 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -873,6 +873,13 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
>> config HOLES_IN_ZONE
>> def_bool y
>>
>> +# Some NUMA nodes have memory ranges that span other nodes.
>> +# Even though a pfn is valid and between a node's start and end pfns,
>> +# it may not reside on that node.
>> +config NODES_SPAN_OTHER_NODES
>> + def_bool y
>> + depends on ACPI_NUMA
>
> How come this is specific to ACPI?
I referred to x86 config. Beside of that, I only can test on the system
with ACPI supported.
>
> It would be nice if this was the default, given that only ia64, mips and
> sh appear to be the only NUMA-capable architectures which don't have it.
> In other words, replace the #ifdef CONFIG_NODES_SPAN_OTHER_NODES in
> mm/page_alloc.c with #ifdef CONFIG_NUMA.
Agreed, let me send another patch as your suggestion.
Thanks
Hoan
> Will
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA
@ 2020-02-03 19:55 Hoan Tran
2020-02-06 10:23 ` Will Deacon
0 siblings, 1 reply; 10+ messages in thread
From: Hoan Tran @ 2020-02-03 19:55 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: linux-arm-kernel, linux-kernel, patches, Hoan Tran
Some NUMA nodes have memory ranges that span other nodes.
Even though a pfn is valid and between a node's start and end pfns,
it may not reside on that node.
This patch enables NODES_SPAN_OTHER_NODES config for NUMA to support
this type of NUMA layout.
Signed-off-by: Hoan Tran <Hoan@os.amperecomputing.com>
---
arch/arm64/Kconfig | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index e688dfa..939d28f 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -959,6 +959,13 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
config HOLES_IN_ZONE
def_bool y
+# Some NUMA nodes have memory ranges that span other nodes.
+# Even though a pfn is valid and between a node's start and end pfns,
+# it may not reside on that node.
+config NODES_SPAN_OTHER_NODES
+ def_bool y
+ depends on ACPI_NUMA
+
source "kernel/Kconfig.hz"
config ARCH_SUPPORTS_DEBUG_PAGEALLOC
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA
2020-02-03 19:55 Hoan Tran
@ 2020-02-06 10:23 ` Will Deacon
2020-02-06 20:01 ` Hoan Tran
0 siblings, 1 reply; 10+ messages in thread
From: Will Deacon @ 2020-02-06 10:23 UTC (permalink / raw)
To: Hoan Tran; +Cc: Catalin Marinas, linux-arm-kernel, linux-kernel, patches
On Mon, Feb 03, 2020 at 11:55:14AM -0800, Hoan Tran wrote:
> Some NUMA nodes have memory ranges that span other nodes.
> Even though a pfn is valid and between a node's start and end pfns,
> it may not reside on that node.
>
> This patch enables NODES_SPAN_OTHER_NODES config for NUMA to support
> this type of NUMA layout.
>
> Signed-off-by: Hoan Tran <Hoan@os.amperecomputing.com>
> ---
> arch/arm64/Kconfig | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index e688dfa..939d28f 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -959,6 +959,13 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
> config HOLES_IN_ZONE
> def_bool y
>
> +# Some NUMA nodes have memory ranges that span other nodes.
> +# Even though a pfn is valid and between a node's start and end pfns,
> +# it may not reside on that node.
> +config NODES_SPAN_OTHER_NODES
> + def_bool y
> + depends on ACPI_NUMA
> +
I thought we agreed to do this in the core code?
https://lore.kernel.org/lkml/1562887528-5896-1-git-send-email-Hoan@os.amperecomputing.com
Will
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA
2020-02-06 10:23 ` Will Deacon
@ 2020-02-06 20:01 ` Hoan Tran
2020-02-25 23:20 ` Hoan Tran
2020-03-11 11:27 ` Catalin Marinas
0 siblings, 2 replies; 10+ messages in thread
From: Hoan Tran @ 2020-02-06 20:01 UTC (permalink / raw)
To: Will Deacon; +Cc: Catalin Marinas, linux-arm-kernel, linux-kernel, patches
Hi Will,
On 2/6/20 2:23 AM, Will Deacon wrote:
> On Mon, Feb 03, 2020 at 11:55:14AM -0800, Hoan Tran wrote:
>> Some NUMA nodes have memory ranges that span other nodes.
>> Even though a pfn is valid and between a node's start and end pfns,
>> it may not reside on that node.
>>
>> This patch enables NODES_SPAN_OTHER_NODES config for NUMA to support
>> this type of NUMA layout.
>>
>> Signed-off-by: Hoan Tran <Hoan@os.amperecomputing.com>
>> ---
>> arch/arm64/Kconfig | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index e688dfa..939d28f 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -959,6 +959,13 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
>> config HOLES_IN_ZONE
>> def_bool y
>>
>> +# Some NUMA nodes have memory ranges that span other nodes.
>> +# Even though a pfn is valid and between a node's start and end pfns,
>> +# it may not reside on that node.
>> +config NODES_SPAN_OTHER_NODES
>> + def_bool y
>> + depends on ACPI_NUMA
>> +
>
> I thought we agreed to do this in the core code?
>
> https://lore.kernel.org/lkml/1562887528-5896-1-git-send-email-Hoan@os.amperecomputing.com
Yes, but it looks like Thomas didn't agree to apply this patch into x86.
https://lore.kernel.org/lkml/alpine.DEB.2.21.1907152042110.1767@nanos.tec.linutronix.de/
Regards
Hoan
>
> Will
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA
2020-02-06 20:01 ` Hoan Tran
@ 2020-02-25 23:20 ` Hoan Tran
2020-03-11 6:31 ` Hoan Tran
2020-03-11 11:27 ` Catalin Marinas
1 sibling, 1 reply; 10+ messages in thread
From: Hoan Tran @ 2020-02-25 23:20 UTC (permalink / raw)
To: Will Deacon; +Cc: Catalin Marinas, linux-arm-kernel, linux-kernel, patches
Hi Will,
Do you have any comments?
Thanks
Hoan
On 2/6/20 12:01 PM, Hoan Tran wrote:
> Hi Will,
>
> On 2/6/20 2:23 AM, Will Deacon wrote:
>> On Mon, Feb 03, 2020 at 11:55:14AM -0800, Hoan Tran wrote:
>>> Some NUMA nodes have memory ranges that span other nodes.
>>> Even though a pfn is valid and between a node's start and end pfns,
>>> it may not reside on that node.
>>>
>>> This patch enables NODES_SPAN_OTHER_NODES config for NUMA to support
>>> this type of NUMA layout.
>>>
>>> Signed-off-by: Hoan Tran <Hoan@os.amperecomputing.com>
>>> ---
>>> arch/arm64/Kconfig | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>>> index e688dfa..939d28f 100644
>>> --- a/arch/arm64/Kconfig
>>> +++ b/arch/arm64/Kconfig
>>> @@ -959,6 +959,13 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
>>> config HOLES_IN_ZONE
>>> def_bool y
>>> +# Some NUMA nodes have memory ranges that span other nodes.
>>> +# Even though a pfn is valid and between a node's start and end pfns,
>>> +# it may not reside on that node.
>>> +config NODES_SPAN_OTHER_NODES
>>> + def_bool y
>>> + depends on ACPI_NUMA
>>> +
>>
>> I thought we agreed to do this in the core code?
>>
>> https://lore.kernel.org/lkml/1562887528-5896-1-git-send-email-Hoan@os.amperecomputing.com
>>
>
> Yes, but it looks like Thomas didn't agree to apply this patch into x86.
>
> https://lore.kernel.org/lkml/alpine.DEB.2.21.1907152042110.1767@nanos.tec.linutronix.de/
>
>
> Regards
> Hoan
>
>>
>> Will
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA
2020-02-25 23:20 ` Hoan Tran
@ 2020-03-11 6:31 ` Hoan Tran
0 siblings, 0 replies; 10+ messages in thread
From: Hoan Tran @ 2020-03-11 6:31 UTC (permalink / raw)
To: Will Deacon; +Cc: Catalin Marinas, linux-arm-kernel, linux-kernel, patches
Hi Will and All,
Any chance you have time to take a look.
Thanks and regards
Hoan
On 2/25/20 3:20 PM, Hoan Tran wrote:
> Hi Will,
>
> Do you have any comments?
>
> Thanks
> Hoan
>
> On 2/6/20 12:01 PM, Hoan Tran wrote:
>> Hi Will,
>>
>> On 2/6/20 2:23 AM, Will Deacon wrote:
>>> On Mon, Feb 03, 2020 at 11:55:14AM -0800, Hoan Tran wrote:
>>>> Some NUMA nodes have memory ranges that span other nodes.
>>>> Even though a pfn is valid and between a node's start and end pfns,
>>>> it may not reside on that node.
>>>>
>>>> This patch enables NODES_SPAN_OTHER_NODES config for NUMA to support
>>>> this type of NUMA layout.
>>>>
>>>> Signed-off-by: Hoan Tran <Hoan@os.amperecomputing.com>
>>>> ---
>>>> arch/arm64/Kconfig | 7 +++++++
>>>> 1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>>>> index e688dfa..939d28f 100644
>>>> --- a/arch/arm64/Kconfig
>>>> +++ b/arch/arm64/Kconfig
>>>> @@ -959,6 +959,13 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
>>>> config HOLES_IN_ZONE
>>>> def_bool y
>>>> +# Some NUMA nodes have memory ranges that span other nodes.
>>>> +# Even though a pfn is valid and between a node's start and end pfns,
>>>> +# it may not reside on that node.
>>>> +config NODES_SPAN_OTHER_NODES
>>>> + def_bool y
>>>> + depends on ACPI_NUMA
>>>> +
>>>
>>> I thought we agreed to do this in the core code?
>>>
>>> https://lore.kernel.org/lkml/1562887528-5896-1-git-send-email-Hoan@os.amperecomputing.com
>>>
>>
>> Yes, but it looks like Thomas didn't agree to apply this patch into x86.
>>
>> https://lore.kernel.org/lkml/alpine.DEB.2.21.1907152042110.1767@nanos.tec.linutronix.de/
>>
>>
>> Regards
>> Hoan
>>
>>>
>>> Will
>>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA
2020-02-06 20:01 ` Hoan Tran
2020-02-25 23:20 ` Hoan Tran
@ 2020-03-11 11:27 ` Catalin Marinas
2020-03-28 18:36 ` Hoan Tran
1 sibling, 1 reply; 10+ messages in thread
From: Catalin Marinas @ 2020-03-11 11:27 UTC (permalink / raw)
To: Hoan Tran; +Cc: Will Deacon, linux-arm-kernel, linux-kernel, patches
On Thu, Feb 06, 2020 at 12:01:19PM -0800, Hoan Tran wrote:
> Hi Will,
>
> On 2/6/20 2:23 AM, Will Deacon wrote:
> > On Mon, Feb 03, 2020 at 11:55:14AM -0800, Hoan Tran wrote:
> > > Some NUMA nodes have memory ranges that span other nodes.
> > > Even though a pfn is valid and between a node's start and end pfns,
> > > it may not reside on that node.
> > >
> > > This patch enables NODES_SPAN_OTHER_NODES config for NUMA to support
> > > this type of NUMA layout.
> > >
> > > Signed-off-by: Hoan Tran <Hoan@os.amperecomputing.com>
> > > ---
> > > arch/arm64/Kconfig | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> > > index e688dfa..939d28f 100644
> > > --- a/arch/arm64/Kconfig
> > > +++ b/arch/arm64/Kconfig
> > > @@ -959,6 +959,13 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
> > > config HOLES_IN_ZONE
> > > def_bool y
> > > +# Some NUMA nodes have memory ranges that span other nodes.
> > > +# Even though a pfn is valid and between a node's start and end pfns,
> > > +# it may not reside on that node.
> > > +config NODES_SPAN_OTHER_NODES
> > > + def_bool y
> > > + depends on ACPI_NUMA
> > > +
> >
> > I thought we agreed to do this in the core code?
> >
> > https://lore.kernel.org/lkml/1562887528-5896-1-git-send-email-Hoan@os.amperecomputing.com
>
> Yes, but it looks like Thomas didn't agree to apply this patch into
> x86.
>
> https://lore.kernel.org/lkml/alpine.DEB.2.21.1907152042110.1767@nanos.tec.linutronix.de/
Was it a clear statement that such change will not make it to x86 or a
request for improving the patch or the description? I'd suggest you
update the x86 patch comment to include the rationale as per your reply
to Thomas and post a new version of the generic series. If Thomas (or
the mm folk) reject it again, we'll revisit the arm64-specific thread.
--
Catalin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA
2020-03-11 11:27 ` Catalin Marinas
@ 2020-03-28 18:36 ` Hoan Tran
0 siblings, 0 replies; 10+ messages in thread
From: Hoan Tran @ 2020-03-28 18:36 UTC (permalink / raw)
To: Catalin Marinas; +Cc: Will Deacon, linux-arm-kernel, linux-kernel, patches
Hi Catalin,
On 3/11/20 4:27 AM, Catalin Marinas wrote:
> On Thu, Feb 06, 2020 at 12:01:19PM -0800, Hoan Tran wrote:
>> Hi Will,
>>
>> On 2/6/20 2:23 AM, Will Deacon wrote:
>>> On Mon, Feb 03, 2020 at 11:55:14AM -0800, Hoan Tran wrote:
>>>> Some NUMA nodes have memory ranges that span other nodes.
>>>> Even though a pfn is valid and between a node's start and end pfns,
>>>> it may not reside on that node.
>>>>
>>>> This patch enables NODES_SPAN_OTHER_NODES config for NUMA to support
>>>> this type of NUMA layout.
>>>>
>>>> Signed-off-by: Hoan Tran <Hoan@os.amperecomputing.com>
>>>> ---
>>>> arch/arm64/Kconfig | 7 +++++++
>>>> 1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>>>> index e688dfa..939d28f 100644
>>>> --- a/arch/arm64/Kconfig
>>>> +++ b/arch/arm64/Kconfig
>>>> @@ -959,6 +959,13 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
>>>> config HOLES_IN_ZONE
>>>> def_bool y
>>>> +# Some NUMA nodes have memory ranges that span other nodes.
>>>> +# Even though a pfn is valid and between a node's start and end pfns,
>>>> +# it may not reside on that node.
>>>> +config NODES_SPAN_OTHER_NODES
>>>> + def_bool y
>>>> + depends on ACPI_NUMA
>>>> +
>>>
>>> I thought we agreed to do this in the core code?
>>>
>>> https://lore.kernel.org/lkml/1562887528-5896-1-git-send-email-Hoan@os.amperecomputing.com
>>
>> Yes, but it looks like Thomas didn't agree to apply this patch into
>> x86.
>>
>> https://lore.kernel.org/lkml/alpine.DEB.2.21.1907152042110.1767@nanos.tec.linutronix.de/
>
> Was it a clear statement that such change will not make it to x86 or a
> request for improving the patch or the description? I'd suggest you
> update the x86 patch comment to include the rationale as per your reply
> to Thomas and post a new version of the generic series. If Thomas (or
> the mm folk) reject it again, we'll revisit the arm64-specific thread.
Yes, I have just sent out a new patch for mm core.
Regards
Hoan
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-03-28 18:37 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-24 14:38 [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA Hoan Tran OS
2019-06-25 10:12 ` Will Deacon
2019-06-25 14:55 ` Hoan Tran OS
2020-02-03 19:55 Hoan Tran
2020-02-06 10:23 ` Will Deacon
2020-02-06 20:01 ` Hoan Tran
2020-02-25 23:20 ` Hoan Tran
2020-03-11 6:31 ` Hoan Tran
2020-03-11 11:27 ` Catalin Marinas
2020-03-28 18:36 ` Hoan Tran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).