* [PATCH] hwmon: sht15 needs CONFIG_BITREVERSE
@ 2015-12-18 14:52 Arnd Bergmann
2015-12-18 16:20 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-12-18 14:52 UTC (permalink / raw)
To: Guenter Roeck
Cc: yalin wang, Jean Delvare, lm-sensors, linux-kernel, linux-arm-kernel
If CONFIG_BITREVERSE is not built-in, the sht15 driver fails to link:
drivers/built-in.o: In function `sht15_crc8':
drivers/hwmon/sht15.c:195: undefined reference to `byte_rev_table'
This adds a Kconfig 'select' statement, like all other users of
bitrev.h have it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 33836ee98533 ("hwmon:change sht15_reverse()")
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 4a6e7c217329..60fb80bd353d 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1207,6 +1207,7 @@ config SENSORS_PWM_FAN
config SENSORS_SHT15
tristate "Sensiron humidity and temperature sensors. SHT15 and compat."
depends on GPIOLIB || COMPILE_TEST
+ select BITREVERSE
help
If you say yes here you get support for the Sensiron SHT10, SHT11,
SHT15, SHT71, SHT75 humidity and temperature sensors.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: sht15 needs CONFIG_BITREVERSE
2015-12-18 14:52 [PATCH] hwmon: sht15 needs CONFIG_BITREVERSE Arnd Bergmann
@ 2015-12-18 16:20 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2015-12-18 16:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: yalin wang, Jean Delvare, lm-sensors, linux-kernel, linux-arm-kernel
On 12/18/2015 06:52 AM, Arnd Bergmann wrote:
> If CONFIG_BITREVERSE is not built-in, the sht15 driver fails to link:
>
> drivers/built-in.o: In function `sht15_crc8':
> drivers/hwmon/sht15.c:195: undefined reference to `byte_rev_table'
>
> This adds a Kconfig 'select' statement, like all other users of
> bitrev.h have it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 33836ee98533 ("hwmon:change sht15_reverse()")
Good catch. Applied.
Thanks,
Guenter
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 4a6e7c217329..60fb80bd353d 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1207,6 +1207,7 @@ config SENSORS_PWM_FAN
> config SENSORS_SHT15
> tristate "Sensiron humidity and temperature sensors. SHT15 and compat."
> depends on GPIOLIB || COMPILE_TEST
> + select BITREVERSE
> help
> If you say yes here you get support for the Sensiron SHT10, SHT11,
> SHT15, SHT71, SHT75 humidity and temperature sensors.
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-18 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-18 14:52 [PATCH] hwmon: sht15 needs CONFIG_BITREVERSE Arnd Bergmann
2015-12-18 16:20 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).