* [PATCH v2 0/3] drm/bridge: sii902x: fix audio mclk management
@ 2019-07-22 16:05 Olivier Moysan
2019-07-22 16:05 ` [PATCH v2 1/3] drm/bridge: sii902x: fix missing reference to mclk clock Olivier Moysan
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Olivier Moysan @ 2019-07-22 16:05 UTC (permalink / raw)
To: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel, dri-devel, linux-kernel, benjamin.gaignard,
alexandre.torgue, linux-arm-kernel, linux-stm32, olivier.moysan,
jsarha, robh+dt, mark.rutland, devicetree
Fix audio master clock use for Silab sii902x HDMI transceiver.
Make audio master clock optional, as this clock is not mandatory.
Changes in v2:
- Rely on clk framework to manage undefined mclk case.
- Use devm_clk_get_optional instead of devm_clk_get.
Olivier Moysan (3):
drm/bridge: sii902x: fix missing reference to mclk clock
dt-bindings: display: sii902x: Change audio mclk binding
drm/bridge: sii902x: make audio mclk optional
.../devicetree/bindings/display/bridge/sii902x.txt | 5 ++---
drivers/gpu/drm/bridge/sii902x.c | 18 ++++++++++--------
2 files changed, 12 insertions(+), 11 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/3] drm/bridge: sii902x: fix missing reference to mclk clock
2019-07-22 16:05 [PATCH v2 0/3] drm/bridge: sii902x: fix audio mclk management Olivier Moysan
@ 2019-07-22 16:05 ` Olivier Moysan
2019-07-25 10:05 ` Benjamin Gaignard
2019-07-22 16:05 ` [PATCH v2 2/3] dt-bindings: display: sii902x: Change audio mclk binding Olivier Moysan
2019-07-22 16:06 ` [PATCH v2 3/3] drm/bridge: sii902x: make audio mclk optional Olivier Moysan
2 siblings, 1 reply; 7+ messages in thread
From: Olivier Moysan @ 2019-07-22 16:05 UTC (permalink / raw)
To: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel, dri-devel, linux-kernel, benjamin.gaignard,
alexandre.torgue, linux-arm-kernel, linux-stm32, olivier.moysan,
jsarha, robh+dt, mark.rutland, devicetree
Add devm_clk_get call to retrieve reference to master clock.
Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support")
Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
Reviewed-by: Jyri Sarha <jsarha@ti.com>
Acked-by: Andrzej Hajda <a.hajda@samsung.com
---
drivers/gpu/drm/bridge/sii902x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index c2f97e5997a1..962931c20efe 100644
--- a/drivers/gpu/drm/bridge/sii902x.c
+++ b/drivers/gpu/drm/bridge/sii902x.c
@@ -751,6 +751,7 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x,
sii902x->audio.i2s_fifo_sequence[i] |= audio_fifo_id[i] |
i2s_lane_id[lanes[i]] | SII902X_TPI_I2S_FIFO_ENABLE;
+ sii902x->audio.mclk = devm_clk_get(dev, "mclk");
if (IS_ERR(sii902x->audio.mclk)) {
dev_err(dev, "%s: No clock (audio mclk) found: %ld\n",
__func__, PTR_ERR(sii902x->audio.mclk));
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/3] dt-bindings: display: sii902x: Change audio mclk binding
2019-07-22 16:05 [PATCH v2 0/3] drm/bridge: sii902x: fix audio mclk management Olivier Moysan
2019-07-22 16:05 ` [PATCH v2 1/3] drm/bridge: sii902x: fix missing reference to mclk clock Olivier Moysan
@ 2019-07-22 16:05 ` Olivier Moysan
2019-07-25 10:05 ` Benjamin Gaignard
2019-07-22 16:06 ` [PATCH v2 3/3] drm/bridge: sii902x: make audio mclk optional Olivier Moysan
2 siblings, 1 reply; 7+ messages in thread
From: Olivier Moysan @ 2019-07-22 16:05 UTC (permalink / raw)
To: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel, dri-devel, linux-kernel, benjamin.gaignard,
alexandre.torgue, linux-arm-kernel, linux-stm32, olivier.moysan,
jsarha, robh+dt, mark.rutland, devicetree
As stated in SiL9022/24 datasheet, master clock is not required for I2S.
Make mclk property optional in DT bindings.
Fixes: 3f18021f43a3 ("dt-bindings: display: sii902x: Add HDMI audio bindings")
Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
Reviewed-by: Jyri Sarha <jsarha@ti.com>
Acked-by: Andrzej Hajda <a.hajda@samsung.com>
---
Documentation/devicetree/bindings/display/bridge/sii902x.txt | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt b/Documentation/devicetree/bindings/display/bridge/sii902x.txt
index 2df44b7d3821..6e14e087c0d0 100644
--- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt
+++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt
@@ -26,9 +26,8 @@ Optional properties:
- clocks: phandle and clock specifier for each clock listed in
the clock-names property
- clock-names: "mclk"
- Describes SII902x MCLK input. MCLK is used to produce
- HDMI audio CTS values. This property is required if
- "#sound-dai-cells"-property is present. This property follows
+ Describes SII902x MCLK input. MCLK can be used to produce
+ HDMI audio CTS values. This property follows
Documentation/devicetree/bindings/clock/clock-bindings.txt
consumer binding.
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 3/3] drm/bridge: sii902x: make audio mclk optional
2019-07-22 16:05 [PATCH v2 0/3] drm/bridge: sii902x: fix audio mclk management Olivier Moysan
2019-07-22 16:05 ` [PATCH v2 1/3] drm/bridge: sii902x: fix missing reference to mclk clock Olivier Moysan
2019-07-22 16:05 ` [PATCH v2 2/3] dt-bindings: display: sii902x: Change audio mclk binding Olivier Moysan
@ 2019-07-22 16:06 ` Olivier Moysan
2019-07-25 10:06 ` Benjamin Gaignard
2 siblings, 1 reply; 7+ messages in thread
From: Olivier Moysan @ 2019-07-22 16:06 UTC (permalink / raw)
To: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel, dri-devel, linux-kernel, benjamin.gaignard,
alexandre.torgue, linux-arm-kernel, linux-stm32, olivier.moysan,
jsarha, robh+dt, mark.rutland, devicetree
The master clock on i2s bus is not mandatory,
as sii902X internal PLL can be used instead.
Make use of mclk optional.
Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
Reviewed-by: Jyri Sarha <jsarha@ti.com>
Acked-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/gpu/drm/bridge/sii902x.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index 962931c20efe..a323815aa9b6 100644
--- a/drivers/gpu/drm/bridge/sii902x.c
+++ b/drivers/gpu/drm/bridge/sii902x.c
@@ -568,13 +568,14 @@ static int sii902x_audio_hw_params(struct device *dev, void *data,
return ret;
}
- mclk_rate = clk_get_rate(sii902x->audio.mclk);
-
- ret = sii902x_select_mclk_div(&i2s_config_reg, params->sample_rate,
- mclk_rate);
- if (mclk_rate != ret * params->sample_rate)
- dev_dbg(dev, "Inaccurate reference clock (%ld/%d != %u)\n",
- mclk_rate, ret, params->sample_rate);
+ if (sii902x->audio.mclk) {
+ mclk_rate = clk_get_rate(sii902x->audio.mclk);
+ ret = sii902x_select_mclk_div(&i2s_config_reg,
+ params->sample_rate, mclk_rate);
+ if (mclk_rate != ret * params->sample_rate)
+ dev_dbg(dev, "Inaccurate reference clock (%ld/%d != %u)\n",
+ mclk_rate, ret, params->sample_rate);
+ }
mutex_lock(&sii902x->mutex);
@@ -751,11 +752,11 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x,
sii902x->audio.i2s_fifo_sequence[i] |= audio_fifo_id[i] |
i2s_lane_id[lanes[i]] | SII902X_TPI_I2S_FIFO_ENABLE;
- sii902x->audio.mclk = devm_clk_get(dev, "mclk");
+ sii902x->audio.mclk = devm_clk_get_optional(dev, "mclk");
if (IS_ERR(sii902x->audio.mclk)) {
dev_err(dev, "%s: No clock (audio mclk) found: %ld\n",
__func__, PTR_ERR(sii902x->audio.mclk));
- return 0;
+ return PTR_ERR(sii902x->audio.mclk);
}
sii902x->audio.pdev = platform_device_register_data(
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/3] drm/bridge: sii902x: fix missing reference to mclk clock
2019-07-22 16:05 ` [PATCH v2 1/3] drm/bridge: sii902x: fix missing reference to mclk clock Olivier Moysan
@ 2019-07-25 10:05 ` Benjamin Gaignard
0 siblings, 0 replies; 7+ messages in thread
From: Benjamin Gaignard @ 2019-07-25 10:05 UTC (permalink / raw)
To: Olivier Moysan
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
jernej.skrabec, David Airlie, Daniel Vetter, ML dri-devel,
Linux Kernel Mailing List, Benjamin GAIGNARD, Alexandre Torgue,
Linux ARM, linux-stm32, Jyri Sarha, Rob Herring, Mark Rutland,
devicetree
Le lun. 22 juil. 2019 à 18:06, Olivier Moysan <olivier.moysan@st.com> a écrit :
>
> Add devm_clk_get call to retrieve reference to master clock.
>
> Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support")
>
> Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
> Reviewed-by: Jyri Sarha <jsarha@ti.com>
> Acked-by: Andrzej Hajda <a.hajda@samsung.com
Applied on drm-misc-next.
Thanks,
Benjamin
> ---
> drivers/gpu/drm/bridge/sii902x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
> index c2f97e5997a1..962931c20efe 100644
> --- a/drivers/gpu/drm/bridge/sii902x.c
> +++ b/drivers/gpu/drm/bridge/sii902x.c
> @@ -751,6 +751,7 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x,
> sii902x->audio.i2s_fifo_sequence[i] |= audio_fifo_id[i] |
> i2s_lane_id[lanes[i]] | SII902X_TPI_I2S_FIFO_ENABLE;
>
> + sii902x->audio.mclk = devm_clk_get(dev, "mclk");
> if (IS_ERR(sii902x->audio.mclk)) {
> dev_err(dev, "%s: No clock (audio mclk) found: %ld\n",
> __func__, PTR_ERR(sii902x->audio.mclk));
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: display: sii902x: Change audio mclk binding
2019-07-22 16:05 ` [PATCH v2 2/3] dt-bindings: display: sii902x: Change audio mclk binding Olivier Moysan
@ 2019-07-25 10:05 ` Benjamin Gaignard
0 siblings, 0 replies; 7+ messages in thread
From: Benjamin Gaignard @ 2019-07-25 10:05 UTC (permalink / raw)
To: Olivier Moysan
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
jernej.skrabec, David Airlie, Daniel Vetter, ML dri-devel,
Linux Kernel Mailing List, Benjamin GAIGNARD, Alexandre Torgue,
Linux ARM, linux-stm32, Jyri Sarha, Rob Herring, Mark Rutland,
devicetree
Le lun. 22 juil. 2019 à 18:06, Olivier Moysan <olivier.moysan@st.com> a écrit :
>
> As stated in SiL9022/24 datasheet, master clock is not required for I2S.
> Make mclk property optional in DT bindings.
>
> Fixes: 3f18021f43a3 ("dt-bindings: display: sii902x: Add HDMI audio bindings")
>
Applied on drm-misc-next.
Thanks,
Benjamin
> Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
> Reviewed-by: Jyri Sarha <jsarha@ti.com>
> Acked-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> Documentation/devicetree/bindings/display/bridge/sii902x.txt | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt b/Documentation/devicetree/bindings/display/bridge/sii902x.txt
> index 2df44b7d3821..6e14e087c0d0 100644
> --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt
> @@ -26,9 +26,8 @@ Optional properties:
> - clocks: phandle and clock specifier for each clock listed in
> the clock-names property
> - clock-names: "mclk"
> - Describes SII902x MCLK input. MCLK is used to produce
> - HDMI audio CTS values. This property is required if
> - "#sound-dai-cells"-property is present. This property follows
> + Describes SII902x MCLK input. MCLK can be used to produce
> + HDMI audio CTS values. This property follows
> Documentation/devicetree/bindings/clock/clock-bindings.txt
> consumer binding.
>
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 3/3] drm/bridge: sii902x: make audio mclk optional
2019-07-22 16:06 ` [PATCH v2 3/3] drm/bridge: sii902x: make audio mclk optional Olivier Moysan
@ 2019-07-25 10:06 ` Benjamin Gaignard
0 siblings, 0 replies; 7+ messages in thread
From: Benjamin Gaignard @ 2019-07-25 10:06 UTC (permalink / raw)
To: Olivier Moysan
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
jernej.skrabec, David Airlie, Daniel Vetter, ML dri-devel,
Linux Kernel Mailing List, Benjamin GAIGNARD, Alexandre Torgue,
Linux ARM, linux-stm32, Jyri Sarha, Rob Herring, Mark Rutland,
devicetree
Le lun. 22 juil. 2019 à 18:06, Olivier Moysan <olivier.moysan@st.com> a écrit :
>
> The master clock on i2s bus is not mandatory,
> as sii902X internal PLL can be used instead.
> Make use of mclk optional.
Applied on drm-misc-next.
Thanks,
Benjamin
>
> Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
> Reviewed-by: Jyri Sarha <jsarha@ti.com>
> Acked-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> drivers/gpu/drm/bridge/sii902x.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
> index 962931c20efe..a323815aa9b6 100644
> --- a/drivers/gpu/drm/bridge/sii902x.c
> +++ b/drivers/gpu/drm/bridge/sii902x.c
> @@ -568,13 +568,14 @@ static int sii902x_audio_hw_params(struct device *dev, void *data,
> return ret;
> }
>
> - mclk_rate = clk_get_rate(sii902x->audio.mclk);
> -
> - ret = sii902x_select_mclk_div(&i2s_config_reg, params->sample_rate,
> - mclk_rate);
> - if (mclk_rate != ret * params->sample_rate)
> - dev_dbg(dev, "Inaccurate reference clock (%ld/%d != %u)\n",
> - mclk_rate, ret, params->sample_rate);
> + if (sii902x->audio.mclk) {
> + mclk_rate = clk_get_rate(sii902x->audio.mclk);
> + ret = sii902x_select_mclk_div(&i2s_config_reg,
> + params->sample_rate, mclk_rate);
> + if (mclk_rate != ret * params->sample_rate)
> + dev_dbg(dev, "Inaccurate reference clock (%ld/%d != %u)\n",
> + mclk_rate, ret, params->sample_rate);
> + }
>
> mutex_lock(&sii902x->mutex);
>
> @@ -751,11 +752,11 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x,
> sii902x->audio.i2s_fifo_sequence[i] |= audio_fifo_id[i] |
> i2s_lane_id[lanes[i]] | SII902X_TPI_I2S_FIFO_ENABLE;
>
> - sii902x->audio.mclk = devm_clk_get(dev, "mclk");
> + sii902x->audio.mclk = devm_clk_get_optional(dev, "mclk");
> if (IS_ERR(sii902x->audio.mclk)) {
> dev_err(dev, "%s: No clock (audio mclk) found: %ld\n",
> __func__, PTR_ERR(sii902x->audio.mclk));
> - return 0;
> + return PTR_ERR(sii902x->audio.mclk);
> }
>
> sii902x->audio.pdev = platform_device_register_data(
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-07-25 10:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-22 16:05 [PATCH v2 0/3] drm/bridge: sii902x: fix audio mclk management Olivier Moysan
2019-07-22 16:05 ` [PATCH v2 1/3] drm/bridge: sii902x: fix missing reference to mclk clock Olivier Moysan
2019-07-25 10:05 ` Benjamin Gaignard
2019-07-22 16:05 ` [PATCH v2 2/3] dt-bindings: display: sii902x: Change audio mclk binding Olivier Moysan
2019-07-25 10:05 ` Benjamin Gaignard
2019-07-22 16:06 ` [PATCH v2 3/3] drm/bridge: sii902x: make audio mclk optional Olivier Moysan
2019-07-25 10:06 ` Benjamin Gaignard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).