* [PATCH] drm/komeda: Initialize and enable output polling on Komeda
@ 2019-08-02 8:07 Lowry Li (Arm Technology China)
2019-08-09 6:30 ` james qian wang (Arm Technology China)
0 siblings, 1 reply; 5+ messages in thread
From: Lowry Li (Arm Technology China) @ 2019-08-02 8:07 UTC (permalink / raw)
To: Liviu Dudau, james qian wang (Arm Technology China),
maarten.lankhorst, seanpaul, airlied, Brian Starkey
Cc: Julien Yin (Arm Technology China),
Jonathan Chai (Arm Technology China),
Ayan Halder, dri-devel, linux-kernel, nd
From: "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>
Initialize and enable output polling on Komeda.
Changes since v1:
1. Enable the polling before registering the driver;
2. Disable the polling after unregistering the driver.
Changes since v2:
1. If driver register failed, disable the polling.
Signed-off-by: Lowry Li (Arm Technology China) <lowry.li@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
index 419a8b0..d50e75f 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
@@ -15,6 +15,7 @@
#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_irq.h>
#include <drm/drm_vblank.h>
+#include <drm/drm_probe_helper.h>
#include "komeda_dev.h"
#include "komeda_framebuffer.h"
@@ -315,6 +316,8 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev)
drm->irq_enabled = true;
+ drm_kms_helper_poll_init(drm);
+
err = drm_dev_register(drm, 0);
if (err)
goto cleanup_mode_config;
@@ -322,6 +325,7 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev)
return kms;
cleanup_mode_config:
+ drm_kms_helper_poll_fini(drm);
drm->irq_enabled = false;
drm_mode_config_cleanup(drm);
komeda_kms_cleanup_private_objs(kms);
@@ -338,6 +342,7 @@ void komeda_kms_detach(struct komeda_kms_dev *kms)
drm->irq_enabled = false;
mdev->funcs->disable_irq(mdev);
drm_dev_unregister(drm);
+ drm_kms_helper_poll_fini(drm);
component_unbind_all(mdev->dev, drm);
komeda_kms_cleanup_private_objs(kms);
drm_mode_config_cleanup(drm);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: drm/komeda: Initialize and enable output polling on Komeda
2019-08-02 8:07 [PATCH] drm/komeda: Initialize and enable output polling on Komeda Lowry Li (Arm Technology China)
@ 2019-08-09 6:30 ` james qian wang (Arm Technology China)
0 siblings, 0 replies; 5+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-08-09 6:30 UTC (permalink / raw)
To: Lowry Li (Arm Technology China)
Cc: Liviu Dudau, maarten.lankhorst, seanpaul, airlied, Brian Starkey,
Ayan Halder, Jonathan Chai (Arm Technology China),
linux-kernel, dri-devel, Julien Yin (Arm Technology China),
nd
On Fri, Aug 02, 2019 at 08:07:52AM +0000, Lowry Li (Arm Technology China) wrote:
> From: "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>
>
> Initialize and enable output polling on Komeda.
>
> Changes since v1:
> 1. Enable the polling before registering the driver;
> 2. Disable the polling after unregistering the driver.
>
> Changes since v2:
> 1. If driver register failed, disable the polling.
>
> Signed-off-by: Lowry Li (Arm Technology China) <lowry.li@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> index 419a8b0..d50e75f 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> @@ -15,6 +15,7 @@
> #include <drm/drm_gem_framebuffer_helper.h>
> #include <drm/drm_irq.h>
> #include <drm/drm_vblank.h>
> +#include <drm/drm_probe_helper.h>
>
> #include "komeda_dev.h"
> #include "komeda_framebuffer.h"
> @@ -315,6 +316,8 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev)
>
> drm->irq_enabled = true;
>
> + drm_kms_helper_poll_init(drm);
> +
> err = drm_dev_register(drm, 0);
> if (err)
> goto cleanup_mode_config;
> @@ -322,6 +325,7 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev)
> return kms;
>
> cleanup_mode_config:
> + drm_kms_helper_poll_fini(drm);
> drm->irq_enabled = false;
> drm_mode_config_cleanup(drm);
> komeda_kms_cleanup_private_objs(kms);
> @@ -338,6 +342,7 @@ void komeda_kms_detach(struct komeda_kms_dev *kms)
> drm->irq_enabled = false;
> mdev->funcs->disable_irq(mdev);
> drm_dev_unregister(drm);
> + drm_kms_helper_poll_fini(drm);
> component_unbind_all(mdev->dev, drm);
> komeda_kms_cleanup_private_objs(kms);
> drm_mode_config_cleanup(drm);
Looks good to me.
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drm/komeda: Initialize and enable output polling on Komeda
@ 2019-08-02 7:54 Lowry Li (Arm Technology China)
0 siblings, 0 replies; 5+ messages in thread
From: Lowry Li (Arm Technology China) @ 2019-08-02 7:54 UTC (permalink / raw)
To: Liviu Dudau, james qian wang (Arm Technology China),
maarten.lankhorst, seanpaul, airlied, Brian Starkey
Cc: Julien Yin (Arm Technology China),
Jonathan Chai (Arm Technology China),
Ayan Halder, dri-devel, linux-kernel, nd
From: "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>
Initialize and enable output polling on Komeda.
Changes since v1:
1. Enable the polling before registering the driver;
2. Disable the polling after unregistering the driver.
Signed-off-by: Lowry Li (Arm Technology China) <lowry.li@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
index 419a8b0..25716a30 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
@@ -15,6 +15,7 @@
#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_irq.h>
#include <drm/drm_vblank.h>
+#include <drm/drm_probe_helper.h>
#include "komeda_dev.h"
#include "komeda_framebuffer.h"
@@ -315,6 +316,8 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev)
drm->irq_enabled = true;
+ drm_kms_helper_poll_init(drm);
+
err = drm_dev_register(drm, 0);
if (err)
goto cleanup_mode_config;
@@ -338,6 +341,7 @@ void komeda_kms_detach(struct komeda_kms_dev *kms)
drm->irq_enabled = false;
mdev->funcs->disable_irq(mdev);
drm_dev_unregister(drm);
+ drm_kms_helper_poll_fini(drm);
component_unbind_all(mdev->dev, drm);
komeda_kms_cleanup_private_objs(kms);
drm_mode_config_cleanup(drm);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/komeda: Initialize and enable output polling on Komeda
2019-07-26 8:00 Lowry Li (Arm Technology China)
@ 2019-07-26 13:15 ` Liviu Dudau
0 siblings, 0 replies; 5+ messages in thread
From: Liviu Dudau @ 2019-07-26 13:15 UTC (permalink / raw)
To: Lowry Li (Arm Technology China)
Cc: james qian wang (Arm Technology China),
maarten.lankhorst, seanpaul, airlied, Brian Starkey,
Julien Yin (Arm Technology China),
Jonathan Chai (Arm Technology China),
Ayan Halder, dri-devel, linux-kernel, nd
On Fri, Jul 26, 2019 at 08:00:29AM +0000, Lowry Li (Arm Technology China) wrote:
> Initialize and enable output polling on Komeda.
>
> Signed-off-by: Lowry Li (Arm Technology China) <lowry.li@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> index 1462bac..26f2919 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> @@ -15,6 +15,7 @@
> #include <drm/drm_gem_framebuffer_helper.h>
> #include <drm/drm_irq.h>
> #include <drm/drm_vblank.h>
> +#include <drm/drm_probe_helper.h>
>
> #include "komeda_dev.h"
> #include "komeda_framebuffer.h"
> @@ -331,6 +332,8 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev)
> if (err)
> goto uninstall_irq;
>
> + drm_kms_helper_poll_init(drm);
Most of the drivers call this before registering the driver. But this is all
moot because I can't apply the patch on top of drm-misc-next, so not having
full context of what komeda_kms_attach looks like in your tree.
Best regards,
Liviu
> +
> return kms;
>
> uninstall_irq:
> @@ -348,6 +351,7 @@ void komeda_kms_detach(struct komeda_kms_dev *kms)
> struct drm_device *drm = &kms->base;
> struct komeda_dev *mdev = drm->dev_private;
>
> + drm_kms_helper_poll_fini(drm);
> mdev->funcs->disable_irq(mdev);
> drm_dev_unregister(drm);
> drm_irq_uninstall(drm);
> --
> 1.9.1
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drm/komeda: Initialize and enable output polling on Komeda
@ 2019-07-26 8:00 Lowry Li (Arm Technology China)
2019-07-26 13:15 ` Liviu Dudau
0 siblings, 1 reply; 5+ messages in thread
From: Lowry Li (Arm Technology China) @ 2019-07-26 8:00 UTC (permalink / raw)
To: Liviu Dudau, james qian wang (Arm Technology China),
maarten.lankhorst, seanpaul, airlied, Brian Starkey
Cc: Julien Yin (Arm Technology China),
Jonathan Chai (Arm Technology China),
Ayan Halder, dri-devel, linux-kernel, nd
Initialize and enable output polling on Komeda.
Signed-off-by: Lowry Li (Arm Technology China) <lowry.li@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
index 1462bac..26f2919 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
@@ -15,6 +15,7 @@
#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_irq.h>
#include <drm/drm_vblank.h>
+#include <drm/drm_probe_helper.h>
#include "komeda_dev.h"
#include "komeda_framebuffer.h"
@@ -331,6 +332,8 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev)
if (err)
goto uninstall_irq;
+ drm_kms_helper_poll_init(drm);
+
return kms;
uninstall_irq:
@@ -348,6 +351,7 @@ void komeda_kms_detach(struct komeda_kms_dev *kms)
struct drm_device *drm = &kms->base;
struct komeda_dev *mdev = drm->dev_private;
+ drm_kms_helper_poll_fini(drm);
mdev->funcs->disable_irq(mdev);
drm_dev_unregister(drm);
drm_irq_uninstall(drm);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-09 6:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-02 8:07 [PATCH] drm/komeda: Initialize and enable output polling on Komeda Lowry Li (Arm Technology China)
2019-08-09 6:30 ` james qian wang (Arm Technology China)
-- strict thread matches above, loose matches on Subject: below --
2019-08-02 7:54 [PATCH] " Lowry Li (Arm Technology China)
2019-07-26 8:00 Lowry Li (Arm Technology China)
2019-07-26 13:15 ` Liviu Dudau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).