* [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map()
@ 2022-04-25 9:18 cgel.zte
2022-04-25 20:11 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: cgel.zte @ 2022-04-25 9:18 UTC (permalink / raw)
To: sean, quic_abhinavk
Cc: robdclark, airlied, daniel, dmitry.baryshkov, swboyd,
angelogioacchino.delregno, daniel.thompson, linmq006,
christophe.jaillet, lv.ruyi, linux-arm-msm, dri-devel, freedreno,
linux-kernel, Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
The irq_of_parse_and_map() function returns 0 on failure, and does not
return a negative value anyhow, so never enter this conditional branch.
Fixes: f6a8eaca0ea1 ("drm/msm/mdp5: use irqdomains")
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
index ec324352e862..c3b661c2932d 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
@@ -298,9 +298,9 @@ int msm_hdmi_modeset_init(struct hdmi *hdmi,
drm_connector_attach_encoder(hdmi->connector, hdmi->encoder);
hdmi->irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
- if (hdmi->irq < 0) {
- ret = hdmi->irq;
- DRM_DEV_ERROR(dev->dev, "failed to get irq: %d\n", ret);
+ if (!hdmi->irq) {
+ ret = -EINVAL;
+ DRM_DEV_ERROR(dev->dev, "failed to get irq\n");
goto fail;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map()
2022-04-25 9:18 [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map() cgel.zte
@ 2022-04-25 20:11 ` Stephen Boyd
2022-04-25 21:11 ` Dmitry Baryshkov
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2022-04-25 20:11 UTC (permalink / raw)
To: cgel.zte, quic_abhinavk, sean
Cc: robdclark, airlied, daniel, dmitry.baryshkov,
angelogioacchino.delregno, daniel.thompson, linmq006,
christophe.jaillet, lv.ruyi, linux-arm-msm, dri-devel, freedreno,
linux-kernel, Zeal Robot
Quoting cgel.zte@gmail.com (2022-04-25 02:18:31)
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> The irq_of_parse_and_map() function returns 0 on failure, and does not
> return a negative value anyhow, so never enter this conditional branch.
>
> Fixes: f6a8eaca0ea1 ("drm/msm/mdp5: use irqdomains")
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
This one fixes a commit that moved away from platform APIs!
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map()
2022-04-25 20:11 ` Stephen Boyd
@ 2022-04-25 21:11 ` Dmitry Baryshkov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2022-04-25 21:11 UTC (permalink / raw)
To: Stephen Boyd, cgel.zte, quic_abhinavk, sean
Cc: robdclark, airlied, daniel, angelogioacchino.delregno,
daniel.thompson, linmq006, christophe.jaillet, lv.ruyi,
linux-arm-msm, dri-devel, freedreno, linux-kernel, Zeal Robot
On 25/04/2022 23:11, Stephen Boyd wrote:
> Quoting cgel.zte@gmail.com (2022-04-25 02:18:31)
>> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>>
>> The irq_of_parse_and_map() function returns 0 on failure, and does not
>> return a negative value anyhow, so never enter this conditional branch.
>>
>> Fixes: f6a8eaca0ea1 ("drm/msm/mdp5: use irqdomains")
>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
>> ---
>
> This one fixes a commit that moved away from platform APIs!
The change was introduced in 2014 in the commit f6a8eaca0ea1
("drm/msm/mdp5: use irqdomains"). I can suspect that at that time
platform irq code wasn't fully compatible with IRQ domains.
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-25 21:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-25 9:18 [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map() cgel.zte
2022-04-25 20:11 ` Stephen Boyd
2022-04-25 21:11 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).