linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: amba: Move EXPORT_SYMBOL immediately next to the exported function
@ 2019-08-18  6:06 Rishi Gupta
  0 siblings, 0 replies; only message in thread
From: Rishi Gupta @ 2019-08-18  6:06 UTC (permalink / raw)
  To: linux; +Cc: tglx, gregkh, kstewart, linux-kernel, Rishi Gupta

EXPORT_SYMBOL should appear next to the function as it improves
code maintenance. This commit fixes this issue as identified by
checkpatch script.

Signed-off-by: Rishi Gupta <gupt21@gmail.com>
---
 drivers/amba/bus.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
index 100e798..39e5235 100644
--- a/drivers/amba/bus.c
+++ b/drivers/amba/bus.c
@@ -340,6 +340,7 @@ int amba_driver_register(struct amba_driver *drv)
 
 	return driver_register(&drv->drv);
 }
+EXPORT_SYMBOL(amba_driver_register);
 
 /**
  *	amba_driver_unregister - remove an AMBA device driver
@@ -353,7 +354,7 @@ void amba_driver_unregister(struct amba_driver *drv)
 {
 	driver_unregister(&drv->drv);
 }
-
+EXPORT_SYMBOL(amba_driver_unregister);
 
 static void amba_device_release(struct device *dev)
 {
@@ -668,6 +669,7 @@ int amba_device_register(struct amba_device *dev, struct resource *parent)
 
 	return amba_device_add(dev, parent);
 }
+EXPORT_SYMBOL(amba_device_register);
 
 /**
  *	amba_device_put - put an AMBA device
@@ -694,7 +696,7 @@ void amba_device_unregister(struct amba_device *dev)
 {
 	device_unregister(&dev->dev);
 }
-
+EXPORT_SYMBOL(amba_device_unregister);
 
 struct find_data {
 	struct amba_device *dev;
@@ -754,6 +756,7 @@ amba_find_device(const char *busid, struct device *parent, unsigned int id,
 
 	return data.dev;
 }
+EXPORT_SYMBOL(amba_find_device);
 
 /**
  *	amba_request_regions - request all mem regions associated with device
@@ -775,6 +778,7 @@ int amba_request_regions(struct amba_device *dev, const char *name)
 
 	return ret;
 }
+EXPORT_SYMBOL(amba_request_regions);
 
 /**
  *	amba_release_regions - release mem regions associated with device
@@ -789,11 +793,4 @@ void amba_release_regions(struct amba_device *dev)
 	size = resource_size(&dev->res);
 	release_mem_region(dev->res.start, size);
 }
-
-EXPORT_SYMBOL(amba_driver_register);
-EXPORT_SYMBOL(amba_driver_unregister);
-EXPORT_SYMBOL(amba_device_register);
-EXPORT_SYMBOL(amba_device_unregister);
-EXPORT_SYMBOL(amba_find_device);
-EXPORT_SYMBOL(amba_request_regions);
 EXPORT_SYMBOL(amba_release_regions);
-- 
2.7.4


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-08-18  6:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-18  6:06 [PATCH] ARM: amba: Move EXPORT_SYMBOL immediately next to the exported function Rishi Gupta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).