From: Krzysztof Wilczynski <kswilczynski@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH] PCI: Move static keyword to the front of declarations in pci-bridge-emul.c
Date: Wed, 28 Aug 2019 12:23:19 +0200 [thread overview]
Message-ID: <1566987800.26704.0@gmail.com> (raw)
In-Reply-To: <20190827233017.GK9987@google.com>
Hello Bjorn and Thomas,
Thank you for the feedback.
[...]
>> Move the static keyword to the front of declarations of
>> pci_regs_behavior and pcie_cap_regs_behavior, and resolve
>> compiler warning that can be seen when building with
>> warnings enabled (W=1).
>
> It would be useful to include the compiler warning in the commit log.
Good point. Sorry about that. I will send a v2 that includes
updated commit message.
> I notice there are a few similar occurrences elsewhere in the tree:
>
> arch/csky/kernel/perf_event.c:const static struct of_device_id
> csky_pmu_of_device_ids[] = {
> arch/nds32/kernel/perf_event_cpu.c:const static struct of_device_id
> cpu_pmu_of_device_ids[] = {
> drivers/gpu/drm/msm/dsi/dsi_cfg.c:const static struct
> msm_dsi_host_cfg_ops msm_dsi_v2_host_ops = {
> drivers/gpu/drm/msm/dsi/dsi_cfg.c:const static struct
> msm_dsi_host_cfg_ops msm_dsi_6g_host_ops = {
> drivers/gpu/drm/msm/dsi/dsi_cfg.c:const static struct
> msm_dsi_host_cfg_ops msm_dsi_6g_v2_host_ops = {
> drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:const static
> struct wiphy_iftype_ext_capab he_iftypes_ext_capa[] = {
> fs/unicode/utf8-selftest.c:const static struct {
> fs/unicode/utf8-selftest.c:const static struct {
>
> Those should probably be fixed, too (but in separate patches since
> other maintainers would take them).
I will take care about these too.
Krzysztof
next prev parent reply other threads:[~2019-08-28 10:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 15:14 [PATCH] PCI: Move static keyword to the front of declarations in pci-bridge-emul.c Krzysztof Wilczynski
2019-08-27 23:30 ` Bjorn Helgaas
2019-08-28 7:01 ` Thomas Petazzoni
2019-08-28 10:23 ` Krzysztof Wilczynski [this message]
2019-08-28 13:17 ` [PATCH v2] " Krzysztof Wilczynski
2019-08-28 13:39 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566987800.26704.0@gmail.com \
--to=kswilczynski@gmail.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).