From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Krzysztof Wilczynski <kw@linux.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: Move static keyword to the front of declarations in pci-bridge-emul.c
Date: Wed, 28 Aug 2019 15:39:26 +0200 [thread overview]
Message-ID: <20190828153926.1d8d9d7b@windsurf.home> (raw)
In-Reply-To: <20190828131733.5817-1-kw@linux.com>
Hello,
On Wed, 28 Aug 2019 15:17:33 +0200
Krzysztof Wilczynski <kw@linux.com> wrote:
> Move the static keyword to the front of declarations of
> pci_regs_behavior and pcie_cap_regs_behavior, and resolve
> the following compiler warning that can be seen when
> building with warnings enabled (W=1):
>
> drivers/pci/pci-bridge-emul.c:41:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> const static struct pci_bridge_reg_behavior pci_regs_behavior[] = {
> ^
> drivers/pci/pci-bridge-emul.c:176:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> const static struct pci_bridge_reg_behavior pcie_cap_regs_behavior[] = {
> ^
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-08-28 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 15:14 [PATCH] PCI: Move static keyword to the front of declarations in pci-bridge-emul.c Krzysztof Wilczynski
2019-08-27 23:30 ` Bjorn Helgaas
2019-08-28 7:01 ` Thomas Petazzoni
2019-08-28 10:23 ` Krzysztof Wilczynski
2019-08-28 13:17 ` [PATCH v2] " Krzysztof Wilczynski
2019-08-28 13:39 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828153926.1d8d9d7b@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).