linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] reset: Remove copy'n'paste redundancy in the comments
@ 2019-08-19 10:52 Andy Shevchenko
  2019-09-02 13:19 ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2019-08-19 10:52 UTC (permalink / raw)
  To: Philipp Zabel, linux-kernel; +Cc: Andy Shevchenko, Ramiro Oliveira

It seems the commit bb475230b8e5
("reset: make optional functions really optional")
brought couple of redundant lines in the comments.

Drop them here.

Cc: Ramiro Oliveira <Ramiro.Oliveira@synopsys.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/reset/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index 213ff40dda11..2badff33a0db 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -334,7 +334,6 @@ EXPORT_SYMBOL_GPL(reset_control_reset);
  * internal state to be reset, but must be prepared for this to happen.
  * Consumers must not use reset_control_reset on shared reset lines when
  * reset_control_(de)assert has been used.
- * return 0.
  *
  * If rstc is NULL it is an optional reset and the function will just
  * return 0.
@@ -393,7 +392,6 @@ EXPORT_SYMBOL_GPL(reset_control_assert);
  * After calling this function, the reset is guaranteed to be deasserted.
  * Consumers must not use reset_control_reset on shared reset lines when
  * reset_control_(de)assert has been used.
- * return 0.
  *
  * If rstc is NULL it is an optional reset and the function will just
  * return 0.
-- 
2.23.0.rc1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] reset: Remove copy'n'paste redundancy in the comments
  2019-08-19 10:52 [PATCH v1] reset: Remove copy'n'paste redundancy in the comments Andy Shevchenko
@ 2019-09-02 13:19 ` Andy Shevchenko
  2019-09-02 14:04   ` Philipp Zabel
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2019-09-02 13:19 UTC (permalink / raw)
  To: Philipp Zabel, linux-kernel

On Mon, Aug 19, 2019 at 01:52:52PM +0300, Andy Shevchenko wrote:
> It seems the commit bb475230b8e5
> ("reset: make optional functions really optional")
> brought couple of redundant lines in the comments.
> 
> Drop them here.

Any comment on this?

> 
> Cc: Ramiro Oliveira <Ramiro.Oliveira@synopsys.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/reset/core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> index 213ff40dda11..2badff33a0db 100644
> --- a/drivers/reset/core.c
> +++ b/drivers/reset/core.c
> @@ -334,7 +334,6 @@ EXPORT_SYMBOL_GPL(reset_control_reset);
>   * internal state to be reset, but must be prepared for this to happen.
>   * Consumers must not use reset_control_reset on shared reset lines when
>   * reset_control_(de)assert has been used.
> - * return 0.
>   *
>   * If rstc is NULL it is an optional reset and the function will just
>   * return 0.
> @@ -393,7 +392,6 @@ EXPORT_SYMBOL_GPL(reset_control_assert);
>   * After calling this function, the reset is guaranteed to be deasserted.
>   * Consumers must not use reset_control_reset on shared reset lines when
>   * reset_control_(de)assert has been used.
> - * return 0.
>   *
>   * If rstc is NULL it is an optional reset and the function will just
>   * return 0.
> -- 
> 2.23.0.rc1
> 

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] reset: Remove copy'n'paste redundancy in the comments
  2019-09-02 13:19 ` Andy Shevchenko
@ 2019-09-02 14:04   ` Philipp Zabel
  0 siblings, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2019-09-02 14:04 UTC (permalink / raw)
  To: Andy Shevchenko, linux-kernel

Hi Andy,

On Mon, 2019-09-02 at 16:19 +0300, Andy Shevchenko wrote:
> On Mon, Aug 19, 2019 at 01:52:52PM +0300, Andy Shevchenko wrote:
> > It seems the commit bb475230b8e5
> > ("reset: make optional functions really optional")
> > brought couple of redundant lines in the comments.
> > 
> > Drop them here.
> 
> Any comment on this?

No, this looks correct to me. Thank for the patch!
Applied to reset/next.

regards
Philipp

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-09-02 14:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 10:52 [PATCH v1] reset: Remove copy'n'paste redundancy in the comments Andy Shevchenko
2019-09-02 13:19 ` Andy Shevchenko
2019-09-02 14:04   ` Philipp Zabel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).