* [PATCH] ovl: Fix dereferencing possible ERR_PTR()
@ 2019-09-09 8:29 Ding Xiang
2019-09-17 8:06 ` Miklos Szeredi
0 siblings, 1 reply; 2+ messages in thread
From: Ding Xiang @ 2019-09-09 8:29 UTC (permalink / raw)
To: miklos, linux-unionfs; +Cc: linux-kernel
if ovl_encode_real_fh() fails, no memory was allocated
and the error in the error-valued pointer should be returned.
Fixes: 9b6faee0747 ("ovl: check ERR_PTR() return value from ovl_encode_fh()")
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
fs/overlayfs/export.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/overlayfs/export.c b/fs/overlayfs/export.c
index cb8ec1f..50ade19 100644
--- a/fs/overlayfs/export.c
+++ b/fs/overlayfs/export.c
@@ -229,7 +229,7 @@ static int ovl_d_to_fh(struct dentry *dentry, char *buf, int buflen)
ovl_dentry_upper(dentry), !enc_lower);
err = PTR_ERR(fh);
if (IS_ERR(fh))
- goto fail;
+ return err;
err = -EOVERFLOW;
if (fh->len > buflen)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ovl: Fix dereferencing possible ERR_PTR()
2019-09-09 8:29 [PATCH] ovl: Fix dereferencing possible ERR_PTR() Ding Xiang
@ 2019-09-17 8:06 ` Miklos Szeredi
0 siblings, 0 replies; 2+ messages in thread
From: Miklos Szeredi @ 2019-09-17 8:06 UTC (permalink / raw)
To: Ding Xiang; +Cc: overlayfs, linux-kernel
On Mon, Sep 9, 2019 at 10:30 AM Ding Xiang
<dingxiang@cmss.chinamobile.com> wrote:
>
> if ovl_encode_real_fh() fails, no memory was allocated
> and the error in the error-valued pointer should be returned.
Applied, thanks.
Miklos
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-17 8:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-09 8:29 [PATCH] ovl: Fix dereferencing possible ERR_PTR() Ding Xiang
2019-09-17 8:06 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).