* [PATCH] Fix reading support of the 1-4-4-DTR read-mode from the wrong bit of the SFDP table which is part of the linux-imx fork located in the following repo: https://source.codeaurora.org/external/imx/linux-imx/?h=imx_4.14.98_2.1.0
@ 2019-09-11 6:54 Christoph Fink
2019-10-16 8:41 ` Vignesh Raghavendra
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Fink @ 2019-09-11 6:54 UTC (permalink / raw)
Cc: Huang Shijie, Han Xu, Christoph Fink, Cyrille Pitchen,
Marek Vasut, David Woodhouse, Brian Norris, Boris Brezillon,
Richard Weinberger, linux-mtd, linux-kernel
From: Christoph Fink <fink.christoph@gmail.com>
Signed-off-by: Christoph Fink <fink.christoph@gmail.com>
---
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 8cc4b04..7fd52fa 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -2089,7 +2089,7 @@ static const struct sfdp_bfpt_read sfdp_bfpt_reads[] = {
/* Fast Read 1-4-4-DTR */
{
SNOR_HWCAPS_READ_1_4_4_DTR,
- BFPT_DWORD(1), BIT(21), /* Supported bit */
+ BFPT_DWORD(1), BIT(19), /* Supported bit */
BFPT_DWORD(3), 0, /* Settings */
SNOR_PROTO_1_4_4_DTR,
},
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix reading support of the 1-4-4-DTR read-mode from the wrong bit of the SFDP table which is part of the linux-imx fork located in the following repo: https://source.codeaurora.org/external/imx/linux-imx/?h=imx_4.14.98_2.1.0
2019-09-11 6:54 [PATCH] Fix reading support of the 1-4-4-DTR read-mode from the wrong bit of the SFDP table which is part of the linux-imx fork located in the following repo: https://source.codeaurora.org/external/imx/linux-imx/?h=imx_4.14.98_2.1.0 Christoph Fink
@ 2019-10-16 8:41 ` Vignesh Raghavendra
0 siblings, 0 replies; 2+ messages in thread
From: Vignesh Raghavendra @ 2019-10-16 8:41 UTC (permalink / raw)
To: Christoph Fink
Cc: Boris Brezillon, Richard Weinberger, Christoph Fink,
Huang Shijie, linux-kernel, Marek Vasut, linux-mtd,
Cyrille Pitchen, Han Xu, Brian Norris, David Woodhouse
On 11/09/19 12:24 PM, Christoph Fink wrote:
> From: Christoph Fink <fink.christoph@gmail.com>
>
This patch is not against mainline kernel. There is no support for DTR
mode in kernel yet. Below hunk is not even present in the spi-nor.c.
For future submissions:
Subject line should be one line summary of the patch starting with
prefix "mtd: spi-nor:" (hint: run git log on file to know the format)
and commit message should have detailed description of the patch
Regards
Vignesh
> Signed-off-by: Christoph Fink <fink.christoph@gmail.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 8cc4b04..7fd52fa 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -2089,7 +2089,7 @@ static const struct sfdp_bfpt_read sfdp_bfpt_reads[] = {
> /* Fast Read 1-4-4-DTR */
> {
> SNOR_HWCAPS_READ_1_4_4_DTR,
> - BFPT_DWORD(1), BIT(21), /* Supported bit */
> + BFPT_DWORD(1), BIT(19), /* Supported bit */
> BFPT_DWORD(3), 0, /* Settings */
> SNOR_PROTO_1_4_4_DTR,
> },
>
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-16 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 6:54 [PATCH] Fix reading support of the 1-4-4-DTR read-mode from the wrong bit of the SFDP table which is part of the linux-imx fork located in the following repo: https://source.codeaurora.org/external/imx/linux-imx/?h=imx_4.14.98_2.1.0 Christoph Fink
2019-10-16 8:41 ` Vignesh Raghavendra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).