* [RESEND][PATCH] pinctrl: exynos: remove duplicate calls in irq handler
@ 2016-08-16 6:49 perr perr
2016-08-16 9:16 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: perr perr @ 2016-08-16 6:49 UTC (permalink / raw)
To: tomasz.figa
Cc: k.kozlowski, s.nawrocki, linus.walleij, kgene, linux-arm-kernel,
linux-samsung-soc, linux-gpio, linux-kernel
Because chained_irq_enter() has already called chip->irq_mask() and
chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(),
so it's not necessary to call chip->irq_*() here.
Signed-off-by: Perr Zhang<strongbox8@zoho.com>
---
drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
index 051b5bf..d32fa2b 100644
--- a/drivers/pinctrl/samsung/pinctrl-exynos.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
@@ -428,14 +428,10 @@ static void exynos_irq_eint0_15(struct irq_desc *desc)
int eint_irq;
chained_irq_enter(chip, desc);
- chip->irq_mask(&desc->irq_data);
-
- if (chip->irq_ack)
- chip->irq_ack(&desc->irq_data);
eint_irq = irq_linear_revmap(bank->irq_domain, eintd->irq);
generic_handle_irq(eint_irq);
- chip->irq_unmask(&desc->irq_data);
+
chained_irq_exit(chip, desc);
}
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND][PATCH] pinctrl: exynos: remove duplicate calls in irq handler
2016-08-16 6:49 [RESEND][PATCH] pinctrl: exynos: remove duplicate calls in irq handler perr perr
@ 2016-08-16 9:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2016-08-16 9:16 UTC (permalink / raw)
To: perr perr, tomasz.figa
Cc: s.nawrocki, linus.walleij, kgene, linux-arm-kernel,
linux-samsung-soc, linux-gpio, linux-kernel
On 08/16/2016 08:49 AM, perr perr wrote:
> Because chained_irq_enter() has already called chip->irq_mask() and
> chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(),
> so it's not necessary to call chip->irq_*() here.
>
> Signed-off-by: Perr Zhang<strongbox8@zoho.com>
>
> ---
> drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Hi,
Thanks for fixing Signed-off-by but now the commiter name does not match
Signed-off-by. In the same time you skipped the tags you got already
(Tomasz's ack and my reviewed-by).
BR,
Krzysztof
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
> index 051b5bf..d32fa2b 100644
> --- a/drivers/pinctrl/samsung/pinctrl-exynos.c
> +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
> @@ -428,14 +428,10 @@ static void exynos_irq_eint0_15(struct irq_desc *desc)
> int eint_irq;
>
> chained_irq_enter(chip, desc);
> - chip->irq_mask(&desc->irq_data);
> -
> - if (chip->irq_ack)
> - chip->irq_ack(&desc->irq_data);
>
> eint_irq = irq_linear_revmap(bank->irq_domain, eintd->irq);
> generic_handle_irq(eint_irq);
> - chip->irq_unmask(&desc->irq_data);
> +
> chained_irq_exit(chip, desc);
> }
>
> --
> 1.9.3
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Resend][PATCH] pinctrl: exynos: remove duplicate calls in irq handler
@ 2016-08-15 23:56 perr perr
0 siblings, 0 replies; 3+ messages in thread
From: perr perr @ 2016-08-15 23:56 UTC (permalink / raw)
To: tomasz.figa
Cc: k.kozlowski, s.nawrocki, linus.walleij, kgene, linux-arm-kernel,
linux-samsung-soc, linux-gpio, linux-kernel
Because chained_irq_enter() has already called chip->irq_mask() and
chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(),
so it's not necessary to call chip->irq_*() here.
Signed-off-by: Perr Zhang<strongbox8@zoho.com>
---
drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
index 051b5bf..d32fa2b 100644
--- a/drivers/pinctrl/samsung/pinctrl-exynos.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
@@ -428,14 +428,10 @@ static void exynos_irq_eint0_15(struct irq_desc *desc)
int eint_irq;
chained_irq_enter(chip, desc);
- chip->irq_mask(&desc->irq_data);
-
- if (chip->irq_ack)
- chip->irq_ack(&desc->irq_data);
eint_irq = irq_linear_revmap(bank->irq_domain, eintd->irq);
generic_handle_irq(eint_irq);
- chip->irq_unmask(&desc->irq_data);
+
chained_irq_exit(chip, desc);
}
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-16 9:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-16 6:49 [RESEND][PATCH] pinctrl: exynos: remove duplicate calls in irq handler perr perr
2016-08-16 9:16 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2016-08-15 23:56 [Resend][PATCH] " perr perr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).