From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Wei Ni <wni@nvidia.com>, edubezval@gmail.com
Cc: thierry.reding@gmail.com, linux-tegra@vger.kernel.org,
rui.zhang@intel.com, srikars@nvidia.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v7 3/3] thermal: tegra: add get_trend ops
Date: Mon, 30 Mar 2020 19:23:14 +0200 [thread overview]
Message-ID: <156ef39f-4bb2-c7fb-7bf0-abc9e0067c62@linaro.org> (raw)
In-Reply-To: <ecabe3d8-274f-7c0e-f875-6968c65a4425@nvidia.com>
Hi Wei,
On 19/02/2019 03:15, Wei Ni wrote:
>>> +static int tegra_thermctl_get_trend(void *data, int trip, +
>>> enum thermal_trend *trend)
[ ... ]
>>> + temp = tz->temperature; + last_temp = tz->last_temperature; +
>>> mutex_unlock(&tz->lock); + + if (temp > trip_temp) { + if
>>> (temp >= last_temp) + *trend = THERMAL_TREND_RAISING; +
>>> else + *trend = THERMAL_TREND_STABLE; + } else if (temp <
>>> trip_temp) { + *trend = THERMAL_TREND_DROPPING; + } else { +
>>> *trend = THERMAL_TREND_STABLE; + } + + return 0; +} + static
>>> const struct thermal_zone_of_device_ops tegra_of_thermal_ops =
>>> { .get_temp = tegra_thermctl_get_temp, .set_trip_temp =
>>> tegra_thermctl_set_trip_temp, + .get_trend =
>>> tegra_thermctl_get_trend, };
It has been awhile since this patch was submitted and merged by
Eduardo. I replace him to co-maintain the thermal framework with Rui.
While figuring out the internals for code cleanup, I ended up in this
function above.
Why do you have to use this routine instead of the generic one in
get_tz_trend()?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-03-30 17:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 10:12 [PATCH v7 0/3] Fixes for Tegra soctherm Wei Ni
2019-01-03 10:12 ` [PATCH v7 1/3] thermal: tegra: remove unnecessary warnings Wei Ni
2019-02-18 9:47 ` Daniel Lezcano
2019-02-19 2:14 ` Wei Ni
2019-01-03 10:12 ` [PATCH v7 2/3] thermal: tegra: fix memory allocation Wei Ni
2019-02-18 10:24 ` Daniel Lezcano
2019-01-03 10:12 ` [PATCH v7 3/3] thermal: tegra: add get_trend ops Wei Ni
2019-02-18 10:27 ` Daniel Lezcano
2019-02-19 2:15 ` Wei Ni
2020-03-30 17:23 ` Daniel Lezcano [this message]
2019-01-11 2:20 ` [PATCH v7 0/3] Fixes for Tegra soctherm Wei Ni
2019-01-21 9:17 ` Wei Ni
2019-02-18 7:59 ` Wei Ni
2019-02-20 2:14 ` Zhang Rui
2019-02-20 8:42 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156ef39f-4bb2-c7fb-7bf0-abc9e0067c62@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=srikars@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).