From: Wei Ni <wni@nvidia.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, <edubezval@gmail.com>
Cc: <thierry.reding@gmail.com>, <linux-tegra@vger.kernel.org>,
<rui.zhang@intel.com>, <srikars@nvidia.com>,
<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v7 3/3] thermal: tegra: add get_trend ops
Date: Tue, 19 Feb 2019 10:15:05 +0800 [thread overview]
Message-ID: <ecabe3d8-274f-7c0e-f875-6968c65a4425@nvidia.com> (raw)
In-Reply-To: <bae5b0c3-3d7f-0b60-da96-730c7e8c4e5c@linaro.org>
On 18/2/2019 6:27 PM, Daniel Lezcano wrote:
> On 03/01/2019 11:12, Wei Ni wrote:
>> Add support for get_trend ops that allows soctherm
>> sensors to be used with the step-wise governor.
>>
>> Signed-off-by: Wei Ni <wni@nvidia.com>
>> ---
>> drivers/thermal/tegra/soctherm.c | 34 ++++++++++++++++++++++++++++++++++
>> 1 file changed, 34 insertions(+)
>>
>> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
>> index fd2703c0cfc5..864205af104b 100644
>> --- a/drivers/thermal/tegra/soctherm.c
>> +++ b/drivers/thermal/tegra/soctherm.c
>> @@ -488,9 +488,43 @@ static int tegra_thermctl_set_trip_temp(void *data, int trip, int temp)
>> return 0;
>> }
>>
>> +static int tegra_thermctl_get_trend(void *data, int trip,
>> + enum thermal_trend *trend)
>> +{
>> + struct tegra_thermctl_zone *zone = data;
>> + struct thermal_zone_device *tz = zone->tz;
>> + int trip_temp, temp, last_temp, ret;
>> +
>> + if (!tz)
>> + return -EINVAL;
>> +
>> + ret = tz->ops->get_trip_temp(zone->tz, trip, &trip_temp);
>> + if (ret)
>> + return ret;
>> +
>> + mutex_lock(&tz->lock);
>
> No need to use the mutex here.
>
> Why not ?
>
> temp = READ_ONCE(tz->temperature);
> last_temp = READ_ONCE(tz->last_temperature);
Yes, you are right, will change it in next version.
Wei.
>
>> + temp = tz->temperature;
>> + last_temp = tz->last_temperature;
>> + mutex_unlock(&tz->lock);
>> +
>> + if (temp > trip_temp) {
>> + if (temp >= last_temp)
>> + *trend = THERMAL_TREND_RAISING;
>> + else
>> + *trend = THERMAL_TREND_STABLE;
>> + } else if (temp < trip_temp) {
>> + *trend = THERMAL_TREND_DROPPING;
>> + } else {
>> + *trend = THERMAL_TREND_STABLE;
>> + }
>> +
>> + return 0;
>> +}
>> +
>> static const struct thermal_zone_of_device_ops tegra_of_thermal_ops = {
>> .get_temp = tegra_thermctl_get_temp,
>> .set_trip_temp = tegra_thermctl_set_trip_temp,
>> + .get_trend = tegra_thermctl_get_trend,
>> };
>>
>> static int get_hot_temp(struct thermal_zone_device *tz, int *trip, int *temp)
>>
>
>
next prev parent reply other threads:[~2019-02-19 2:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 10:12 [PATCH v7 0/3] Fixes for Tegra soctherm Wei Ni
2019-01-03 10:12 ` [PATCH v7 1/3] thermal: tegra: remove unnecessary warnings Wei Ni
2019-02-18 9:47 ` Daniel Lezcano
2019-02-19 2:14 ` Wei Ni
2019-01-03 10:12 ` [PATCH v7 2/3] thermal: tegra: fix memory allocation Wei Ni
2019-02-18 10:24 ` Daniel Lezcano
2019-01-03 10:12 ` [PATCH v7 3/3] thermal: tegra: add get_trend ops Wei Ni
2019-02-18 10:27 ` Daniel Lezcano
2019-02-19 2:15 ` Wei Ni [this message]
2020-03-30 17:23 ` Daniel Lezcano
2019-01-11 2:20 ` [PATCH v7 0/3] Fixes for Tegra soctherm Wei Ni
2019-01-21 9:17 ` Wei Ni
2019-02-18 7:59 ` Wei Ni
2019-02-20 2:14 ` Zhang Rui
2019-02-20 8:42 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecabe3d8-274f-7c0e-f875-6968c65a4425@nvidia.com \
--to=wni@nvidia.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=srikars@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).