* [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
@ 2019-10-21 9:21 Peng Fan
2019-10-21 9:21 ` [PATCH 2/2] arm64: dts: imx8mn-ddr4-evk: " Peng Fan
2019-10-21 9:44 ` [PATCH 1/2] arm64: dts: imx8mm-evk: " Marco Felsch
0 siblings, 2 replies; 10+ messages in thread
From: Peng Fan @ 2019-10-21 9:21 UTC (permalink / raw)
To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam
Cc: dl-linux-imx, Anson Huang, Leonard Crestez, Daniel Baluta,
Jacky Bai, Jun Li, devicetree, linux-arm-kernel, linux-kernel,
Andy Duan, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
We should not rely on U-Boot to configure the phy reset.
So introduce phy-reset-gpios property to let Linux handle phy reset
itself.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
index faefb7182af1..e4d66f7db09d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
@@ -80,6 +80,7 @@
pinctrl-0 = <&pinctrl_fec1>;
phy-mode = "rgmii-id";
phy-handle = <ðphy0>;
+ phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
fsl,magic-packet;
status = "okay";
--
2.16.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] arm64: dts: imx8mn-ddr4-evk: add phy-reset-gpios for fec1
2019-10-21 9:21 [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1 Peng Fan
@ 2019-10-21 9:21 ` Peng Fan
2019-10-21 9:44 ` [PATCH 1/2] arm64: dts: imx8mm-evk: " Marco Felsch
1 sibling, 0 replies; 10+ messages in thread
From: Peng Fan @ 2019-10-21 9:21 UTC (permalink / raw)
To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam
Cc: dl-linux-imx, Anson Huang, Leonard Crestez, Daniel Baluta,
Jacky Bai, Jun Li, devicetree, linux-arm-kernel, linux-kernel,
Andy Duan, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
We should not rely on U-Boot to configure the phy reset.
So introduce phy-reset-gpios property to let Linux handle phy reset
itself.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
index 1b90faace1d3..761ba0b5d271 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
@@ -48,6 +48,7 @@
pinctrl-0 = <&pinctrl_fec1>;
phy-mode = "rgmii-id";
phy-handle = <ðphy0>;
+ phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
fsl,magic-packet;
status = "okay";
--
2.16.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
2019-10-21 9:21 [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1 Peng Fan
2019-10-21 9:21 ` [PATCH 2/2] arm64: dts: imx8mn-ddr4-evk: " Peng Fan
@ 2019-10-21 9:44 ` Marco Felsch
2019-10-21 9:46 ` Peng Fan
1 sibling, 1 reply; 10+ messages in thread
From: Marco Felsch @ 2019-10-21 9:44 UTC (permalink / raw)
To: Peng Fan
Cc: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
devicetree, Andy Duan, Jacky Bai, Anson Huang, linux-kernel,
dl-linux-imx, Leonard Crestez, Daniel Baluta, linux-arm-kernel,
Jun Li
Hi,
On 19-10-21 09:21, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> We should not rely on U-Boot to configure the phy reset.
> So introduce phy-reset-gpios property to let Linux handle phy reset
> itself.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index faefb7182af1..e4d66f7db09d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -80,6 +80,7 @@
> pinctrl-0 = <&pinctrl_fec1>;
> phy-mode = "rgmii-id";
> phy-handle = <ðphy0>;
> + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
Where is the pinctrl done?
Regards,
Marco
> fsl,magic-packet;
> status = "okay";
>
> --
> 2.16.4
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
2019-10-21 9:44 ` [PATCH 1/2] arm64: dts: imx8mm-evk: " Marco Felsch
@ 2019-10-21 9:46 ` Peng Fan
2019-10-21 9:50 ` Marco Felsch
0 siblings, 1 reply; 10+ messages in thread
From: Peng Fan @ 2019-10-21 9:46 UTC (permalink / raw)
To: Marco Felsch
Cc: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
devicetree, Andy Duan, Jacky Bai, Anson Huang, linux-kernel,
dl-linux-imx, Leonard Crestez, Daniel Baluta, linux-arm-kernel,
Jun Li
> Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for
> fec1
>
> Hi,
>
> On 19-10-21 09:21, Peng Fan wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > We should not rely on U-Boot to configure the phy reset.
> > So introduce phy-reset-gpios property to let Linux handle phy reset
> > itself.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > index faefb7182af1..e4d66f7db09d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > @@ -80,6 +80,7 @@
> > pinctrl-0 = <&pinctrl_fec1>;
> > phy-mode = "rgmii-id";
> > phy-handle = <ðphy0>;
> > + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
>
> Where is the pinctrl done?
https://elixir.bootlin.com/linux/v5.4-rc2/source/arch/arm64/boot/dts/freescale/imx8mm-evk.dts#L328
Regards,
Peng.
>
> Regards,
> Marco
>
> > fsl,magic-packet;
> > status = "okay";
> >
> > --
> > 2.16.4
> >
> >
> >
>
> --
> Pengutronix e.K. |
> |
> Industrial Linux Solutions |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p
> engutronix.de%2F&data=02%7C01%7Cpeng.fan%40nxp.com%7Cb40bb6
> 4c5e39449ade4808d7560b43ca%7C686ea1d3bc2b4c6fa92cd99c5c301635%
> 7C0%7C0%7C637072478688921047&sdata=xZI60uyyQ%2BkX%2Fpf07n
> CgVhGt1ApYBKSnndGB3Dk2578%3D&reserved=0 |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0
> |
> Amtsgericht Hildesheim, HRA 2686 | Fax:
> +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
2019-10-21 9:46 ` Peng Fan
@ 2019-10-21 9:50 ` Marco Felsch
0 siblings, 0 replies; 10+ messages in thread
From: Marco Felsch @ 2019-10-21 9:50 UTC (permalink / raw)
To: Peng Fan
Cc: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
devicetree, Andy Duan, Jacky Bai, Anson Huang, linux-kernel,
dl-linux-imx, Leonard Crestez, Daniel Baluta, linux-arm-kernel,
Jun Li
On 19-10-21 09:46, Peng Fan wrote:
> > Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for
> > fec1
> >
> > Hi,
> >
> > On 19-10-21 09:21, Peng Fan wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > We should not rely on U-Boot to configure the phy reset.
nitpick: s/U-Boot/bootloader/ ?
> > > So introduce phy-reset-gpios property to let Linux handle phy reset
> > > itself.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > > index faefb7182af1..e4d66f7db09d 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > > @@ -80,6 +80,7 @@
> > > pinctrl-0 = <&pinctrl_fec1>;
> > > phy-mode = "rgmii-id";
> > > phy-handle = <ðphy0>;
> > > + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
> >
> > Where is the pinctrl done?
>
> https://elixir.bootlin.com/linux/v5.4-rc2/source/arch/arm64/boot/dts/freescale/imx8mm-evk.dts#L328
Thanks :)
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Regards,
Marco
> Regards,
> Peng.
>
> >
> > Regards,
> > Marco
> >
> > > fsl,magic-packet;
> > > status = "okay";
> > >
> > > --
> > > 2.16.4
> > >
> > >
> > >
> >
> > --
> > Pengutronix e.K. |
> > |
> > Industrial Linux Solutions |
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p
> > engutronix.de%2F&data=02%7C01%7Cpeng.fan%40nxp.com%7Cb40bb6
> > 4c5e39449ade4808d7560b43ca%7C686ea1d3bc2b4c6fa92cd99c5c301635%
> > 7C0%7C0%7C637072478688921047&sdata=xZI60uyyQ%2BkX%2Fpf07n
> > CgVhGt1ApYBKSnndGB3Dk2578%3D&reserved=0 |
> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0
> > |
> > Amtsgericht Hildesheim, HRA 2686 | Fax:
> > +49-5121-206917-5555 |
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
2020-02-14 19:27 Alifer Moraes
2020-02-17 8:20 ` Marco Felsch
2020-02-19 1:15 ` Fabio Estevam
@ 2020-02-24 1:37 ` Shawn Guo
2 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2020-02-24 1:37 UTC (permalink / raw)
To: Alifer Moraes
Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam, linux-imx,
peng.fan, leonard.crestez, devicetree, linux-kernel
On Fri, Feb 14, 2020 at 04:27:49PM -0300, Alifer Moraes wrote:
> imx8mm-evk has a GPIO connected to AR8031 Ethernet PHY's reset pin.
>
> Describe it in the device tree, following phy's datasheet reset duration of 10ms.
>
> Tested booting via NFS.
>
> Signed-off-by: Alifer Moraes <alifer.wsdm@gmail.com>
Applied both, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
2020-02-14 19:27 Alifer Moraes
2020-02-17 8:20 ` Marco Felsch
@ 2020-02-19 1:15 ` Fabio Estevam
2020-02-24 1:37 ` Shawn Guo
2 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2020-02-19 1:15 UTC (permalink / raw)
To: Alifer Moraes
Cc: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer, Sascha Hauer,
NXP Linux Team, Peng Fan, Leonard Crestez,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Fri, Feb 14, 2020 at 4:27 PM Alifer Moraes <alifer.wsdm@gmail.com> wrote:
>
> imx8mm-evk has a GPIO connected to AR8031 Ethernet PHY's reset pin.
>
> Describe it in the device tree, following phy's datasheet reset duration of 10ms.
>
> Tested booting via NFS.
>
> Signed-off-by: Alifer Moraes <alifer.wsdm@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
2020-02-17 8:20 ` Marco Felsch
@ 2020-02-18 13:02 ` Alifer Moraes
0 siblings, 0 replies; 10+ messages in thread
From: Alifer Moraes @ 2020-02-18 13:02 UTC (permalink / raw)
To: Marco Felsch
Cc: robh+dt, mark.rutland, devicetree, peng.fan, shawnguo, s.hauer,
linux-kernel, linux-imx, kernel, leonard.crestez, Fabio Estevam
Hello,
I forgot to select reply all in this question, so I answered only to Marco.
> Where is this gpio muxed?
>
The gpio is muxed in the subnode pinctrl_fec1.
Regards,
Alifer
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
2020-02-14 19:27 Alifer Moraes
@ 2020-02-17 8:20 ` Marco Felsch
2020-02-18 13:02 ` Alifer Moraes
2020-02-19 1:15 ` Fabio Estevam
2020-02-24 1:37 ` Shawn Guo
2 siblings, 1 reply; 10+ messages in thread
From: Marco Felsch @ 2020-02-17 8:20 UTC (permalink / raw)
To: Alifer Moraes
Cc: robh+dt, mark.rutland, devicetree, peng.fan, shawnguo, s.hauer,
linux-kernel, linux-imx, kernel, leonard.crestez, festevam
Hi,
On 20-02-14 16:27, Alifer Moraes wrote:
> imx8mm-evk has a GPIO connected to AR8031 Ethernet PHY's reset pin.
>
> Describe it in the device tree, following phy's datasheet reset duration of 10ms.
>
> Tested booting via NFS.
>
> Signed-off-by: Alifer Moraes <alifer.wsdm@gmail.com>
> ---
>
> Originally sent by Peng Fan <peng.fan@nxp.com>
>
> Back then CONFIG_AT803X_PHY was set as "m" in defconfig so the boot process hung
> at nfs boot, now that CONFIG_AT803X_PHY is set as "y" by default, the patch works
> correctly.
>
> Peng's original patch missed to pass the phy-reset-duration, according to the AR8031
> datasheet the reset GPIO needs to stay low for 10ms.
>
> Original thread: https://lkml.org/lkml/2019/10/21/347
>
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index 28ab17a277bb..11903ca86f0e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -82,6 +82,8 @@
> pinctrl-0 = <&pinctrl_fec1>;
> phy-mode = "rgmii-id";
> phy-handle = <ðphy0>;
> + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
Where is this gpio muxed?
Regards,
Marco
> + phy-reset-duration = <10>;
> fsl,magic-packet;
> status = "okay";
>
> --
> 2.17.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
@ 2020-02-14 19:27 Alifer Moraes
2020-02-17 8:20 ` Marco Felsch
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Alifer Moraes @ 2020-02-14 19:27 UTC (permalink / raw)
To: robh+dt
Cc: mark.rutland, shawnguo, s.hauer, kernel, festevam, linux-imx,
peng.fan, leonard.crestez, devicetree, linux-kernel,
Alifer Moraes
imx8mm-evk has a GPIO connected to AR8031 Ethernet PHY's reset pin.
Describe it in the device tree, following phy's datasheet reset duration of 10ms.
Tested booting via NFS.
Signed-off-by: Alifer Moraes <alifer.wsdm@gmail.com>
---
Originally sent by Peng Fan <peng.fan@nxp.com>
Back then CONFIG_AT803X_PHY was set as "m" in defconfig so the boot process hung
at nfs boot, now that CONFIG_AT803X_PHY is set as "y" by default, the patch works
correctly.
Peng's original patch missed to pass the phy-reset-duration, according to the AR8031
datasheet the reset GPIO needs to stay low for 10ms.
Original thread: https://lkml.org/lkml/2019/10/21/347
arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
index 28ab17a277bb..11903ca86f0e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
@@ -82,6 +82,8 @@
pinctrl-0 = <&pinctrl_fec1>;
phy-mode = "rgmii-id";
phy-handle = <ðphy0>;
+ phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
+ phy-reset-duration = <10>;
fsl,magic-packet;
status = "okay";
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-02-24 1:37 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 9:21 [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1 Peng Fan
2019-10-21 9:21 ` [PATCH 2/2] arm64: dts: imx8mn-ddr4-evk: " Peng Fan
2019-10-21 9:44 ` [PATCH 1/2] arm64: dts: imx8mm-evk: " Marco Felsch
2019-10-21 9:46 ` Peng Fan
2019-10-21 9:50 ` Marco Felsch
2020-02-14 19:27 Alifer Moraes
2020-02-17 8:20 ` Marco Felsch
2020-02-18 13:02 ` Alifer Moraes
2020-02-19 1:15 ` Fabio Estevam
2020-02-24 1:37 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).