* [PATCH] power: supply: cpcap-charger: Make cpcap_charger_voltage_to_regval static
@ 2019-10-21 15:40 zhong jiang
2019-10-21 17:04 ` Sebastian Reichel
2019-10-28 16:16 ` zhong jiang
0 siblings, 2 replies; 5+ messages in thread
From: zhong jiang @ 2019-10-21 15:40 UTC (permalink / raw)
To: sre; +Cc: linux-pm, linux-kernel, zhongjiang
The GCC complains the following case when compiling kernel.
drivers/power/supply/cpcap-charger.c:563:5: warning: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/power/supply/cpcap-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
index 40d96b8..c0d452e 100644
--- a/drivers/power/supply/cpcap-charger.c
+++ b/drivers/power/supply/cpcap-charger.c
@@ -560,7 +560,7 @@ static void cpcap_charger_update_state(struct cpcap_charger_ddata *ddata,
dev_dbg(ddata->dev, "state: %s\n", status);
}
-int cpcap_charger_voltage_to_regval(int voltage)
+static int cpcap_charger_voltage_to_regval(int voltage)
{
int offset;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] power: supply: cpcap-charger: Make cpcap_charger_voltage_to_regval static
2019-10-21 15:40 [PATCH] power: supply: cpcap-charger: Make cpcap_charger_voltage_to_regval static zhong jiang
@ 2019-10-21 17:04 ` Sebastian Reichel
2019-10-28 16:16 ` zhong jiang
1 sibling, 0 replies; 5+ messages in thread
From: Sebastian Reichel @ 2019-10-21 17:04 UTC (permalink / raw)
To: zhong jiang; +Cc: linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
Hi,
On Mon, Oct 21, 2019 at 11:40:07PM +0800, zhong jiang wrote:
> The GCC complains the following case when compiling kernel.
>
> drivers/power/supply/cpcap-charger.c:563:5: warning: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
Thanks, but Intel's kbuild test robot was faster than you:
https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/commit/?h=for-next
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] power: supply: cpcap-charger: Make cpcap_charger_voltage_to_regval static
2019-10-21 15:40 [PATCH] power: supply: cpcap-charger: Make cpcap_charger_voltage_to_regval static zhong jiang
2019-10-21 17:04 ` Sebastian Reichel
@ 2019-10-28 16:16 ` zhong jiang
2019-10-28 21:56 ` Sebastian Reichel
1 sibling, 1 reply; 5+ messages in thread
From: zhong jiang @ 2019-10-28 16:16 UTC (permalink / raw)
To: zhong jiang; +Cc: sre, linux-pm, linux-kernel
ping.
On 2019/10/21 23:40, zhong jiang wrote:
> The GCC complains the following case when compiling kernel.
>
> drivers/power/supply/cpcap-charger.c:563:5: warning: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/power/supply/cpcap-charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
> index 40d96b8..c0d452e 100644
> --- a/drivers/power/supply/cpcap-charger.c
> +++ b/drivers/power/supply/cpcap-charger.c
> @@ -560,7 +560,7 @@ static void cpcap_charger_update_state(struct cpcap_charger_ddata *ddata,
> dev_dbg(ddata->dev, "state: %s\n", status);
> }
>
> -int cpcap_charger_voltage_to_regval(int voltage)
> +static int cpcap_charger_voltage_to_regval(int voltage)
> {
> int offset;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] power: supply: cpcap-charger: Make cpcap_charger_voltage_to_regval static
2019-10-28 16:16 ` zhong jiang
@ 2019-10-28 21:56 ` Sebastian Reichel
2019-10-29 3:09 ` zhong jiang
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Reichel @ 2019-10-28 21:56 UTC (permalink / raw)
To: zhong jiang; +Cc: linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
Hi,
https://lkml.org/lkml/2019/10/21/1018
That's e3da2ce04e12 to be specific.
-- Sebastian
On Tue, Oct 29, 2019 at 12:16:37AM +0800, zhong jiang wrote:
> ping.
>
> On 2019/10/21 23:40, zhong jiang wrote:
> > The GCC complains the following case when compiling kernel.
> >
> > drivers/power/supply/cpcap-charger.c:563:5: warning: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
> >
> > Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> > ---
> > drivers/power/supply/cpcap-charger.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
> > index 40d96b8..c0d452e 100644
> > --- a/drivers/power/supply/cpcap-charger.c
> > +++ b/drivers/power/supply/cpcap-charger.c
> > @@ -560,7 +560,7 @@ static void cpcap_charger_update_state(struct cpcap_charger_ddata *ddata,
> > dev_dbg(ddata->dev, "state: %s\n", status);
> > }
> >
> > -int cpcap_charger_voltage_to_regval(int voltage)
> > +static int cpcap_charger_voltage_to_regval(int voltage)
> > {
> > int offset;
> >
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] power: supply: cpcap-charger: Make cpcap_charger_voltage_to_regval static
2019-10-28 21:56 ` Sebastian Reichel
@ 2019-10-29 3:09 ` zhong jiang
0 siblings, 0 replies; 5+ messages in thread
From: zhong jiang @ 2019-10-29 3:09 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: linux-pm, linux-kernel
Sorry, I forget that.
Thanks,
zhogn jiang
On 2019/10/29 5:56, Sebastian Reichel wrote:
> Hi,
>
> https://lkml.org/lkml/2019/10/21/1018
>
> That's e3da2ce04e12 to be specific.
>
> -- Sebastian
>
> On Tue, Oct 29, 2019 at 12:16:37AM +0800, zhong jiang wrote:
>> ping.
>>
>> On 2019/10/21 23:40, zhong jiang wrote:
>>> The GCC complains the following case when compiling kernel.
>>>
>>> drivers/power/supply/cpcap-charger.c:563:5: warning: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
>>>
>>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>>> ---
>>> drivers/power/supply/cpcap-charger.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
>>> index 40d96b8..c0d452e 100644
>>> --- a/drivers/power/supply/cpcap-charger.c
>>> +++ b/drivers/power/supply/cpcap-charger.c
>>> @@ -560,7 +560,7 @@ static void cpcap_charger_update_state(struct cpcap_charger_ddata *ddata,
>>> dev_dbg(ddata->dev, "state: %s\n", status);
>>> }
>>>
>>> -int cpcap_charger_voltage_to_regval(int voltage)
>>> +static int cpcap_charger_voltage_to_regval(int voltage)
>>> {
>>> int offset;
>>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-29 3:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 15:40 [PATCH] power: supply: cpcap-charger: Make cpcap_charger_voltage_to_regval static zhong jiang
2019-10-21 17:04 ` Sebastian Reichel
2019-10-28 16:16 ` zhong jiang
2019-10-28 21:56 ` Sebastian Reichel
2019-10-29 3:09 ` zhong jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).