* [RESEND][PATCH net-next] net: sched: taprio: fix -Wmissing-prototypes warnings
@ 2019-10-21 23:57 Yi Wang
2019-10-22 20:39 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Yi Wang @ 2019-10-21 23:57 UTC (permalink / raw)
To: vinicius.gomes, jhs
Cc: xiyou.wangcong, jiri, davem, netdev, linux-kernel, xue.zhihong,
wang.yi59, up2wing, wang.liang82
We get one warnings when build kernel W=1:
net/sched/sch_taprio.c:1155:6: warning: no previous prototype for ‘taprio_offload_config_changed’ [-Wmissing-prototypes]
Make the function static to fix this.
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
---
net/sched/sch_taprio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 6719a65..2121187 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -1152,7 +1152,7 @@ void taprio_offload_free(struct tc_taprio_qopt_offload *offload)
* offload state (PENDING, ACTIVE, INACTIVE) so it can be visible in dump().
* This is left as TODO.
*/
-void taprio_offload_config_changed(struct taprio_sched *q)
+static void taprio_offload_config_changed(struct taprio_sched *q)
{
struct sched_gate_list *oper, *admin;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND][PATCH net-next] net: sched: taprio: fix -Wmissing-prototypes warnings
2019-10-21 23:57 [RESEND][PATCH net-next] net: sched: taprio: fix -Wmissing-prototypes warnings Yi Wang
@ 2019-10-22 20:39 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2019-10-22 20:39 UTC (permalink / raw)
To: Yi Wang
Cc: vinicius.gomes, jhs, xiyou.wangcong, jiri, davem, netdev,
linux-kernel, xue.zhihong, up2wing, wang.liang82
On Tue, 22 Oct 2019 07:57:42 +0800, Yi Wang wrote:
> We get one warnings when build kernel W=1:
> net/sched/sch_taprio.c:1155:6: warning: no previous prototype for ‘taprio_offload_config_changed’ [-Wmissing-prototypes]
>
> Make the function static to fix this.
>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Thank you!
I've added Fixes tag and applied this to the net tree, since the warning
is already present there.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-22 20:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 23:57 [RESEND][PATCH net-next] net: sched: taprio: fix -Wmissing-prototypes warnings Yi Wang
2019-10-22 20:39 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).