* [PATCH 0/7] fix various gcc warnings
@ 2019-11-04 13:27 yu kuai
2019-11-04 13:27 ` [PATCH 1/7] drm/amdgpu: remove 4 set but not used variable in amdgpu_atombios_get_connector_info_from_object_table yu kuai
` (6 more replies)
0 siblings, 7 replies; 9+ messages in thread
From: yu kuai @ 2019-11-04 13:27 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, David1.Zhou, airlied,
daniel, Jammy.Zhou, tianci.yin, sam, luben.tuikov
Cc: amd-gfx, dri-devel, linux-kernel, yukuai3, zhengbin13, yi.zhang
This patch set fixes various gcc warnings.
yu kuai (7):
drm/amdgpu: remove 4 set but not used variable in
amdgpu_atombios_get_connector_info_from_object_table
drm/amdgpu: add function parameter description in
'amdgpu_device_set_cg_state'
drm/amdgpu: add function parameter description in 'amdgpu_gart_bind'
drm/amdgpu: remove set but not used variable 'dig_connector'
drm/amdgpu: remove set but not used variable 'dig'
drm/amdgpu: remove always false comparison in
'amdgpu_atombios_i2c_process_i2c_ch'
drm/amdgpu: remove set but not used variable 'mc_shared_chmap'
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 20 ++------------------
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 1 +
drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 5 -----
drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 5 -----
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 3 +--
6 files changed, 5 insertions(+), 30 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/7] drm/amdgpu: remove 4 set but not used variable in amdgpu_atombios_get_connector_info_from_object_table
2019-11-04 13:27 [PATCH 0/7] fix various gcc warnings yu kuai
@ 2019-11-04 13:27 ` yu kuai
2019-11-04 13:27 ` [PATCH 2/7] drm/amdgpu: add function parameter description in 'amdgpu_device_set_cg_state' yu kuai
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: yu kuai @ 2019-11-04 13:27 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, David1.Zhou, airlied,
daniel, Jammy.Zhou, tianci.yin, sam, luben.tuikov
Cc: amd-gfx, dri-devel, linux-kernel, yukuai3, zhengbin13, yi.zhang
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c: In function
'amdgpu_atombios_get_connector_info_from_object_table':
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:376:26: warning: variable
'grph_obj_num' set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:376:13: warning: variable
'grph_obj_id' set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:341:37: warning: variable
'con_obj_type' set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:341:24: warning: variable
'con_obj_num' set but not used [-Wunused-but-set-variable]
They are never used, so can be removed.
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 19 ++-----------------
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
index 72232fc..be6d0cf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
@@ -338,17 +338,9 @@ bool amdgpu_atombios_get_connector_info_from_object_table(struct amdgpu_device *
path_size += le16_to_cpu(path->usSize);
if (device_support & le16_to_cpu(path->usDeviceTag)) {
- uint8_t con_obj_id, con_obj_num, con_obj_type;
-
- con_obj_id =
+ uint8_t con_obj_id =
(le16_to_cpu(path->usConnObjectId) & OBJECT_ID_MASK)
>> OBJECT_ID_SHIFT;
- con_obj_num =
- (le16_to_cpu(path->usConnObjectId) & ENUM_ID_MASK)
- >> ENUM_ID_SHIFT;
- con_obj_type =
- (le16_to_cpu(path->usConnObjectId) &
- OBJECT_TYPE_MASK) >> OBJECT_TYPE_SHIFT;
/* Skip TV/CV support */
if ((le16_to_cpu(path->usDeviceTag) ==
@@ -373,14 +365,7 @@ bool amdgpu_atombios_get_connector_info_from_object_table(struct amdgpu_device *
router.ddc_valid = false;
router.cd_valid = false;
for (j = 0; j < ((le16_to_cpu(path->usSize) - 8) / 2); j++) {
- uint8_t grph_obj_id, grph_obj_num, grph_obj_type;
-
- grph_obj_id =
- (le16_to_cpu(path->usGraphicObjIds[j]) &
- OBJECT_ID_MASK) >> OBJECT_ID_SHIFT;
- grph_obj_num =
- (le16_to_cpu(path->usGraphicObjIds[j]) &
- ENUM_ID_MASK) >> ENUM_ID_SHIFT;
+ uint8_t grph_obj_type=
grph_obj_type =
(le16_to_cpu(path->usGraphicObjIds[j]) &
OBJECT_TYPE_MASK) >> OBJECT_TYPE_SHIFT;
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/7] drm/amdgpu: add function parameter description in 'amdgpu_device_set_cg_state'
2019-11-04 13:27 [PATCH 0/7] fix various gcc warnings yu kuai
2019-11-04 13:27 ` [PATCH 1/7] drm/amdgpu: remove 4 set but not used variable in amdgpu_atombios_get_connector_info_from_object_table yu kuai
@ 2019-11-04 13:27 ` yu kuai
2019-11-04 13:27 ` [PATCH 3/7] drm/amdgpu: add function parameter description in 'amdgpu_gart_bind' yu kuai
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: yu kuai @ 2019-11-04 13:27 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, David1.Zhou, airlied,
daniel, Jammy.Zhou, tianci.yin, sam, luben.tuikov
Cc: amd-gfx, dri-devel, linux-kernel, yukuai3, zhengbin13, yi.zhang
Fixes gcc warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1954: warning: Function
parameter or member 'state' not described in 'amdgpu_device_set_cg_state'
Fixes: e3ecdffac9cc ("drm/amdgpu: add documentation for amdgpu_device.c")
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index b4fb6d8..26c43e5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1941,6 +1941,7 @@ static bool amdgpu_device_check_vram_lost(struct amdgpu_device *adev)
* amdgpu_device_set_cg_state - set clockgating for amdgpu device
*
* @adev: amdgpu_device pointer
+ * @state: clockgating state (gate or ungate)
*
* The list of all the hardware IPs that make up the asic is walked and the
* set_clockgating_state callbacks are run.
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/7] drm/amdgpu: add function parameter description in 'amdgpu_gart_bind'
2019-11-04 13:27 [PATCH 0/7] fix various gcc warnings yu kuai
2019-11-04 13:27 ` [PATCH 1/7] drm/amdgpu: remove 4 set but not used variable in amdgpu_atombios_get_connector_info_from_object_table yu kuai
2019-11-04 13:27 ` [PATCH 2/7] drm/amdgpu: add function parameter description in 'amdgpu_device_set_cg_state' yu kuai
@ 2019-11-04 13:27 ` yu kuai
2019-11-04 13:27 ` [PATCH 4/7] drm/amdgpu: remove set but not used variable 'dig_connector' yu kuai
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: yu kuai @ 2019-11-04 13:27 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, David1.Zhou, airlied,
daniel, Jammy.Zhou, tianci.yin, sam, luben.tuikov
Cc: amd-gfx, dri-devel, linux-kernel, yukuai3, zhengbin13, yi.zhang
Fixes gcc warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c:313: warning: Function
parameter or member 'flags' not described in 'amdgpu_gart_bind'
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c
index 19705e3..e01e681 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c
@@ -302,6 +302,7 @@ int amdgpu_gart_map(struct amdgpu_device *adev, uint64_t offset,
* @pages: number of pages to bind
* @pagelist: pages to bind
* @dma_addr: DMA addresses of pages
+ * @flags: page table entry flags
*
* Binds the requested pages to the gart page table
* (all asics).
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 4/7] drm/amdgpu: remove set but not used variable 'dig_connector'
2019-11-04 13:27 [PATCH 0/7] fix various gcc warnings yu kuai
` (2 preceding siblings ...)
2019-11-04 13:27 ` [PATCH 3/7] drm/amdgpu: add function parameter description in 'amdgpu_gart_bind' yu kuai
@ 2019-11-04 13:27 ` yu kuai
2019-11-04 13:27 ` [PATCH 5/7] drm/amdgpu: remove set but not used variable 'dig' yu kuai
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: yu kuai @ 2019-11-04 13:27 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, David1.Zhou, airlied,
daniel, Jammy.Zhou, tianci.yin, sam, luben.tuikov
Cc: amd-gfx, dri-devel, linux-kernel, yukuai3, zhengbin13, yi.zhang
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/amdgpu/atombios_dp.c: In function
‘amdgpu_atombios_dp_get_panel_mode’:
drivers/gpu/drm/amd/amdgpu/atombios_dp.c:364:36: warning: variable
‘dig_connector’ set but not used [-Wunused-but-set-variable]
It is never used, so can be removed.
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_dp.c b/drivers/gpu/drm/amd/amdgpu/atombios_dp.c
index 6858cde..9426530 100644
--- a/drivers/gpu/drm/amd/amdgpu/atombios_dp.c
+++ b/drivers/gpu/drm/amd/amdgpu/atombios_dp.c
@@ -361,7 +361,6 @@ int amdgpu_atombios_dp_get_panel_mode(struct drm_encoder *encoder,
struct drm_connector *connector)
{
struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
- struct amdgpu_connector_atom_dig *dig_connector;
int panel_mode = DP_PANEL_MODE_EXTERNAL_DP_MODE;
u16 dp_bridge = amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector);
u8 tmp;
@@ -369,8 +368,6 @@ int amdgpu_atombios_dp_get_panel_mode(struct drm_encoder *encoder,
if (!amdgpu_connector->con_priv)
return panel_mode;
- dig_connector = amdgpu_connector->con_priv;
-
if (dp_bridge != ENCODER_OBJECT_ID_NONE) {
/* DP bridge chips */
if (drm_dp_dpcd_readb(&amdgpu_connector->ddc_bus->aux,
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 5/7] drm/amdgpu: remove set but not used variable 'dig'
2019-11-04 13:27 [PATCH 0/7] fix various gcc warnings yu kuai
` (3 preceding siblings ...)
2019-11-04 13:27 ` [PATCH 4/7] drm/amdgpu: remove set but not used variable 'dig_connector' yu kuai
@ 2019-11-04 13:27 ` yu kuai
2019-11-04 13:27 ` [PATCH 6/7] drm/amdgpu: remove always false comparison in 'amdgpu_atombios_i2c_process_i2c_ch' yu kuai
2019-11-04 13:27 ` [PATCH 7/7] drm/amdgpu: remove set but not used variable 'mc_shared_chmap' yu kuai
6 siblings, 0 replies; 9+ messages in thread
From: yu kuai @ 2019-11-04 13:27 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, David1.Zhou, airlied,
daniel, Jammy.Zhou, tianci.yin, sam, luben.tuikov
Cc: amd-gfx, dri-devel, linux-kernel, yukuai3, zhengbin13, yi.zhang
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/amdgpu/atombios_dp.c: In function
‘amdgpu_atombios_dp_link_train’:
drivers/gpu/drm/amd/amdgpu/atombios_dp.c:716:34: warning: variable ‘dig’
set but not used [-Wunused-but-set-variable]
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_dp.c b/drivers/gpu/drm/amd/amdgpu/atombios_dp.c
index 9426530..ea702a6 100644
--- a/drivers/gpu/drm/amd/amdgpu/atombios_dp.c
+++ b/drivers/gpu/drm/amd/amdgpu/atombios_dp.c
@@ -710,7 +710,6 @@ void amdgpu_atombios_dp_link_train(struct drm_encoder *encoder,
struct drm_device *dev = encoder->dev;
struct amdgpu_device *adev = dev->dev_private;
struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
- struct amdgpu_encoder_atom_dig *dig;
struct amdgpu_connector *amdgpu_connector;
struct amdgpu_connector_atom_dig *dig_connector;
struct amdgpu_atombios_dp_link_train_info dp_info;
@@ -718,7 +717,6 @@ void amdgpu_atombios_dp_link_train(struct drm_encoder *encoder,
if (!amdgpu_encoder->enc_priv)
return;
- dig = amdgpu_encoder->enc_priv;
amdgpu_connector = to_amdgpu_connector(connector);
if (!amdgpu_connector->con_priv)
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 6/7] drm/amdgpu: remove always false comparison in 'amdgpu_atombios_i2c_process_i2c_ch'
2019-11-04 13:27 [PATCH 0/7] fix various gcc warnings yu kuai
` (4 preceding siblings ...)
2019-11-04 13:27 ` [PATCH 5/7] drm/amdgpu: remove set but not used variable 'dig' yu kuai
@ 2019-11-04 13:27 ` yu kuai
2019-11-04 13:27 ` [PATCH 7/7] drm/amdgpu: remove set but not used variable 'mc_shared_chmap' yu kuai
6 siblings, 0 replies; 9+ messages in thread
From: yu kuai @ 2019-11-04 13:27 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, David1.Zhou, airlied,
daniel, Jammy.Zhou, tianci.yin, sam, luben.tuikov
Cc: amd-gfx, dri-devel, linux-kernel, yukuai3, zhengbin13, yi.zhang
Fixes gcc '-Wtype-limits' warning:
drivers/gpu/drm/amd/amdgpu/atombios_i2c.c: In function
‘amdgpu_atombios_i2c_process_i2c_ch’:
drivers/gpu/drm/amd/amdgpu/atombios_i2c.c:79:11: warning: comparison is
always false due to limited range of data type [-Wtype-limits]
'num' is 'u8', so it will never be greater than 'TOM_MAX_HW_I2C_READ',
which is defined as 255. Therefore, the comparison can be removed.
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c
index 980c363..b4cc7c5 100644
--- a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c
+++ b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c
@@ -76,11 +76,6 @@ static int amdgpu_atombios_i2c_process_i2c_ch(struct amdgpu_i2c_chan *chan,
}
args.lpI2CDataOut = cpu_to_le16(out);
} else {
- if (num > ATOM_MAX_HW_I2C_READ) {
- DRM_ERROR("hw i2c: tried to read too many bytes (%d vs 255)\n", num);
- r = -EINVAL;
- goto done;
- }
args.ucRegIndex = 0;
args.lpI2CDataOut = 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 7/7] drm/amdgpu: remove set but not used variable 'mc_shared_chmap'
2019-11-04 13:27 [PATCH 0/7] fix various gcc warnings yu kuai
` (5 preceding siblings ...)
2019-11-04 13:27 ` [PATCH 6/7] drm/amdgpu: remove always false comparison in 'amdgpu_atombios_i2c_process_i2c_ch' yu kuai
@ 2019-11-04 13:27 ` yu kuai
2019-11-06 17:15 ` Alex Deucher
6 siblings, 1 reply; 9+ messages in thread
From: yu kuai @ 2019-11-04 13:27 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, David1.Zhou, airlied,
daniel, Jammy.Zhou, tianci.yin, sam, luben.tuikov
Cc: amd-gfx, dri-devel, linux-kernel, yukuai3, zhengbin13, yi.zhang
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function
‘gfx_v8_0_gpu_early_init’:
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:1713:6: warning: variable
‘mc_shared_chmap’ set but not used [-Wunused-but-set-variable]
Fixes: 0bde3a95eaa9 ("drm/amdgpu: split gfx8 gpu init into sw and hw parts")
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index e4c645d..80b7958 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -1710,7 +1710,7 @@ static int gfx_v8_0_do_edc_gpr_workarounds(struct amdgpu_device *adev)
static int gfx_v8_0_gpu_early_init(struct amdgpu_device *adev)
{
u32 gb_addr_config;
- u32 mc_shared_chmap, mc_arb_ramcfg;
+ u32 mc_arb_ramcfg;
u32 dimm00_addr_map, dimm01_addr_map, dimm10_addr_map, dimm11_addr_map;
u32 tmp;
int ret;
@@ -1850,7 +1850,6 @@ static int gfx_v8_0_gpu_early_init(struct amdgpu_device *adev)
break;
}
- mc_shared_chmap = RREG32(mmMC_SHARED_CHMAP);
adev->gfx.config.mc_arb_ramcfg = RREG32(mmMC_ARB_RAMCFG);
mc_arb_ramcfg = adev->gfx.config.mc_arb_ramcfg;
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 7/7] drm/amdgpu: remove set but not used variable 'mc_shared_chmap'
2019-11-04 13:27 ` [PATCH 7/7] drm/amdgpu: remove set but not used variable 'mc_shared_chmap' yu kuai
@ 2019-11-06 17:15 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2019-11-06 17:15 UTC (permalink / raw)
To: yu kuai
Cc: Deucher, Alexander, Christian Koenig, Chunming Zhou, Dave Airlie,
Daniel Vetter, Zhou, Jammy, tiancyin, Sam Ravnborg, Tuikov,
Luben, yi.zhang, LKML, Maling list - DRI developers, zhengbin,
amd-gfx list
On Mon, Nov 4, 2019 at 8:54 AM yu kuai <yukuai3@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function
> ‘gfx_v8_0_gpu_early_init’:
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:1713:6: warning: variable
> ‘mc_shared_chmap’ set but not used [-Wunused-but-set-variable]
>
> Fixes: 0bde3a95eaa9 ("drm/amdgpu: split gfx8 gpu init into sw and hw parts")
> Signed-off-by: yu kuai <yukuai3@huawei.com>
Looks like gfx_v7_0.c and gfx_v6_0.c could have the same treatment.
Care to send patches?
Applied the series. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> index e4c645d..80b7958 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -1710,7 +1710,7 @@ static int gfx_v8_0_do_edc_gpr_workarounds(struct amdgpu_device *adev)
> static int gfx_v8_0_gpu_early_init(struct amdgpu_device *adev)
> {
> u32 gb_addr_config;
> - u32 mc_shared_chmap, mc_arb_ramcfg;
> + u32 mc_arb_ramcfg;
> u32 dimm00_addr_map, dimm01_addr_map, dimm10_addr_map, dimm11_addr_map;
> u32 tmp;
> int ret;
> @@ -1850,7 +1850,6 @@ static int gfx_v8_0_gpu_early_init(struct amdgpu_device *adev)
> break;
> }
>
> - mc_shared_chmap = RREG32(mmMC_SHARED_CHMAP);
> adev->gfx.config.mc_arb_ramcfg = RREG32(mmMC_ARB_RAMCFG);
> mc_arb_ramcfg = adev->gfx.config.mc_arb_ramcfg;
>
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-11-06 17:15 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 13:27 [PATCH 0/7] fix various gcc warnings yu kuai
2019-11-04 13:27 ` [PATCH 1/7] drm/amdgpu: remove 4 set but not used variable in amdgpu_atombios_get_connector_info_from_object_table yu kuai
2019-11-04 13:27 ` [PATCH 2/7] drm/amdgpu: add function parameter description in 'amdgpu_device_set_cg_state' yu kuai
2019-11-04 13:27 ` [PATCH 3/7] drm/amdgpu: add function parameter description in 'amdgpu_gart_bind' yu kuai
2019-11-04 13:27 ` [PATCH 4/7] drm/amdgpu: remove set but not used variable 'dig_connector' yu kuai
2019-11-04 13:27 ` [PATCH 5/7] drm/amdgpu: remove set but not used variable 'dig' yu kuai
2019-11-04 13:27 ` [PATCH 6/7] drm/amdgpu: remove always false comparison in 'amdgpu_atombios_i2c_process_i2c_ch' yu kuai
2019-11-04 13:27 ` [PATCH 7/7] drm/amdgpu: remove set but not used variable 'mc_shared_chmap' yu kuai
2019-11-06 17:15 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).