linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "tip-bot2 for Geert Uytterhoeven" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Rob Herring <robh@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
	linux-kernel@vger.kernel.org
Subject: [tip: timers/core] clocksource/drivers/timer-of: Use unique device name instead of timer
Date: Mon, 04 Nov 2019 17:54:14 -0000	[thread overview]
Message-ID: <157289005492.29376.132373533001357963.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20191016144747.29538-3-geert+renesas@glider.be>

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     4411464d6f8b5e5759637235a6f2b2a85c2be0f1
Gitweb:        https://git.kernel.org/tip/4411464d6f8b5e5759637235a6f2b2a85c2be0f1
Author:        Geert Uytterhoeven <geert+renesas@glider.be>
AuthorDate:    Wed, 16 Oct 2019 16:47:45 +02:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 04 Nov 2019 10:38:46 +01:00

clocksource/drivers/timer-of: Use unique device name instead of timer

If a hardware-specific driver does not provide a name, the timer-of core
falls back to device_node.name.  Due to generic DT node naming policies,
that name is almost always "timer", and thus doesn't identify the actual
timer used.

Fix this by using device_node.full_name instead, which includes the unit
addrees.

Example impact on /proc/timer_list:

    -Clock Event Device: timer
    +Clock Event Device: timer@fcfec400

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20191016144747.29538-3-geert+renesas@glider.be
---
 drivers/clocksource/timer-of.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-of.c b/drivers/clocksource/timer-of.c
index 3843942..8c11bd7 100644
--- a/drivers/clocksource/timer-of.c
+++ b/drivers/clocksource/timer-of.c
@@ -190,7 +190,7 @@ int __init timer_of_init(struct device_node *np, struct timer_of *to)
 	}
 
 	if (!to->clkevt.name)
-		to->clkevt.name = np->name;
+		to->clkevt.name = np->full_name;
 
 	to->np = np;
 

  parent reply	other threads:[~2019-11-04 17:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 14:47 [PATCH v4 0/4] clocksource/drivers/timer-of/renesas-ostm improvements Geert Uytterhoeven
2019-10-16 14:47 ` [PATCH v4 1/4] clocksource/drivers/timer-of: Convert last full_name to %pOF Geert Uytterhoeven
2019-11-04 17:54   ` [tip: timers/core] " tip-bot2 for Geert Uytterhoeven
2019-10-16 14:47 ` [PATCH v4 2/4] clocksource/drivers/timer-of: Use unique device name instead of timer Geert Uytterhoeven
2019-10-16 15:02   ` Rob Herring
2019-11-04 17:54   ` tip-bot2 for Geert Uytterhoeven [this message]
2019-10-16 14:47 ` [PATCH v4 3/4] clocksource/drivers/renesas-ostm: Convert to timer_of Geert Uytterhoeven
2019-11-04 17:54   ` [tip: timers/core] " tip-bot2 for Geert Uytterhoeven
2019-10-16 14:47 ` [PATCH v4 4/4] clocksource/drivers/renesas-ostm: Use unique device name instead of ostm Geert Uytterhoeven
2019-11-04 17:54   ` [tip: timers/core] " tip-bot2 for Geert Uytterhoeven
2019-10-16 15:03 ` [PATCH v4 0/4] clocksource/drivers/timer-of/renesas-ostm improvements Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157289005492.29376.132373533001357963.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=bp@alien8.de \
    --cc=daniel.lezcano@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).