* [PATCH] dpaa2-ptp: fix compile error
@ 2019-11-05 15:20 Chen Wandun
2019-11-06 18:24 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chen Wandun @ 2019-11-05 15:20 UTC (permalink / raw)
To: ruxandra.radulescu, davem, netdev, linux-kernel; +Cc: chenwandun
From: Chenwandun <chenwandun@huawei.com>
phylink_set_port_modes will be compiled if CONFIG_PHYLINK enabled,
dpaa2_mac_validate will be compiled if CONFIG_FSL_DPAA2_ETH enabled,
it should select CONFIG_PHYLINK when dpaa2_mac_validate call
phylink_set_port_modes
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.o: In function `dpaa2_mac_validate':
dpaa2-mac.c:(.text+0x3a1): undefined reference to `phylink_set_port_modes'
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.o: In function `dpaa2_mac_connect':
dpaa2-mac.c:(.text+0x91a): undefined reference to `phylink_create'
dpaa2-mac.c:(.text+0x94e): undefined reference to `phylink_of_phy_connect'
dpaa2-mac.c:(.text+0x97f): undefined reference to `phylink_destroy'
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.o: In function `dpaa2_mac_disconnect':
dpaa2-mac.c:(.text+0xa9f): undefined reference to `phylink_disconnect_phy'
dpaa2-mac.c:(.text+0xab0): undefined reference to `phylink_destroy'
make: *** [vmlinux] Error 1
---
drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig b/drivers/net/ethernet/freescale/dpaa2/Kconfig
index fbef282..c6fb8e4 100644
--- a/drivers/net/ethernet/freescale/dpaa2/Kconfig
+++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
@@ -2,6 +2,7 @@
config FSL_DPAA2_ETH
tristate "Freescale DPAA2 Ethernet"
depends on FSL_MC_BUS && FSL_MC_DPIO
+ select PHYLINK
help
This is the DPAA2 Ethernet driver supporting Freescale SoCs
with DPAA2 (DataPath Acceleration Architecture v2).
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dpaa2-ptp: fix compile error
2019-11-05 15:20 [PATCH] dpaa2-ptp: fix compile error Chen Wandun
@ 2019-11-06 18:24 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-06 18:24 UTC (permalink / raw)
To: chenwandun; +Cc: ruxandra.radulescu, netdev, linux-kernel
From: Chen Wandun <chenwandun@huawei.com>
Date: Tue, 5 Nov 2019 23:20:32 +0800
> From: Chenwandun <chenwandun@huawei.com>
>
> phylink_set_port_modes will be compiled if CONFIG_PHYLINK enabled,
> dpaa2_mac_validate will be compiled if CONFIG_FSL_DPAA2_ETH enabled,
> it should select CONFIG_PHYLINK when dpaa2_mac_validate call
> phylink_set_port_modes
>
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.o: In function `dpaa2_mac_validate':
> dpaa2-mac.c:(.text+0x3a1): undefined reference to `phylink_set_port_modes'
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.o: In function `dpaa2_mac_connect':
> dpaa2-mac.c:(.text+0x91a): undefined reference to `phylink_create'
> dpaa2-mac.c:(.text+0x94e): undefined reference to `phylink_of_phy_connect'
> dpaa2-mac.c:(.text+0x97f): undefined reference to `phylink_destroy'
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.o: In function `dpaa2_mac_disconnect':
> dpaa2-mac.c:(.text+0xa9f): undefined reference to `phylink_disconnect_phy'
> dpaa2-mac.c:(.text+0xab0): undefined reference to `phylink_destroy'
> make: *** [vmlinux] Error 1
You need to add a proper Signed-off-by: and Fixes: tag.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-06 18:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 15:20 [PATCH] dpaa2-ptp: fix compile error Chen Wandun
2019-11-06 18:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).