* [PATCH v4 0/2] ARM64: dts: allwinner: Add devicetree for pineH64 modelB @ 2019-11-09 16:20 Corentin Labbe 2019-11-09 16:20 ` [PATCH v4 1/2] ARM64: dts: sun50i-h6-pine-h64: state that the DT supports the modelA Corentin Labbe 2019-11-09 16:20 ` [PATCH v4 2/2] ARM64: dts: allwinner: add pineh64 model B Corentin Labbe 0 siblings, 2 replies; 7+ messages in thread From: Corentin Labbe @ 2019-11-09 16:20 UTC (permalink / raw) To: mark.rutland, mripard, robh+dt, wens, jernej.skrabec Cc: devicetree, linux-arm-kernel, linux-kernel, linux-sunxi, Corentin Labbe Hello Pineh64 have two existing model (A and B) with some hardware difference and so need two different DT file. But the current situation has only one file for both. This serie fix this situation by being more clear on which DT file is needed for both model. Regards Change since v3: - state the current file is model A and add a new modelB file. Change since v2: - Added the HDMI connector node to model A Changes since v1: - Added the first patch for stating which model support the sun50i-h6-pine-h64.dts Corentin Labbe (2): ARM64: dts: sun50i-h6-pine-h64: state that the DT supports the modelA ARM64: dts: allwinner: add pineh64 model B .../devicetree/bindings/arm/sunxi.yaml | 9 ++++++-- arch/arm64/boot/dts/allwinner/Makefile | 1 + .../allwinner/sun50i-h6-pine-h64-modelB.dts | 21 +++++++++++++++++++ .../boot/dts/allwinner/sun50i-h6-pine-h64.dts | 19 +++++++++++++---- 4 files changed, 44 insertions(+), 6 deletions(-) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts -- 2.23.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v4 1/2] ARM64: dts: sun50i-h6-pine-h64: state that the DT supports the modelA 2019-11-09 16:20 [PATCH v4 0/2] ARM64: dts: allwinner: Add devicetree for pineH64 modelB Corentin Labbe @ 2019-11-09 16:20 ` Corentin Labbe 2019-11-12 12:02 ` Maxime Ripard 2019-11-09 16:20 ` [PATCH v4 2/2] ARM64: dts: allwinner: add pineh64 model B Corentin Labbe 1 sibling, 1 reply; 7+ messages in thread From: Corentin Labbe @ 2019-11-09 16:20 UTC (permalink / raw) To: mark.rutland, mripard, robh+dt, wens, jernej.skrabec Cc: devicetree, linux-arm-kernel, linux-kernel, linux-sunxi, Corentin Labbe The current sun50i-h6-pine-h64 DT does not specify which model (A or B) it supports. When this file was created, only modelA was existing, but now both model exists and with the time, this DT drifted to support the model B since it is the most common one. Furtheremore, some part of the model A does not work with it like ethernet and HDMI connector (as confirmed by Jernej on IRC). So it is time to settle the issue, and the easiest way was to state that this DT is for model B. Easiest since only a small name changes is required. Doing the opposite (stating this file is for model A) will add changes (for ethernet and HDMI) and so, will break too many setup. But as asked by the maintainer this patch state this file is for model A. In the process this patch adds the missing compoments to made it work on model A. Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- .../devicetree/bindings/arm/sunxi.yaml | 4 ++-- .../boot/dts/allwinner/sun50i-h6-pine-h64.dts | 19 +++++++++++++++---- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml index 8a1e38a1d7ab..b8ec616c2538 100644 --- a/Documentation/devicetree/bindings/arm/sunxi.yaml +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml @@ -599,9 +599,9 @@ properties: - const: pine64,pine64-plus - const: allwinner,sun50i-a64 - - description: Pine64 PineH64 + - description: Pine64 PineH64 model A items: - - const: pine64,pine-h64 + - const: pine64,pine-h64-modelA - const: allwinner,sun50i-h6 - description: Pine64 LTS diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts index 74899ede00fb..1d9afde4d3d7 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts @@ -10,8 +10,8 @@ #include <dt-bindings/gpio/gpio.h> / { - model = "Pine H64"; - compatible = "pine64,pine-h64", "allwinner,sun50i-h6"; + model = "Pine H64 model A"; + compatible = "pine64,pine-h64-modelA", "allwinner,sun50i-h6"; aliases { ethernet0 = &emac; @@ -22,9 +22,10 @@ stdout-path = "serial0:115200n8"; }; - connector { + hdmi_connector: connector { compatible = "hdmi-connector"; type = "a"; + ddc-en-gpios = <&pio 7 2 GPIO_ACTIVE_HIGH>; /* PH2 */ port { hdmi_con_in: endpoint { @@ -52,6 +53,16 @@ }; }; + reg_gmac_3v3: gmac-3v3 { + compatible = "regulator-fixed"; + regulator-name = "vcc-gmac-3v3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + startup-delay-us = <100000>; + gpio = <&pio 2 16 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + reg_usb_vbus: vbus { compatible = "regulator-fixed"; regulator-name = "usb-vbus"; @@ -68,7 +79,7 @@ pinctrl-0 = <&ext_rgmii_pins>; phy-mode = "rgmii"; phy-handle = <&ext_rgmii_phy>; - phy-supply = <®_aldo2>; + phy-supply = <®_gmac_3v3>; allwinner,rx-delay-ps = <200>; allwinner,tx-delay-ps = <200>; status = "okay"; -- 2.23.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v4 1/2] ARM64: dts: sun50i-h6-pine-h64: state that the DT supports the modelA 2019-11-09 16:20 ` [PATCH v4 1/2] ARM64: dts: sun50i-h6-pine-h64: state that the DT supports the modelA Corentin Labbe @ 2019-11-12 12:02 ` Maxime Ripard 2019-11-12 12:51 ` LABBE Corentin 0 siblings, 1 reply; 7+ messages in thread From: Maxime Ripard @ 2019-11-12 12:02 UTC (permalink / raw) To: Corentin Labbe Cc: mark.rutland, robh+dt, wens, jernej.skrabec, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 2751 bytes --] Hi, On Sat, Nov 09, 2019 at 04:20:32PM +0000, Corentin Labbe wrote: > The current sun50i-h6-pine-h64 DT does not specify which model (A or B) > it supports. > When this file was created, only modelA was existing, but now both model > exists and with the time, this DT drifted to support the model B since it is > the most common one. > Furtheremore, some part of the model A does not work with it like ethernet and > HDMI connector (as confirmed by Jernej on IRC). > > So it is time to settle the issue, and the easiest way was to state that > this DT is for model B. > Easiest since only a small name changes is required. > Doing the opposite (stating this file is for model A) will add changes (for > ethernet and HDMI) and so, will break too many setup. > > But as asked by the maintainer this patch state this file is for model A. > In the process this patch adds the missing compoments to made it work on > model A. > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > .../devicetree/bindings/arm/sunxi.yaml | 4 ++-- > .../boot/dts/allwinner/sun50i-h6-pine-h64.dts | 19 +++++++++++++++---- > 2 files changed, 17 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > index 8a1e38a1d7ab..b8ec616c2538 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > @@ -599,9 +599,9 @@ properties: > - const: pine64,pine64-plus > - const: allwinner,sun50i-a64 > > - - description: Pine64 PineH64 > + - description: Pine64 PineH64 model A > items: > - - const: pine64,pine-h64 > + - const: pine64,pine-h64-modelA You can change the description to make it more obvious if you want to, but changing the compatible is a no-go. > - const: allwinner,sun50i-h6 > > - description: Pine64 LTS > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > index 74899ede00fb..1d9afde4d3d7 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > @@ -10,8 +10,8 @@ > #include <dt-bindings/gpio/gpio.h> > > / { > - model = "Pine H64"; > - compatible = "pine64,pine-h64", "allwinner,sun50i-h6"; > + model = "Pine H64 model A"; > + compatible = "pine64,pine-h64-modelA", "allwinner,sun50i-h6"; Same thing here, changing the model is fine, the compatible isn't > aliases { > ethernet0 = &emac; > @@ -22,9 +22,10 @@ > stdout-path = "serial0:115200n8"; > }; > > - connector { > + hdmi_connector: connector { Why do you need to add the label? Thanks! Maxime [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 1/2] ARM64: dts: sun50i-h6-pine-h64: state that the DT supports the modelA 2019-11-12 12:02 ` Maxime Ripard @ 2019-11-12 12:51 ` LABBE Corentin 0 siblings, 0 replies; 7+ messages in thread From: LABBE Corentin @ 2019-11-12 12:51 UTC (permalink / raw) To: Maxime Ripard Cc: mark.rutland, robh+dt, wens, jernej.skrabec, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Tue, Nov 12, 2019 at 01:02:19PM +0100, Maxime Ripard wrote: > Hi, > > On Sat, Nov 09, 2019 at 04:20:32PM +0000, Corentin Labbe wrote: > > The current sun50i-h6-pine-h64 DT does not specify which model (A or B) > > it supports. > > When this file was created, only modelA was existing, but now both model > > exists and with the time, this DT drifted to support the model B since it is > > the most common one. > > Furtheremore, some part of the model A does not work with it like ethernet and > > HDMI connector (as confirmed by Jernej on IRC). > > > > So it is time to settle the issue, and the easiest way was to state that > > this DT is for model B. > > Easiest since only a small name changes is required. > > Doing the opposite (stating this file is for model A) will add changes (for > > ethernet and HDMI) and so, will break too many setup. > > > > But as asked by the maintainer this patch state this file is for model A. > > In the process this patch adds the missing compoments to made it work on > > model A. > > > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > > --- > > .../devicetree/bindings/arm/sunxi.yaml | 4 ++-- > > .../boot/dts/allwinner/sun50i-h6-pine-h64.dts | 19 +++++++++++++++---- > > 2 files changed, 17 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > > index 8a1e38a1d7ab..b8ec616c2538 100644 > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > > @@ -599,9 +599,9 @@ properties: > > - const: pine64,pine64-plus > > - const: allwinner,sun50i-a64 > > > > - - description: Pine64 PineH64 > > + - description: Pine64 PineH64 model A > > items: > > - - const: pine64,pine-h64 > > + - const: pine64,pine-h64-modelA > > You can change the description to make it more obvious if you want to, > but changing the compatible is a no-go. > > > - const: allwinner,sun50i-h6 > > > > - description: Pine64 LTS > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > > index 74899ede00fb..1d9afde4d3d7 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > > @@ -10,8 +10,8 @@ > > #include <dt-bindings/gpio/gpio.h> > > > > / { > > - model = "Pine H64"; > > - compatible = "pine64,pine-h64", "allwinner,sun50i-h6"; > > + model = "Pine H64 model A"; > > + compatible = "pine64,pine-h64-modelA", "allwinner,sun50i-h6"; > > Same thing here, changing the model is fine, the compatible isn't > Hello I will erase compatible changes in next version. > > aliases { > > ethernet0 = &emac; > > @@ -22,9 +22,10 @@ > > stdout-path = "serial0:115200n8"; > > }; > > > > - connector { > > + hdmi_connector: connector { > > Why do you need to add the label? > For dropping the ddc-en-gpios property in model B. If you want, I can split this line change in an extra patch. Regards ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v4 2/2] ARM64: dts: allwinner: add pineh64 model B 2019-11-09 16:20 [PATCH v4 0/2] ARM64: dts: allwinner: Add devicetree for pineH64 modelB Corentin Labbe 2019-11-09 16:20 ` [PATCH v4 1/2] ARM64: dts: sun50i-h6-pine-h64: state that the DT supports the modelA Corentin Labbe @ 2019-11-09 16:20 ` Corentin Labbe 2019-11-12 12:04 ` Maxime Ripard 1 sibling, 1 reply; 7+ messages in thread From: Corentin Labbe @ 2019-11-09 16:20 UTC (permalink / raw) To: mark.rutland, mripard, robh+dt, wens, jernej.skrabec Cc: devicetree, linux-arm-kernel, linux-kernel, linux-sunxi, Corentin Labbe This patch adds the model B of the PineH64. The model B is smaller than the pine64 model A and has no PCIE slot. The only devicetree difference with the pineH64 model A, is the PHY regulator and the HDMI connector node. Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- .../devicetree/bindings/arm/sunxi.yaml | 5 +++++ arch/arm64/boot/dts/allwinner/Makefile | 1 + .../allwinner/sun50i-h6-pine-h64-modelB.dts | 21 +++++++++++++++++++ 3 files changed, 27 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml index b8ec616c2538..227217bf28df 100644 --- a/Documentation/devicetree/bindings/arm/sunxi.yaml +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml @@ -604,6 +604,11 @@ properties: - const: pine64,pine-h64-modelA - const: allwinner,sun50i-h6 + - description: Pine64 PineH64 model B + items: + - const: pine64,pine-h64-modelB + - const: allwinner,sun50i-h6 + - description: Pine64 LTS items: - const: pine64,pine64-lts diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile index d2418021768b..bda89b9ccb4a 100644 --- a/arch/arm64/boot/dts/allwinner/Makefile +++ b/arch/arm64/boot/dts/allwinner/Makefile @@ -26,4 +26,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-3.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-modelB.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts new file mode 100644 index 000000000000..063a85223faa --- /dev/null +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts @@ -0,0 +1,21 @@ +// SPDX-License-Identifier: (GPL-2.0+ or MIT) +/* + * Copyright (C) 2019 Corentin LABBE <clabbe@baylibre.com> + */ + +#include "sun50i-h6-pine-h64.dts" + +/ { + model = "Pine H64 model B"; + compatible = "pine64,pine-h64-modelB", "allwinner,sun50i-h6"; + + /delete-node/ reg_gmac_3v3; +}; + +&hdmi_connector { + /delete-property/ ddc-en-gpios; +}; + +&emac { + phy-supply = <®_aldo2>; +}; -- 2.23.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v4 2/2] ARM64: dts: allwinner: add pineh64 model B 2019-11-09 16:20 ` [PATCH v4 2/2] ARM64: dts: allwinner: add pineh64 model B Corentin Labbe @ 2019-11-12 12:04 ` Maxime Ripard 2019-11-12 12:53 ` LABBE Corentin 0 siblings, 1 reply; 7+ messages in thread From: Maxime Ripard @ 2019-11-12 12:04 UTC (permalink / raw) To: Corentin Labbe Cc: mark.rutland, robh+dt, wens, jernej.skrabec, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 2560 bytes --] On Sat, Nov 09, 2019 at 04:20:33PM +0000, Corentin Labbe wrote: > This patch adds the model B of the PineH64. > The model B is smaller than the pine64 model A and has no PCIE slot. > > The only devicetree difference with the pineH64 model A, is the PHY > regulator and the HDMI connector node. > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > .../devicetree/bindings/arm/sunxi.yaml | 5 +++++ > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../allwinner/sun50i-h6-pine-h64-modelB.dts | 21 +++++++++++++++++++ > 3 files changed, 27 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > index b8ec616c2538..227217bf28df 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > @@ -604,6 +604,11 @@ properties: > - const: pine64,pine-h64-modelA > - const: allwinner,sun50i-h6 > > + - description: Pine64 PineH64 model B > + items: > + - const: pine64,pine-h64-modelB > + - const: allwinner,sun50i-h6 > + > - description: Pine64 LTS > items: > - const: pine64,pine64-lts > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > index d2418021768b..bda89b9ccb4a 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -26,4 +26,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-3.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-modelB.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts > new file mode 100644 > index 000000000000..063a85223faa > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > +/* > + * Copyright (C) 2019 Corentin LABBE <clabbe@baylibre.com> > + */ > + > +#include "sun50i-h6-pine-h64.dts" > + > +/ { > + model = "Pine H64 model B"; > + compatible = "pine64,pine-h64-modelB", "allwinner,sun50i-h6"; compatibles are usually lowercase, what about pine64,pine-h64-model-b? Maxime [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 2/2] ARM64: dts: allwinner: add pineh64 model B 2019-11-12 12:04 ` Maxime Ripard @ 2019-11-12 12:53 ` LABBE Corentin 0 siblings, 0 replies; 7+ messages in thread From: LABBE Corentin @ 2019-11-12 12:53 UTC (permalink / raw) To: Maxime Ripard Cc: mark.rutland, robh+dt, wens, jernej.skrabec, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Tue, Nov 12, 2019 at 01:04:55PM +0100, Maxime Ripard wrote: > On Sat, Nov 09, 2019 at 04:20:33PM +0000, Corentin Labbe wrote: > > This patch adds the model B of the PineH64. > > The model B is smaller than the pine64 model A and has no PCIE slot. > > > > The only devicetree difference with the pineH64 model A, is the PHY > > regulator and the HDMI connector node. > > > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > > --- > > .../devicetree/bindings/arm/sunxi.yaml | 5 +++++ > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > > .../allwinner/sun50i-h6-pine-h64-modelB.dts | 21 +++++++++++++++++++ > > 3 files changed, 27 insertions(+) > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts > > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > > index b8ec616c2538..227217bf28df 100644 > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > > @@ -604,6 +604,11 @@ properties: > > - const: pine64,pine-h64-modelA > > - const: allwinner,sun50i-h6 > > > > + - description: Pine64 PineH64 model B > > + items: > > + - const: pine64,pine-h64-modelB > > + - const: allwinner,sun50i-h6 > > + > > - description: Pine64 LTS > > items: > > - const: pine64,pine64-lts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > > index d2418021768b..bda89b9ccb4a 100644 > > --- a/arch/arm64/boot/dts/allwinner/Makefile > > +++ b/arch/arm64/boot/dts/allwinner/Makefile > > @@ -26,4 +26,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-3.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb > > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-modelB.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts > > new file mode 100644 > > index 000000000000..063a85223faa > > --- /dev/null > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts > > @@ -0,0 +1,21 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > > +/* > > + * Copyright (C) 2019 Corentin LABBE <clabbe@baylibre.com> > > + */ > > + > > +#include "sun50i-h6-pine-h64.dts" > > + > > +/ { > > + model = "Pine H64 model B"; > > + compatible = "pine64,pine-h64-modelB", "allwinner,sun50i-h6"; > > compatibles are usually lowercase, what about pine64,pine-h64-model-b? > Perfect, I will use it. Regards ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-11-12 12:53 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-09 16:20 [PATCH v4 0/2] ARM64: dts: allwinner: Add devicetree for pineH64 modelB Corentin Labbe 2019-11-09 16:20 ` [PATCH v4 1/2] ARM64: dts: sun50i-h6-pine-h64: state that the DT supports the modelA Corentin Labbe 2019-11-12 12:02 ` Maxime Ripard 2019-11-12 12:51 ` LABBE Corentin 2019-11-09 16:20 ` [PATCH v4 2/2] ARM64: dts: allwinner: add pineh64 model B Corentin Labbe 2019-11-12 12:04 ` Maxime Ripard 2019-11-12 12:53 ` LABBE Corentin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).