[GIT PULL] IIO fixes / Staging driver for 5.4-rc7

[GIT PULL] IIO fixes / Staging driver for 5.4-rc7

[Greg KH]

The following changes since commit d6d5df1db6e9d7f8f76d2911707f7d5877251b02:

  Linux 5.4-rc5 (2019-10-27 13:19:19 -0400)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.4-rc7

for you to fetch changes up to e39fcaef7ed993950af74a584f8246022b551971:

  staging: Fix error return code in vboxsf_fill_super() (2019-11-07 16:29:18 +0100)

----------------------------------------------------------------
IIO fixes / Staging driver for 5.4-rc7

Here is a mix of a number of IIO driver fixes for 5.4-rc7, and a whole
new staging driver.

The IIO fixes resolve some reported issues, all are tiny.

The staging driver addition is the vboxsf filesystem, which is the
VirtualBox guest shared folder code.  Hans has been trying to get
filesystem reviewers to review the code for many months now, and
Christoph finally said to just merge it in staging now as it is
stand-alone and the filesystem people can review it easier over time
that way.
I know it's late for this big of an addition, but it is stand-alone.

The code has been in linux-next for a while, long enough to pick up a
few tiny fixes for it already so people are looking at it.

All of these have been in linux-next with no reported issues.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

----------------------------------------------------------------
Alexandru Ardelean (1):
      iio: imu: adis16480: make sure provided frequency is positive

Andreas Klinger (1):
      iio: srf04: fix wrong limitation in distance measuring

Colin Ian King (1):
      staging: vboxsf: fix dereference of pointer dentry before it is null checked

Fabrice Gasnier (1):
      iio: adc: stm32-adc: fix stopping dma

Greg Kroah-Hartman (1):
      Merge tag 'iio-fixes-for-5.4b' of https://git.kernel.org/.../jic23/iio into staging-linus

Hans de Goede (1):
      staging: Add VirtualBox guest shared folder (vboxsf) support

Jean-Baptiste Maneyrol (1):
      iio: imu: inv_mpu6050: fix no data on MPU6050

Wei Yongjun (1):
      staging: Fix error return code in vboxsf_fill_super()

YueHaibing (1):
      staging: vboxsf: Remove unused including <linux/version.h>

 MAINTAINERS                                |   6 +
 drivers/iio/adc/stm32-adc.c                |   4 +-
 drivers/iio/imu/adis16480.c                |   5 +-
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c |   9 +
 drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h  |   2 +
 drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c |  15 +-
 drivers/iio/proximity/srf04.c              |  29 +-
 drivers/staging/Kconfig                    |   2 +
 drivers/staging/Makefile                   |   1 +
 drivers/staging/vboxsf/Kconfig             |  10 +
 drivers/staging/vboxsf/Makefile            |   5 +
 drivers/staging/vboxsf/TODO                |   7 +
 drivers/staging/vboxsf/dir.c               | 418 +++++++++++++
 drivers/staging/vboxsf/file.c              | 370 ++++++++++++
 drivers/staging/vboxsf/shfl_hostintf.h     | 901 +++++++++++++++++++++++++++++
 drivers/staging/vboxsf/super.c             | 501 ++++++++++++++++
 drivers/staging/vboxsf/utils.c             | 551 ++++++++++++++++++
 drivers/staging/vboxsf/vboxsf_wrappers.c   | 371 ++++++++++++
 drivers/staging/vboxsf/vfsmod.h            | 137 +++++
 19 files changed, 3324 insertions(+), 20 deletions(-)
 create mode 100644 drivers/staging/vboxsf/Kconfig
 create mode 100644 drivers/staging/vboxsf/Makefile
 create mode 100644 drivers/staging/vboxsf/TODO
 create mode 100644 drivers/staging/vboxsf/dir.c
 create mode 100644 drivers/staging/vboxsf/file.c
 create mode 100644 drivers/staging/vboxsf/shfl_hostintf.h
 create mode 100644 drivers/staging/vboxsf/super.c
 create mode 100644 drivers/staging/vboxsf/utils.c
 create mode 100644 drivers/staging/vboxsf/vboxsf_wrappers.c
 create mode 100644 drivers/staging/vboxsf/vfsmod.h

Re: [GIT PULL] IIO fixes / Staging driver for 5.4-rc7

[pr-tracker-bot]

The pull request you sent on Sun, 10 Nov 2019 16:43:03 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.4-rc7

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/dd892625d0e252d967387d0a2af6dd6a864b3fdf

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

Re: [GIT PULL] IIO fixes / Staging driver for 5.4-rc7

[Christoph Hellwig]

On Sun, Nov 10, 2019 at 04:43:03PM +0100, Greg KH wrote:
> The staging driver addition is the vboxsf filesystem, which is the
> VirtualBox guest shared folder code.  Hans has been trying to get
> filesystem reviewers to review the code for many months now, and
> Christoph finally said to just merge it in staging now as it is
> stand-alone and the filesystem people can review it easier over time
> that way.

No, this is absolutely contrary to what I said.  I told Hans to just
send it to Linus because it is ready and not staging fodder a atll.

Re: [GIT PULL] IIO fixes / Staging driver for 5.4-rc7

[Greg KH]

On Mon, Nov 11, 2019 at 10:34:40PM -0800, Christoph Hellwig wrote:
> On Sun, Nov 10, 2019 at 04:43:03PM +0100, Greg KH wrote:
> > The staging driver addition is the vboxsf filesystem, which is the
> > VirtualBox guest shared folder code.  Hans has been trying to get
> > filesystem reviewers to review the code for many months now, and
> > Christoph finally said to just merge it in staging now as it is
> > stand-alone and the filesystem people can review it easier over time
> > that way.
> 
> No, this is absolutely contrary to what I said.  I told Hans to just
> send it to Linus because it is ready and not staging fodder a atll.

Hah, ok, I got that totally wrong.  I'll send a patch moving it to the
"real" part of the kernel now.

thanks,

greg k-h

[PATCH] vboxsf: move out of staging to fs/

[Greg Kroah-Hartman]

When Christoph said this code was "good enough to go in now" I thought
he ment to put it in drivers/staging/ for now, when in fact he ment to
put it into the "real" part of the kernel instead.

So move the code to the "real" part of the kernel as it's good enough.

Reported-by: Christoph Hellwig <hch@infradead.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

Christoph, this is what you mean, right?  If so, I'll send this to Linus
later this week, or he can grab it right from this patch :)

thanks,

greg k-h

 MAINTAINERS                                      | 2 +-
 drivers/staging/Kconfig                          | 2 --
 drivers/staging/Makefile                         | 1 -
 fs/Kconfig                                       | 1 +
 fs/Makefile                                      | 1 +
 {drivers/staging => fs}/vboxsf/Kconfig           | 0
 {drivers/staging => fs}/vboxsf/Makefile          | 0
 {drivers/staging => fs}/vboxsf/TODO              | 0
 {drivers/staging => fs}/vboxsf/dir.c             | 0
 {drivers/staging => fs}/vboxsf/file.c            | 0
 {drivers/staging => fs}/vboxsf/shfl_hostintf.h   | 0
 {drivers/staging => fs}/vboxsf/super.c           | 0
 {drivers/staging => fs}/vboxsf/utils.c           | 0
 {drivers/staging => fs}/vboxsf/vboxsf_wrappers.c | 0
 {drivers/staging => fs}/vboxsf/vfsmod.h          | 0
 15 files changed, 3 insertions(+), 4 deletions(-)
 rename {drivers/staging => fs}/vboxsf/Kconfig (100%)
 rename {drivers/staging => fs}/vboxsf/Makefile (100%)
 rename {drivers/staging => fs}/vboxsf/TODO (100%)
 rename {drivers/staging => fs}/vboxsf/dir.c (100%)
 rename {drivers/staging => fs}/vboxsf/file.c (100%)
 rename {drivers/staging => fs}/vboxsf/shfl_hostintf.h (100%)
 rename {drivers/staging => fs}/vboxsf/super.c (100%)
 rename {drivers/staging => fs}/vboxsf/utils.c (100%)
 rename {drivers/staging => fs}/vboxsf/vboxsf_wrappers.c (100%)
 rename {drivers/staging => fs}/vboxsf/vfsmod.h (100%)

diff --git a/MAINTAINERS b/MAINTAINERS
index eb19fad370d7..069dc018073d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17342,7 +17342,7 @@ VIRTUAL BOX SHARED FOLDER VFS DRIVER:
 M:	Hans de Goede <hdegoede@redhat.com>
 L:	linux-fsdevel@vger.kernel.org
 S:	Maintained
-F:	drivers/staging/vboxsf/*
+F:	fs/vboxsf/*
 
 VIRTUAL SERIO DEVICE DRIVER
 M:	Stephen Chandler Paul <thatslyude@gmail.com>
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index 927d29eb92c6..6f1fa4c849a1 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -125,6 +125,4 @@ source "drivers/staging/exfat/Kconfig"
 
 source "drivers/staging/qlge/Kconfig"
 
-source "drivers/staging/vboxsf/Kconfig"
-
 endif # STAGING
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index f01f04199073..a90f9b308c8d 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -53,4 +53,3 @@ obj-$(CONFIG_UWB)		+= uwb/
 obj-$(CONFIG_USB_WUSB)		+= wusbcore/
 obj-$(CONFIG_EXFAT_FS)		+= exfat/
 obj-$(CONFIG_QLGE)		+= qlge/
-obj-$(CONFIG_VBOXSF_FS)		+= vboxsf/
diff --git a/fs/Kconfig b/fs/Kconfig
index 2501e6f1f965..a6b57d790100 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -321,5 +321,6 @@ endif # NETWORK_FILESYSTEMS
 source "fs/nls/Kconfig"
 source "fs/dlm/Kconfig"
 source "fs/unicode/Kconfig"
+source "fs/vboxsf/Kconfig"
 
 endmenu
diff --git a/fs/Makefile b/fs/Makefile
index 14231b4cf383..aecbb088be47 100644
--- a/fs/Makefile
+++ b/fs/Makefile
@@ -132,3 +132,4 @@ obj-$(CONFIG_CEPH_FS)		+= ceph/
 obj-$(CONFIG_PSTORE)		+= pstore/
 obj-$(CONFIG_EFIVAR_FS)		+= efivarfs/
 obj-$(CONFIG_EROFS_FS)		+= erofs/
+obj-$(CONFIG_VBOXSF_FS)		+= vboxsf/
diff --git a/drivers/staging/vboxsf/Kconfig b/fs/vboxsf/Kconfig
similarity index 100%
rename from drivers/staging/vboxsf/Kconfig
rename to fs/vboxsf/Kconfig
diff --git a/drivers/staging/vboxsf/Makefile b/fs/vboxsf/Makefile
similarity index 100%
rename from drivers/staging/vboxsf/Makefile
rename to fs/vboxsf/Makefile
diff --git a/drivers/staging/vboxsf/TODO b/fs/vboxsf/TODO
similarity index 100%
rename from drivers/staging/vboxsf/TODO
rename to fs/vboxsf/TODO
diff --git a/drivers/staging/vboxsf/dir.c b/fs/vboxsf/dir.c
similarity index 100%
rename from drivers/staging/vboxsf/dir.c
rename to fs/vboxsf/dir.c
diff --git a/drivers/staging/vboxsf/file.c b/fs/vboxsf/file.c
similarity index 100%
rename from drivers/staging/vboxsf/file.c
rename to fs/vboxsf/file.c
diff --git a/drivers/staging/vboxsf/shfl_hostintf.h b/fs/vboxsf/shfl_hostintf.h
similarity index 100%
rename from drivers/staging/vboxsf/shfl_hostintf.h
rename to fs/vboxsf/shfl_hostintf.h
diff --git a/drivers/staging/vboxsf/super.c b/fs/vboxsf/super.c
similarity index 100%
rename from drivers/staging/vboxsf/super.c
rename to fs/vboxsf/super.c
diff --git a/drivers/staging/vboxsf/utils.c b/fs/vboxsf/utils.c
similarity index 100%
rename from drivers/staging/vboxsf/utils.c
rename to fs/vboxsf/utils.c
diff --git a/drivers/staging/vboxsf/vboxsf_wrappers.c b/fs/vboxsf/vboxsf_wrappers.c
similarity index 100%
rename from drivers/staging/vboxsf/vboxsf_wrappers.c
rename to fs/vboxsf/vboxsf_wrappers.c
diff --git a/drivers/staging/vboxsf/vfsmod.h b/fs/vboxsf/vfsmod.h
similarity index 100%
rename from drivers/staging/vboxsf/vfsmod.h
rename to fs/vboxsf/vfsmod.h
-- 
2.24.0

[PATCH] vboxsf: move out of staging to fs/

[Greg Kroah-Hartman]

When Christoph said this code was "good enough to go in now" I thought
he ment to put it in drivers/staging/ for now, when in fact he ment to
put it into the "real" part of the kernel instead.

So move the code to the "real" part of the kernel as it's good enough.

Reported-by: Christoph Hellwig <hch@infradead.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

Christoph, this is what you mean, right?  If so, I'll send this to Linus
later this week, or he can grab it right from this patch :)

thanks,

greg k-h

 MAINTAINERS                                      | 2 +-
 drivers/staging/Kconfig                          | 2 --
 drivers/staging/Makefile                         | 1 -
 fs/Kconfig                                       | 1 +
 fs/Makefile                                      | 1 +
 {drivers/staging => fs}/vboxsf/Kconfig           | 0
 {drivers/staging => fs}/vboxsf/Makefile          | 0
 {drivers/staging => fs}/vboxsf/TODO              | 0
 {drivers/staging => fs}/vboxsf/dir.c             | 0
 {drivers/staging => fs}/vboxsf/file.c            | 0
 {drivers/staging => fs}/vboxsf/shfl_hostintf.h   | 0
 {drivers/staging => fs}/vboxsf/super.c           | 0
 {drivers/staging => fs}/vboxsf/utils.c           | 0
 {drivers/staging => fs}/vboxsf/vboxsf_wrappers.c | 0
 {drivers/staging => fs}/vboxsf/vfsmod.h          | 0
 15 files changed, 3 insertions(+), 4 deletions(-)
 rename {drivers/staging => fs}/vboxsf/Kconfig (100%)
 rename {drivers/staging => fs}/vboxsf/Makefile (100%)
 rename {drivers/staging => fs}/vboxsf/TODO (100%)
 rename {drivers/staging => fs}/vboxsf/dir.c (100%)
 rename {drivers/staging => fs}/vboxsf/file.c (100%)
 rename {drivers/staging => fs}/vboxsf/shfl_hostintf.h (100%)
 rename {drivers/staging => fs}/vboxsf/super.c (100%)
 rename {drivers/staging => fs}/vboxsf/utils.c (100%)
 rename {drivers/staging => fs}/vboxsf/vboxsf_wrappers.c (100%)
 rename {drivers/staging => fs}/vboxsf/vfsmod.h (100%)

diff --git a/MAINTAINERS b/MAINTAINERS
index eb19fad370d7..069dc018073d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17342,7 +17342,7 @@ VIRTUAL BOX SHARED FOLDER VFS DRIVER:
 M:	Hans de Goede <hdegoede@redhat.com>
 L:	linux-fsdevel@vger.kernel.org
 S:	Maintained
-F:	drivers/staging/vboxsf/*
+F:	fs/vboxsf/*
 
 VIRTUAL SERIO DEVICE DRIVER
 M:	Stephen Chandler Paul <thatslyude@gmail.com>
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index 927d29eb92c6..6f1fa4c849a1 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -125,6 +125,4 @@ source "drivers/staging/exfat/Kconfig"
 
 source "drivers/staging/qlge/Kconfig"
 
-source "drivers/staging/vboxsf/Kconfig"
-
 endif # STAGING
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index f01f04199073..a90f9b308c8d 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -53,4 +53,3 @@ obj-$(CONFIG_UWB)		+= uwb/
 obj-$(CONFIG_USB_WUSB)		+= wusbcore/
 obj-$(CONFIG_EXFAT_FS)		+= exfat/
 obj-$(CONFIG_QLGE)		+= qlge/
-obj-$(CONFIG_VBOXSF_FS)		+= vboxsf/
diff --git a/fs/Kconfig b/fs/Kconfig
index 2501e6f1f965..a6b57d790100 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -321,5 +321,6 @@ endif # NETWORK_FILESYSTEMS
 source "fs/nls/Kconfig"
 source "fs/dlm/Kconfig"
 source "fs/unicode/Kconfig"
+source "fs/vboxsf/Kconfig"
 
 endmenu
diff --git a/fs/Makefile b/fs/Makefile
index 14231b4cf383..aecbb088be47 100644
--- a/fs/Makefile
+++ b/fs/Makefile
@@ -132,3 +132,4 @@ obj-$(CONFIG_CEPH_FS)		+= ceph/
 obj-$(CONFIG_PSTORE)		+= pstore/
 obj-$(CONFIG_EFIVAR_FS)		+= efivarfs/
 obj-$(CONFIG_EROFS_FS)		+= erofs/
+obj-$(CONFIG_VBOXSF_FS)		+= vboxsf/
diff --git a/drivers/staging/vboxsf/Kconfig b/fs/vboxsf/Kconfig
similarity index 100%
rename from drivers/staging/vboxsf/Kconfig
rename to fs/vboxsf/Kconfig
diff --git a/drivers/staging/vboxsf/Makefile b/fs/vboxsf/Makefile
similarity index 100%
rename from drivers/staging/vboxsf/Makefile
rename to fs/vboxsf/Makefile
diff --git a/drivers/staging/vboxsf/TODO b/fs/vboxsf/TODO
similarity index 100%
rename from drivers/staging/vboxsf/TODO
rename to fs/vboxsf/TODO
diff --git a/drivers/staging/vboxsf/dir.c b/fs/vboxsf/dir.c
similarity index 100%
rename from drivers/staging/vboxsf/dir.c
rename to fs/vboxsf/dir.c
diff --git a/drivers/staging/vboxsf/file.c b/fs/vboxsf/file.c
similarity index 100%
rename from drivers/staging/vboxsf/file.c
rename to fs/vboxsf/file.c
diff --git a/drivers/staging/vboxsf/shfl_hostintf.h b/fs/vboxsf/shfl_hostintf.h
similarity index 100%
rename from drivers/staging/vboxsf/shfl_hostintf.h
rename to fs/vboxsf/shfl_hostintf.h
diff --git a/drivers/staging/vboxsf/super.c b/fs/vboxsf/super.c
similarity index 100%
rename from drivers/staging/vboxsf/super.c
rename to fs/vboxsf/super.c
diff --git a/drivers/staging/vboxsf/utils.c b/fs/vboxsf/utils.c
similarity index 100%
rename from drivers/staging/vboxsf/utils.c
rename to fs/vboxsf/utils.c
diff --git a/drivers/staging/vboxsf/vboxsf_wrappers.c b/fs/vboxsf/vboxsf_wrappers.c
similarity index 100%
rename from drivers/staging/vboxsf/vboxsf_wrappers.c
rename to fs/vboxsf/vboxsf_wrappers.c
diff --git a/drivers/staging/vboxsf/vfsmod.h b/fs/vboxsf/vfsmod.h
similarity index 100%
rename from drivers/staging/vboxsf/vfsmod.h
rename to fs/vboxsf/vfsmod.h
-- 
2.24.0

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] vboxsf: move out of staging to fs/

[Linus Torvalds]

On Tue, Nov 12, 2019 at 2:54 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> Christoph, this is what you mean, right?  If so, I'll send this to Linus
> later this week, or he can grab it right from this patch :)

No.

I was unhappy about a staging driver being added in rc7, but I went
"whatever, it's Greg's garbage"

There is no way in hell I will take a new filesystem in rc8.

Would you take that into stable? No, you wouldn't. Then why is this
being upstreamed now.

Honestly, I think I'll just delete the whole thing, since it shouldn't
have gone in in the first place. This is not how we add new
filesystems.

             Linus

Re: [PATCH] vboxsf: move out of staging to fs/

[Linus Torvalds]

On Tue, Nov 12, 2019 at 2:54 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> Christoph, this is what you mean, right?  If so, I'll send this to Linus
> later this week, or he can grab it right from this patch :)

No.

I was unhappy about a staging driver being added in rc7, but I went
"whatever, it's Greg's garbage"

There is no way in hell I will take a new filesystem in rc8.

Would you take that into stable? No, you wouldn't. Then why is this
being upstreamed now.

Honestly, I think I'll just delete the whole thing, since it shouldn't
have gone in in the first place. This is not how we add new
filesystems.

             Linus
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] vboxsf: move out of staging to fs/

[Greg Kroah-Hartman]

On Tue, Nov 12, 2019 at 03:12:53PM -0800, Linus Torvalds wrote:
> On Tue, Nov 12, 2019 at 2:54 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > Christoph, this is what you mean, right?  If so, I'll send this to Linus
> > later this week, or he can grab it right from this patch :)
> 
> No.
> 
> I was unhappy about a staging driver being added in rc7, but I went
> "whatever, it's Greg's garbage"
> 
> There is no way in hell I will take a new filesystem in rc8.
> 
> Would you take that into stable? No, you wouldn't. Then why is this
> being upstreamed now.
> 
> Honestly, I think I'll just delete the whole thing, since it shouldn't
> have gone in in the first place. This is not how we add new
> filesystems.

Fair enough, sorry for the noise.

greg k-h

Re: [PATCH] vboxsf: move out of staging to fs/

[Greg Kroah-Hartman]

On Tue, Nov 12, 2019 at 03:12:53PM -0800, Linus Torvalds wrote:
> On Tue, Nov 12, 2019 at 2:54 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > Christoph, this is what you mean, right?  If so, I'll send this to Linus
> > later this week, or he can grab it right from this patch :)
> 
> No.
> 
> I was unhappy about a staging driver being added in rc7, but I went
> "whatever, it's Greg's garbage"
> 
> There is no way in hell I will take a new filesystem in rc8.
> 
> Would you take that into stable? No, you wouldn't. Then why is this
> being upstreamed now.
> 
> Honestly, I think I'll just delete the whole thing, since it shouldn't
> have gone in in the first place. This is not how we add new
> filesystems.

Fair enough, sorry for the noise.

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] vboxsf: move out of staging to fs/

[Hans de Goede]

Hi,

On 13-11-2019 00:12, Linus Torvalds wrote:
> On Tue, Nov 12, 2019 at 2:54 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>>
>> Christoph, this is what you mean, right?  If so, I'll send this to Linus
>> later this week, or he can grab it right from this patch :)
> 
> No.
> 
> I was unhappy about a staging driver being added in rc7, but I went
> "whatever, it's Greg's garbage"
> 
> There is no way in hell I will take a new filesystem in rc8.
> 
> Would you take that into stable? No, you wouldn't. Then why is this
> being upstreamed now.
> 
> Honestly, I think I'll just delete the whole thing, since it shouldn't
> have gone in in the first place. This is not how we add new
> filesystems.

I understand you being unhappy with this.

The problem is that Al Viro, after an initial review around v2 or v3 of
the patch, which I believe I have fully addressed, has been ignoring
this patch / new fs for over a year now. I've pinged him repeatedly
both via email and on irc, but with no luck.  I guess he simply is
too busy with other stuff.

I did ask other fs developers to review and have gotten reviews
from David Howell and Christoph Hellwig. I've addressed all their
review remarks and I've had reviews of the newer versions with
just a few nitpicks remaining. I've also addressed those nitpicks.
But I never got an Acked-by or Reviewed-by from either of them
on any of the newer versions.

I even talked to various people about this at plumbers, but
I did not get any traction there either.

On the advice of Christoph I've asked Andrew Morton to take this
directly under fs/ instead, twice. When this all went no where I
went the staging route, with the current result.

So for 5.5, and assuming I can get David's and/or Christoph's
Acked-by, is is ok if I send this directly to you?

Regards,

Hans

p.s.

Christoph, David, can I get your Acked-by for the latest
version of the patch (v17) ?

Re: [PATCH] vboxsf: move out of staging to fs/

[Hans de Goede]

Hi,

On 13-11-2019 00:12, Linus Torvalds wrote:
> On Tue, Nov 12, 2019 at 2:54 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>>
>> Christoph, this is what you mean, right?  If so, I'll send this to Linus
>> later this week, or he can grab it right from this patch :)
> 
> No.
> 
> I was unhappy about a staging driver being added in rc7, but I went
> "whatever, it's Greg's garbage"
> 
> There is no way in hell I will take a new filesystem in rc8.
> 
> Would you take that into stable? No, you wouldn't. Then why is this
> being upstreamed now.
> 
> Honestly, I think I'll just delete the whole thing, since it shouldn't
> have gone in in the first place. This is not how we add new
> filesystems.

I understand you being unhappy with this.

The problem is that Al Viro, after an initial review around v2 or v3 of
the patch, which I believe I have fully addressed, has been ignoring
this patch / new fs for over a year now. I've pinged him repeatedly
both via email and on irc, but with no luck.  I guess he simply is
too busy with other stuff.

I did ask other fs developers to review and have gotten reviews
from David Howell and Christoph Hellwig. I've addressed all their
review remarks and I've had reviews of the newer versions with
just a few nitpicks remaining. I've also addressed those nitpicks.
But I never got an Acked-by or Reviewed-by from either of them
on any of the newer versions.

I even talked to various people about this at plumbers, but
I did not get any traction there either.

On the advice of Christoph I've asked Andrew Morton to take this
directly under fs/ instead, twice. When this all went no where I
went the staging route, with the current result.

So for 5.5, and assuming I can get David's and/or Christoph's
Acked-by, is is ok if I send this directly to you?

Regards,

Hans

p.s.

Christoph, David, can I get your Acked-by for the latest
version of the patch (v17) ?

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel