linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Huang, Xiong" <xiong@qca.qualcomm.com>
To: David Miller <davem@davemloft.net>,
	"Ren, Cloud" <cjren@qca.qualcomm.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	qca-linux-team <qca-linux-team@qualcomm.com>,
	nic-devel <nic-devel@qualcomm.com>,
	"Rodriguez, Luis" <rodrigue@qca.qualcomm.com>
Subject: RE: [PATCH v2] net: add new QCA alx ethernet driver
Date: Thu, 23 Aug 2012 06:35:40 +0000	[thread overview]
Message-ID: <157393863283F442885425D2C45428562A4F5169@nasanexd02f.na.qualcomm.com> (raw)
In-Reply-To: <20120822.225700.714020017287504609.davem@davemloft.net>

> This is why we require that portable, sane, interfaces are added to ethtool for
> driver diagnostics.  That way users can perform a task in the same way
> regardless of what hardware and driver are underneath.

I quite agree you on using ethtool to implement it. we did consider it. 
But ethtool has some limitation, for example, the NIC has built-in OTP (TWSI interface)
And Flash (External SPI interface),  their properties are quite different with EEPROM which
Ethtool supports.
To support such memory (OTP/Flash), we need additional input parameters.

Same situation exists in diagnostic utility. Ethtool only provide two options : offline & online
That's too gross to locate which part/module of the chip is malfunction. we also need 
more options to detect it.

that's why we finally selected a custom debugfs interface. 

Thanks
Xiong


  reply	other threads:[~2012-08-23  6:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20 16:42 [PATCH v2] net: add new QCA alx ethernet driver cjren
2012-08-23  5:57 ` David Miller
2012-08-23  6:35   ` Huang, Xiong [this message]
2012-08-23  6:40     ` David Miller
2012-08-23  6:56       ` Huang, Xiong
2012-08-23  7:13         ` David Miller
2012-08-23 10:28           ` Luis R. Rodriguez
2012-08-23 21:09     ` Ben Hutchings
2012-08-24  1:55       ` Huang, Xiong
2012-08-24  2:09         ` Ben Hutchings
2012-08-24  2:39           ` Huang, Xiong
2012-08-24  4:32             ` Luis R. Rodriguez
2012-08-24  5:34               ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157393863283F442885425D2C45428562A4F5169@nasanexd02f.na.qualcomm.com \
    --to=xiong@qca.qualcomm.com \
    --cc=cjren@qca.qualcomm.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic-devel@qualcomm.com \
    --cc=qca-linux-team@qualcomm.com \
    --cc=rodrigue@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).