* [PATCH] bfq: Replace kmalloc_node with kzalloc_node
@ 2019-11-19 15:02 Xianting Tian
2019-12-03 15:01 ` Michal Koutný
0 siblings, 1 reply; 2+ messages in thread
From: Xianting Tian @ 2019-11-19 15:02 UTC (permalink / raw)
To: paolo.valente, axboe, tj; +Cc: linux-block, cgroups, linux-kernel
Replace kmalloc_node with kzalloc_node
Signed-off-by: Xianting Tian <xianting_tian@126.com>
---
block/bfq-cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
index 86a607c..9a84d79 100644
--- a/block/bfq-cgroup.c
+++ b/block/bfq-cgroup.c
@@ -1385,7 +1385,7 @@ struct bfq_group *bfq_create_group_hierarchy(struct bfq_data *bfqd, int node)
struct bfq_group *bfqg;
int i;
- bfqg = kmalloc_node(sizeof(*bfqg), GFP_KERNEL | __GFP_ZERO, node);
+ bfqg = kzalloc_node(sizeof(*bfqg), GFP_KERNEL, node);
if (!bfqg)
return NULL;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bfq: Replace kmalloc_node with kzalloc_node
2019-11-19 15:02 [PATCH] bfq: Replace kmalloc_node with kzalloc_node Xianting Tian
@ 2019-12-03 15:01 ` Michal Koutný
0 siblings, 0 replies; 2+ messages in thread
From: Michal Koutný @ 2019-12-03 15:01 UTC (permalink / raw)
To: Xianting Tian
Cc: paolo.valente, axboe, tj, linux-block, cgroups, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
Hi Xianting.
On Tue, Nov 19, 2019 at 10:02:26AM -0500, Xianting Tian <xianting_tian@126.com> wrote:
> Replace kmalloc_node with kzalloc_node
IIUC, your patch makes no functional change and from the message it's
not clear what's the motivation. Could you please make the commit
message more descriptive so that it can be evaluated?
Michal
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-03 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 15:02 [PATCH] bfq: Replace kmalloc_node with kzalloc_node Xianting Tian
2019-12-03 15:01 ` Michal Koutný
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).