[tip:WIP.x86/mm 22/27] arch/x86/mm/pat/set_memory.c:334:6: sparse: sparse: symbol '__cpa_flush_tlb' was not declared. Should it be static?

[tip:WIP.x86/mm 22/27] arch/x86/mm/pat/set_memory.c:334:6: sparse: sparse: symbol '__cpa_flush_tlb' was not declared. Should it be static?

[kbuild test robot]

Hi Ingo,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.x86/mm
head:   f53ee099dface98b5d75f6ba3b15c7ae8b26099c
commit: b2c61e70cccafd312eba9b0e4ca06361d800bc93 [22/27] x86/mm/pat: Move the memtype related files to arch/x86/mm/pat/
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-36-g9305d48-dirty
        git checkout b2c61e70cccafd312eba9b0e4ca06361d800bc93
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> arch/x86/mm/pat/set_memory.c:334:6: sparse: sparse: symbol '__cpa_flush_tlb' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[RFC PATCH tip] x86/mm/pat: __cpa_flush_tlb() can be static

[kbuild test robot]

Fixes: b2c61e70ccca ("x86/mm/pat: Move the memtype related files to arch/x86/mm/pat/")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 set_memory.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
index eca88239efea2..4a1e9c2e59e97 100644
--- a/arch/x86/mm/pat/set_memory.c
+++ b/arch/x86/mm/pat/set_memory.c
@@ -331,7 +331,7 @@ static void cpa_flush_all(unsigned long cache)
 	on_each_cpu(__cpa_flush_all, (void *) cache, 1);
 }
 
-void __cpa_flush_tlb(void *data)
+static void __cpa_flush_tlb(void *data)
 {
 	struct cpa_data *cpa = data;
 	unsigned int i;

[tip: x86/mm] x86/mm/pat: Mark __cpa_flush_tlb() as static

[tip-bot2 for kbuild test robot]

The following commit has been merged into the x86/mm branch of tip:

Commit-ID:     da9144c5ad8943f9003ec4a6a0200637b4ba9ebd
Gitweb:        https://git.kernel.org/tip/da9144c5ad8943f9003ec4a6a0200637b4ba9ebd
Author:        kbuild test robot <lkp@intel.com>
AuthorDate:    Sat, 23 Nov 2019 23:30:23 +08:00
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 10 Dec 2019 10:12:55 +01:00

x86/mm/pat: Mark __cpa_flush_tlb() as static

Signed-off-by: kbuild test robot <lkp@intel.com>
Link: https://lkml.kernel.org/r/20191123153023.bj6m66scjeubhbjg@4978f4969bb8
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/mm/pat/set_memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
index d4ab493..2082339 100644
--- a/arch/x86/mm/pat/set_memory.c
+++ b/arch/x86/mm/pat/set_memory.c
@@ -331,7 +331,7 @@ static void cpa_flush_all(unsigned long cache)
 	on_each_cpu(__cpa_flush_all, (void *) cache, 1);
 }
 
-void __cpa_flush_tlb(void *data)
+static void __cpa_flush_tlb(void *data)
 {
 	struct cpa_data *cpa = data;
 	unsigned int i;