linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mikael Pettersson <mikpe@csd.uu.se>
To: Rik van Riel <riel@conectiva.com.br>
Cc: Chris Wedgwood <cw@f00f.org>, Daniele Lugli <genlogic@inrete.it>,
	<linux-kernel@vger.kernel.org>
Subject: Re: unhappy with current.h
Date: Tue, 15 Oct 2002 16:11:36 +0200	[thread overview]
Message-ID: <15788.8728.734070.225906@kim.it.uu.se> (raw)
In-Reply-To: <Pine.LNX.4.44L.0210142159580.22993-100000@imladris.surriel.com>

Rik van Riel writes:
 > On Mon, 14 Oct 2002, Chris Wedgwood wrote:
 > > On Mon, Oct 14, 2002 at 09:46:08PM +0200, Daniele Lugli wrote:
 > >
 > > > I recently wrote a kernel module which gave me some mysterious
 > > > problems. After too many days spent in blood, sweat and tears, I found the cause:
 > >
 > > > *** one of my data structures has a field named 'current'. ***
 > >
 > > gcc -Wshadow
 > 
 > Would it be a good idea to add -Wshadow to the kernel
 > compile options by default ?

While I'm not defending macro abuse, please note that Daniele's problem
appears to have been caused by using g++ instead of gcc or gcc -x c to
compile a kernel module. Daniele's later example throws a syntax error
in gcc, since the cpp output isn't legal C ...

Hence I fail to see the utility of hacking in kludges for something
that's not supposed to work anyway.

  parent reply	other threads:[~2002-10-15 14:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-14 19:46 unhappy with current.h Daniele Lugli
2002-10-14 19:52 ` David S. Miller
2002-10-14 20:18   ` Daniele Lugli
2002-10-14 20:24 ` Chris Wedgwood
2002-10-15  0:00   ` Rik van Riel
2002-10-15  1:05     ` Chris Wedgwood
2002-10-15  1:12     ` Murray J. Root
2002-10-15 14:11     ` Mikael Pettersson [this message]
2002-10-15 20:29       ` Daniele Lugli
2002-10-15 20:44         ` Alexander Viro
2002-10-15 21:01         ` Mikael Pettersson
2002-10-14 20:33 ` Richard B. Johnson
2002-10-14 20:33   ` David S. Miller
2002-10-14 20:37   ` Olivier Galibert
2002-10-15 18:31     ` Richard B. Johnson
2002-10-14 21:22   ` Daniele Lugli
2002-10-15 17:08     ` Richard B. Johnson
2002-10-14 20:45 ` Andi Kleen
2002-10-15  1:09   ` Chris Wedgwood
     [not found] <20021014.161535.17120.336861@webmail4.nyc.untd.com>
2002-10-14 20:24 ` Daniele Lugli
2002-10-18 14:49 Jeffrey Lim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15788.8728.734070.225906@kim.it.uu.se \
    --to=mikpe@csd.uu.se \
    --cc=cw@f00f.org \
    --cc=genlogic@inrete.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riel@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).