From: "Murray J. Root" <murrayr@brain.org>
To: linux-kernel@vger.kernel.org
Subject: Re: unhappy with current.h
Date: Mon, 14 Oct 2002 21:12:55 -0400 [thread overview]
Message-ID: <20021015011255.GA4098@Master.Wizards> (raw)
In-Reply-To: <Pine.LNX.4.44L.0210142159580.22993-100000@imladris.surriel.com>
On Mon, Oct 14, 2002 at 10:00:26PM -0200, Rik van Riel wrote:
> On Mon, 14 Oct 2002, Chris Wedgwood wrote:
> > On Mon, Oct 14, 2002 at 09:46:08PM +0200, Daniele Lugli wrote:
> >
> > > I recently wrote a kernel module which gave me some mysterious
> > > problems. After too many days spent in blood, sweat and tears, I found the cause:
> >
> > > *** one of my data structures has a field named 'current'. ***
> >
> > gcc -Wshadow
>
> Would it be a good idea to add -Wshadow to the kernel
> compile options by default ?
>
Yes.
--
Murray J. Root
------------------------------------------------
DISCLAIMER: http://www.goldmark.org/jeff/stupid-disclaimers/
------------------------------------------------
Mandrake on irc.freenode.net:
#mandrake & #mandrake-linux = help for newbies
#mdk-cooker = Mandrake Cooker
next prev parent reply other threads:[~2002-10-15 1:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-14 19:46 unhappy with current.h Daniele Lugli
2002-10-14 19:52 ` David S. Miller
2002-10-14 20:18 ` Daniele Lugli
2002-10-14 20:24 ` Chris Wedgwood
2002-10-15 0:00 ` Rik van Riel
2002-10-15 1:05 ` Chris Wedgwood
2002-10-15 1:12 ` Murray J. Root [this message]
2002-10-15 14:11 ` Mikael Pettersson
2002-10-15 20:29 ` Daniele Lugli
2002-10-15 20:44 ` Alexander Viro
2002-10-15 21:01 ` Mikael Pettersson
2002-10-14 20:33 ` Richard B. Johnson
2002-10-14 20:33 ` David S. Miller
2002-10-14 20:37 ` Olivier Galibert
2002-10-15 18:31 ` Richard B. Johnson
2002-10-14 21:22 ` Daniele Lugli
2002-10-15 17:08 ` Richard B. Johnson
2002-10-14 20:45 ` Andi Kleen
2002-10-15 1:09 ` Chris Wedgwood
[not found] <20021014.161535.17120.336861@webmail4.nyc.untd.com>
2002-10-14 20:24 ` Daniele Lugli
2002-10-18 14:49 Jeffrey Lim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021015011255.GA4098@Master.Wizards \
--to=murrayr@brain.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).