* [PATCH] clocksource/drivers/timer-microchip-pit64b: fix sparse warning
@ 2020-01-06 9:58 Claudiu Beznea
2020-01-09 11:59 ` Daniel Lezcano
2020-01-16 21:30 ` [tip: timers/core] clocksource/drivers/timer-microchip-pit64b: Fix " tip-bot2 for Claudiu Beznea
0 siblings, 2 replies; 6+ messages in thread
From: Claudiu Beznea @ 2020-01-06 9:58 UTC (permalink / raw)
To: daniel.lezcano, tglx; +Cc: linux-kernel, Claudiu Beznea
Fix sparse warning.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
drivers/clocksource/timer-microchip-pit64b.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-microchip-pit64b.c b/drivers/clocksource/timer-microchip-pit64b.c
index 27a389a7e078..bd63d3484838 100644
--- a/drivers/clocksource/timer-microchip-pit64b.c
+++ b/drivers/clocksource/timer-microchip-pit64b.c
@@ -248,6 +248,8 @@ static int __init mchp_pit64b_init_mode(struct mchp_pit64b_timer *timer,
if (!pclk_rate)
return -EINVAL;
+ timer->mode = 0;
+
/* Try using GCLK. */
gclk_round = clk_round_rate(timer->gclk, max_rate);
if (gclk_round < 0)
@@ -360,7 +362,7 @@ static int __init mchp_pit64b_dt_init_timer(struct device_node *node,
bool clkevt)
{
u32 freq = clkevt ? MCHP_PIT64B_DEF_CE_FREQ : MCHP_PIT64B_DEF_CS_FREQ;
- struct mchp_pit64b_timer timer = { 0 };
+ struct mchp_pit64b_timer timer;
unsigned long clk_rate;
u32 irq = 0;
int ret;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] clocksource/drivers/timer-microchip-pit64b: fix sparse warning
2020-01-06 9:58 [PATCH] clocksource/drivers/timer-microchip-pit64b: fix sparse warning Claudiu Beznea
@ 2020-01-09 11:59 ` Daniel Lezcano
2020-01-09 12:29 ` Claudiu.Beznea
2020-01-16 21:30 ` [tip: timers/core] clocksource/drivers/timer-microchip-pit64b: Fix " tip-bot2 for Claudiu Beznea
1 sibling, 1 reply; 6+ messages in thread
From: Daniel Lezcano @ 2020-01-09 11:59 UTC (permalink / raw)
To: Claudiu Beznea, tglx; +Cc: linux-kernel
On 06/01/2020 10:58, Claudiu Beznea wrote:
> Fix sparse warning.
Mind to give the warning?
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> drivers/clocksource/timer-microchip-pit64b.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-microchip-pit64b.c b/drivers/clocksource/timer-microchip-pit64b.c
> index 27a389a7e078..bd63d3484838 100644
> --- a/drivers/clocksource/timer-microchip-pit64b.c
> +++ b/drivers/clocksource/timer-microchip-pit64b.c
> @@ -248,6 +248,8 @@ static int __init mchp_pit64b_init_mode(struct mchp_pit64b_timer *timer,
> if (!pclk_rate)
> return -EINVAL;
>
> + timer->mode = 0;
> +
> /* Try using GCLK. */
> gclk_round = clk_round_rate(timer->gclk, max_rate);
> if (gclk_round < 0)
> @@ -360,7 +362,7 @@ static int __init mchp_pit64b_dt_init_timer(struct device_node *node,
> bool clkevt)
> {
> u32 freq = clkevt ? MCHP_PIT64B_DEF_CE_FREQ : MCHP_PIT64B_DEF_CS_FREQ;
> - struct mchp_pit64b_timer timer = { 0 };
> + struct mchp_pit64b_timer timer;
> unsigned long clk_rate;
> u32 irq = 0;
> int ret;
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] clocksource/drivers/timer-microchip-pit64b: fix sparse warning
2020-01-09 11:59 ` Daniel Lezcano
@ 2020-01-09 12:29 ` Claudiu.Beznea
2020-01-09 12:40 ` Daniel Lezcano
0 siblings, 1 reply; 6+ messages in thread
From: Claudiu.Beznea @ 2020-01-09 12:29 UTC (permalink / raw)
To: daniel.lezcano, tglx; +Cc: linux-kernel
On 09.01.2020 13:59, Daniel Lezcano wrote:
> On 06/01/2020 10:58, Claudiu Beznea wrote:
>> Fix sparse warning.
>
> Mind to give the warning?
Sorry, is this one: "warning: Using plain integer as NULL pointer".
Would you like me to send v2 updating it with the warning?
Thank you,
Claudiu Beznea
>
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>> drivers/clocksource/timer-microchip-pit64b.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clocksource/timer-microchip-pit64b.c b/drivers/clocksource/timer-microchip-pit64b.c
>> index 27a389a7e078..bd63d3484838 100644
>> --- a/drivers/clocksource/timer-microchip-pit64b.c
>> +++ b/drivers/clocksource/timer-microchip-pit64b.c
>> @@ -248,6 +248,8 @@ static int __init mchp_pit64b_init_mode(struct mchp_pit64b_timer *timer,
>> if (!pclk_rate)
>> return -EINVAL;
>>
>> + timer->mode = 0;
>> +
>> /* Try using GCLK. */
>> gclk_round = clk_round_rate(timer->gclk, max_rate);
>> if (gclk_round < 0)
>> @@ -360,7 +362,7 @@ static int __init mchp_pit64b_dt_init_timer(struct device_node *node,
>> bool clkevt)
>> {
>> u32 freq = clkevt ? MCHP_PIT64B_DEF_CE_FREQ : MCHP_PIT64B_DEF_CS_FREQ;
>> - struct mchp_pit64b_timer timer = { 0 };
>> + struct mchp_pit64b_timer timer;
>> unsigned long clk_rate;
>> u32 irq = 0;
>> int ret;
>>
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] clocksource/drivers/timer-microchip-pit64b: fix sparse warning
2020-01-09 12:29 ` Claudiu.Beznea
@ 2020-01-09 12:40 ` Daniel Lezcano
2020-01-09 12:52 ` Claudiu.Beznea
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Lezcano @ 2020-01-09 12:40 UTC (permalink / raw)
To: Claudiu.Beznea, tglx; +Cc: linux-kernel
On 09/01/2020 13:29, Claudiu.Beznea@microchip.com wrote:
>
>
> On 09.01.2020 13:59, Daniel Lezcano wrote:
>> On 06/01/2020 10:58, Claudiu Beznea wrote:
>>> Fix sparse warning.
>>
>> Mind to give the warning?
>
> Sorry, is this one: "warning: Using plain integer as NULL pointer".
>
> Would you like me to send v2 updating it with the warning?
No, it is fine, I will update the log manually.
Thanks
>>> Reported-by: kbuild test robot <lkp@intel.com>
>>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>>> ---
>>> drivers/clocksource/timer-microchip-pit64b.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/clocksource/timer-microchip-pit64b.c b/drivers/clocksource/timer-microchip-pit64b.c
>>> index 27a389a7e078..bd63d3484838 100644
>>> --- a/drivers/clocksource/timer-microchip-pit64b.c
>>> +++ b/drivers/clocksource/timer-microchip-pit64b.c
>>> @@ -248,6 +248,8 @@ static int __init mchp_pit64b_init_mode(struct mchp_pit64b_timer *timer,
>>> if (!pclk_rate)
>>> return -EINVAL;
>>>
>>> + timer->mode = 0;
>>> +
>>> /* Try using GCLK. */
>>> gclk_round = clk_round_rate(timer->gclk, max_rate);
>>> if (gclk_round < 0)
>>> @@ -360,7 +362,7 @@ static int __init mchp_pit64b_dt_init_timer(struct device_node *node,
>>> bool clkevt)
>>> {
>>> u32 freq = clkevt ? MCHP_PIT64B_DEF_CE_FREQ : MCHP_PIT64B_DEF_CS_FREQ;
>>> - struct mchp_pit64b_timer timer = { 0 };
>>> + struct mchp_pit64b_timer timer;
>>> unsigned long clk_rate;
>>> u32 irq = 0;
>>> int ret;
>>>
>>
>>
>> --
>> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>>
>> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
>> <http://twitter.com/#!/linaroorg> Twitter |
>> <http://www.linaro.org/linaro-blog/> Blog
>>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] clocksource/drivers/timer-microchip-pit64b: fix sparse warning
2020-01-09 12:40 ` Daniel Lezcano
@ 2020-01-09 12:52 ` Claudiu.Beznea
0 siblings, 0 replies; 6+ messages in thread
From: Claudiu.Beznea @ 2020-01-09 12:52 UTC (permalink / raw)
To: daniel.lezcano, tglx; +Cc: linux-kernel
On 09.01.2020 14:40, Daniel Lezcano wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 09/01/2020 13:29, Claudiu.Beznea@microchip.com wrote:
>>
>>
>> On 09.01.2020 13:59, Daniel Lezcano wrote:
>>> On 06/01/2020 10:58, Claudiu Beznea wrote:
>>>> Fix sparse warning.
>>>
>>> Mind to give the warning?
>>
>> Sorry, is this one: "warning: Using plain integer as NULL pointer".
>>
>> Would you like me to send v2 updating it with the warning?
>
> No, it is fine, I will update the log manually.
Thank you!
>
> Thanks
>
>>>> Reported-by: kbuild test robot <lkp@intel.com>
>>>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>>>> ---
>>>> drivers/clocksource/timer-microchip-pit64b.c | 4 +++-
>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/clocksource/timer-microchip-pit64b.c b/drivers/clocksource/timer-microchip-pit64b.c
>>>> index 27a389a7e078..bd63d3484838 100644
>>>> --- a/drivers/clocksource/timer-microchip-pit64b.c
>>>> +++ b/drivers/clocksource/timer-microchip-pit64b.c
>>>> @@ -248,6 +248,8 @@ static int __init mchp_pit64b_init_mode(struct mchp_pit64b_timer *timer,
>>>> if (!pclk_rate)
>>>> return -EINVAL;
>>>>
>>>> + timer->mode = 0;
>>>> +
>>>> /* Try using GCLK. */
>>>> gclk_round = clk_round_rate(timer->gclk, max_rate);
>>>> if (gclk_round < 0)
>>>> @@ -360,7 +362,7 @@ static int __init mchp_pit64b_dt_init_timer(struct device_node *node,
>>>> bool clkevt)
>>>> {
>>>> u32 freq = clkevt ? MCHP_PIT64B_DEF_CE_FREQ : MCHP_PIT64B_DEF_CS_FREQ;
>>>> - struct mchp_pit64b_timer timer = { 0 };
>>>> + struct mchp_pit64b_timer timer;
>>>> unsigned long clk_rate;
>>>> u32 irq = 0;
>>>> int ret;
>>>>
>>>
>>>
>>> --
>>> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>>>
>>> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
>>> <http://twitter.com/#!/linaroorg> Twitter |
>>> <http://www.linaro.org/linaro-blog/> Blog
>>>
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [tip: timers/core] clocksource/drivers/timer-microchip-pit64b: Fix sparse warning
2020-01-06 9:58 [PATCH] clocksource/drivers/timer-microchip-pit64b: fix sparse warning Claudiu Beznea
2020-01-09 11:59 ` Daniel Lezcano
@ 2020-01-16 21:30 ` tip-bot2 for Claudiu Beznea
1 sibling, 0 replies; 6+ messages in thread
From: tip-bot2 for Claudiu Beznea @ 2020-01-16 21:30 UTC (permalink / raw)
To: linux-tip-commits
Cc: kbuild test robot, Claudiu Beznea, Daniel Lezcano, x86, LKML
The following commit has been merged into the timers/core branch of tip:
Commit-ID: b9c60a741f06eda56d12c7216accb317b74266b4
Gitweb: https://git.kernel.org/tip/b9c60a741f06eda56d12c7216accb317b74266b4
Author: Claudiu Beznea <claudiu.beznea@microchip.com>
AuthorDate: Mon, 06 Jan 2020 11:58:08 +02:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Thu, 16 Jan 2020 19:09:02 +01:00
clocksource/drivers/timer-microchip-pit64b: Fix sparse warning
Fix sparse warning:
"warning: Using plain integer as NULL pointer"
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/1578304688-14882-1-git-send-email-claudiu.beznea@microchip.com
---
drivers/clocksource/timer-microchip-pit64b.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-microchip-pit64b.c b/drivers/clocksource/timer-microchip-pit64b.c
index 27a389a..bd63d34 100644
--- a/drivers/clocksource/timer-microchip-pit64b.c
+++ b/drivers/clocksource/timer-microchip-pit64b.c
@@ -248,6 +248,8 @@ static int __init mchp_pit64b_init_mode(struct mchp_pit64b_timer *timer,
if (!pclk_rate)
return -EINVAL;
+ timer->mode = 0;
+
/* Try using GCLK. */
gclk_round = clk_round_rate(timer->gclk, max_rate);
if (gclk_round < 0)
@@ -360,7 +362,7 @@ static int __init mchp_pit64b_dt_init_timer(struct device_node *node,
bool clkevt)
{
u32 freq = clkevt ? MCHP_PIT64B_DEF_CE_FREQ : MCHP_PIT64B_DEF_CS_FREQ;
- struct mchp_pit64b_timer timer = { 0 };
+ struct mchp_pit64b_timer timer;
unsigned long clk_rate;
u32 irq = 0;
int ret;
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-16 21:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-06 9:58 [PATCH] clocksource/drivers/timer-microchip-pit64b: fix sparse warning Claudiu Beznea
2020-01-09 11:59 ` Daniel Lezcano
2020-01-09 12:29 ` Claudiu.Beznea
2020-01-09 12:40 ` Daniel Lezcano
2020-01-09 12:52 ` Claudiu.Beznea
2020-01-16 21:30 ` [tip: timers/core] clocksource/drivers/timer-microchip-pit64b: Fix " tip-bot2 for Claudiu Beznea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).