linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [tip: sched/core] sched/fair: Define sched_idle_cpu() only for SMP configurations
@ 2020-01-20  7:08 tip-bot2 for Viresh Kumar
  0 siblings, 0 replies; only message in thread
From: tip-bot2 for Viresh Kumar @ 2020-01-20  7:08 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Stephen Rothwell, Viresh Kumar, Ingo Molnar, Juri Lelli,
	Vincent Guittot, Dietmar Eggemann, x86, LKML

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     afa70d941f663c69c9a64ec1021bbcfa82f0e54a
Gitweb:        https://git.kernel.org/tip/afa70d941f663c69c9a64ec1021bbcfa82f0e54a
Author:        Viresh Kumar <viresh.kumar@linaro.org>
AuthorDate:    Mon, 20 Jan 2020 11:29:05 +05:30
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Mon, 20 Jan 2020 08:03:39 +01:00

sched/fair: Define sched_idle_cpu() only for SMP configurations

sched_idle_cpu() isn't used for non SMP configuration and with a recent
change, we have started getting following warning:

  kernel/sched/fair.c:5221:12: warning: ‘sched_idle_cpu’ defined but not used [-Wunused-function]

Fix that by defining sched_idle_cpu() only for SMP configurations.

Fixes: 323af6deaf70 ("sched/fair: Load balance aggressively for SCHED_IDLE CPUs")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Juri Lelli <juri.lelli@redhat.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Link: https://lore.kernel.org/r/f0554f590687478b33914a4aff9f0e6a62886d44.1579499907.git.viresh.kumar@linaro.org
---
 kernel/sched/fair.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index ebf5095..fe4e0d7 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5218,10 +5218,12 @@ static int sched_idle_rq(struct rq *rq)
 			rq->nr_running);
 }
 
+#ifdef CONFIG_SMP
 static int sched_idle_cpu(int cpu)
 {
 	return sched_idle_rq(cpu_rq(cpu));
 }
+#endif
 
 /*
  * The enqueue_task method is called before nr_running is

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-01-20  7:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-20  7:08 [tip: sched/core] sched/fair: Define sched_idle_cpu() only for SMP configurations tip-bot2 for Viresh Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).