* [PATCH] drm/bridge/synopsys: dsi: missing post disable
@ 2020-01-21 10:24 Yannick Fertre
2020-01-23 9:55 ` Philippe CORNU
0 siblings, 1 reply; 2+ messages in thread
From: Yannick Fertre @ 2020-01-21 10:24 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue, dri-devel,
linux-stm32, linux-arm-kernel, linux-kernel
From: Yannick Fertré <yannick.fertre@st.com>
Sometime the post_disable function is missing (not registered).
Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index b18351b..12823ae 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -824,7 +824,8 @@ static void dw_mipi_dsi_bridge_post_disable(struct drm_bridge *bridge)
* This needs to be fixed in the drm_bridge framework and the API
* needs to be updated to manage our own call chains...
*/
- dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge);
+ if (dsi->panel_bridge->funcs->post_disable)
+ dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge);
if (phy_ops->power_off)
phy_ops->power_off(dsi->plat_data->priv_data);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/bridge/synopsys: dsi: missing post disable
2020-01-21 10:24 [PATCH] drm/bridge/synopsys: dsi: missing post disable Yannick Fertre
@ 2020-01-23 9:55 ` Philippe CORNU
0 siblings, 0 replies; 2+ messages in thread
From: Philippe CORNU @ 2020-01-23 9:55 UTC (permalink / raw)
To: Yannick FERTRE, Benjamin GAIGNARD, David Airlie, Daniel Vetter,
Maxime Coquelin, Alexandre TORGUE, dri-devel, linux-stm32,
linux-arm-kernel, linux-kernel
Dear Yannick,
Thank you for your patch,
Reviewed-by: Philippe Cornu <philippe.cornu@st.com>
Philippe :-)
On 1/21/20 11:24 AM, Yannick Fertre wrote:
> From: Yannick Fertré <yannick.fertre@st.com>
>
> Sometime the post_disable function is missing (not registered).
>
> Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index b18351b..12823ae 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -824,7 +824,8 @@ static void dw_mipi_dsi_bridge_post_disable(struct drm_bridge *bridge)
> * This needs to be fixed in the drm_bridge framework and the API
> * needs to be updated to manage our own call chains...
> */
> - dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge);
> + if (dsi->panel_bridge->funcs->post_disable)
> + dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge);
>
> if (phy_ops->power_off)
> phy_ops->power_off(dsi->plat_data->priv_data);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-23 9:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 10:24 [PATCH] drm/bridge/synopsys: dsi: missing post disable Yannick Fertre
2020-01-23 9:55 ` Philippe CORNU
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).