linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] counter: stm32-timer-cnt: remove iio headers
@ 2020-02-11 10:56 Fabrice Gasnier
  2020-02-14 12:47 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Gasnier @ 2020-02-11 10:56 UTC (permalink / raw)
  To: jic23
  Cc: vilhelm.gray, alexandre.torgue, mcoquelin.stm32,
	benjamin.gaignard, fabrice.gasnier, linux-iio, linux-stm32,
	linux-arm-kernel, linux-kernel

The stm32-timer-cnt driver doesn't use the iio interface. The iio headers
aren't relevant and can be removed as reported by William in [1].
With this change, mod_devicetable.h needs to be added to define the
'of_device_id' struct.

[1] https://lkml.org/lkml/2020/2/10/1516

Reported-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
Note this applies on top of:
- "counter: stm32-timer-cnt: add power management support"
---
 drivers/counter/stm32-timer-cnt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c
index 50496f4..ef2a974 100644
--- a/drivers/counter/stm32-timer-cnt.c
+++ b/drivers/counter/stm32-timer-cnt.c
@@ -8,9 +8,8 @@
  *
  */
 #include <linux/counter.h>
-#include <linux/iio/iio.h>
-#include <linux/iio/types.h>
 #include <linux/mfd/stm32-timers.h>
+#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/pinctrl/consumer.h>
 #include <linux/platform_device.h>
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] counter: stm32-timer-cnt: remove iio headers
  2020-02-11 10:56 [PATCH] counter: stm32-timer-cnt: remove iio headers Fabrice Gasnier
@ 2020-02-14 12:47 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-02-14 12:47 UTC (permalink / raw)
  To: Fabrice Gasnier
  Cc: vilhelm.gray, alexandre.torgue, mcoquelin.stm32,
	benjamin.gaignard, linux-iio, linux-stm32, linux-arm-kernel,
	linux-kernel

On Tue, 11 Feb 2020 11:56:06 +0100
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:

> The stm32-timer-cnt driver doesn't use the iio interface. The iio headers
> aren't relevant and can be removed as reported by William in [1].
> With this change, mod_devicetable.h needs to be added to define the
> 'of_device_id' struct.
> 
> [1] https://lkml.org/lkml/2020/2/10/1516
> 
> Reported-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Applied.

thanks,

Jonathan

> ---
> Note this applies on top of:
> - "counter: stm32-timer-cnt: add power management support"
> ---
>  drivers/counter/stm32-timer-cnt.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c
> index 50496f4..ef2a974 100644
> --- a/drivers/counter/stm32-timer-cnt.c
> +++ b/drivers/counter/stm32-timer-cnt.c
> @@ -8,9 +8,8 @@
>   *
>   */
>  #include <linux/counter.h>
> -#include <linux/iio/iio.h>
> -#include <linux/iio/types.h>
>  #include <linux/mfd/stm32-timers.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/pinctrl/consumer.h>
>  #include <linux/platform_device.h>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-14 12:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 10:56 [PATCH] counter: stm32-timer-cnt: remove iio headers Fabrice Gasnier
2020-02-14 12:47 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).