* [PATCH] selftests/x86/ptrace_syscall_32: Fix no-vDSO segfault
@ 2020-03-12 22:35 Andy Lutomirski
2020-03-20 10:36 ` [tip: x86/misc] " tip-bot2 for Andy Lutomirski
0 siblings, 1 reply; 2+ messages in thread
From: Andy Lutomirski @ 2020-03-12 22:35 UTC (permalink / raw)
To: X86 ML, LKML; +Cc: Andy Lutomirski, kbuild test robot
If AT_SYSINFO is not present, don't try to call a NULL pointer.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
tools/testing/selftests/x86/ptrace_syscall.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/x86/ptrace_syscall.c b/tools/testing/selftests/x86/ptrace_syscall.c
index 6f22238f3217..12aaa063196e 100644
--- a/tools/testing/selftests/x86/ptrace_syscall.c
+++ b/tools/testing/selftests/x86/ptrace_syscall.c
@@ -414,8 +414,12 @@ int main()
#if defined(__i386__) && (!defined(__GLIBC__) || __GLIBC__ > 2 || __GLIBC_MINOR__ >= 16)
vsyscall32 = (void *)getauxval(AT_SYSINFO);
- printf("[RUN]\tCheck AT_SYSINFO return regs\n");
- test_sys32_regs(do_full_vsyscall32);
+ if (vsyscall32) {
+ printf("[RUN]\tCheck AT_SYSINFO return regs\n");
+ test_sys32_regs(do_full_vsyscall32);
+ } else {
+ printf("[SKIP]\tAT_SYSINFO is not available\n");
+ }
#endif
test_ptrace_syscall_restart();
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [tip: x86/misc] selftests/x86/ptrace_syscall_32: Fix no-vDSO segfault
2020-03-12 22:35 [PATCH] selftests/x86/ptrace_syscall_32: Fix no-vDSO segfault Andy Lutomirski
@ 2020-03-20 10:36 ` tip-bot2 for Andy Lutomirski
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Andy Lutomirski @ 2020-03-20 10:36 UTC (permalink / raw)
To: linux-tip-commits
Cc: kbuild test robot, Andy Lutomirski, Borislav Petkov, x86, LKML
The following commit has been merged into the x86/misc branch of tip:
Commit-ID: 630b99ab60aa972052a4202a1ff96c7e45eb0054
Gitweb: https://git.kernel.org/tip/630b99ab60aa972052a4202a1ff96c7e45eb0054
Author: Andy Lutomirski <luto@kernel.org>
AuthorDate: Thu, 12 Mar 2020 15:35:51 -07:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Fri, 20 Mar 2020 11:28:47 +01:00
selftests/x86/ptrace_syscall_32: Fix no-vDSO segfault
If AT_SYSINFO is not present, don't try to call a NULL pointer.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/faaf688265a7e1a5b944d6f8bc0f6368158306d3.1584052409.git.luto@kernel.org
---
tools/testing/selftests/x86/ptrace_syscall.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/x86/ptrace_syscall.c b/tools/testing/selftests/x86/ptrace_syscall.c
index 6f22238..12aaa06 100644
--- a/tools/testing/selftests/x86/ptrace_syscall.c
+++ b/tools/testing/selftests/x86/ptrace_syscall.c
@@ -414,8 +414,12 @@ int main()
#if defined(__i386__) && (!defined(__GLIBC__) || __GLIBC__ > 2 || __GLIBC_MINOR__ >= 16)
vsyscall32 = (void *)getauxval(AT_SYSINFO);
- printf("[RUN]\tCheck AT_SYSINFO return regs\n");
- test_sys32_regs(do_full_vsyscall32);
+ if (vsyscall32) {
+ printf("[RUN]\tCheck AT_SYSINFO return regs\n");
+ test_sys32_regs(do_full_vsyscall32);
+ } else {
+ printf("[SKIP]\tAT_SYSINFO is not available\n");
+ }
#endif
test_ptrace_syscall_restart();
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-20 10:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-12 22:35 [PATCH] selftests/x86/ptrace_syscall_32: Fix no-vDSO segfault Andy Lutomirski
2020-03-20 10:36 ` [tip: x86/misc] " tip-bot2 for Andy Lutomirski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).