From: "tip-bot2 for Michael Kerrisk (man-pages)" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Michael Kerrisk <mtk.manpages@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dmitry Safonov <dima@arista.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Andrei Vagin <avagin@gmail.com>,
stable@vger.kernel.org, x86 <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [tip: timers/urgent] time/namespace: Fix time_for_children symlink
Date: Tue, 07 Apr 2020 10:42:00 -0000 [thread overview]
Message-ID: <158625612023.28353.17886180270911841813.tip-bot2@tip-bot2> (raw)
In-Reply-To: <a2418c48-ed80-3afe-116e-6611cb799557@gmail.com>
The following commit has been merged into the timers/urgent branch of tip:
Commit-ID: b801f1e22c23c259d6a2c955efddd20370de19a6
Gitweb: https://git.kernel.org/tip/b801f1e22c23c259d6a2c955efddd20370de19a6
Author: Michael Kerrisk (man-pages) <mtk.manpages@gmail.com>
AuthorDate: Fri, 03 Apr 2020 14:11:39 +02:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 07 Apr 2020 12:37:21 +02:00
time/namespace: Fix time_for_children symlink
Looking at the contents of the /proc/PID/ns/time_for_children symlink shows
an anomaly:
$ ls -l /proc/self/ns/* |awk '{print $9, $10, $11}'
...
/proc/self/ns/pid -> pid:[4026531836]
/proc/self/ns/pid_for_children -> pid:[4026531836]
/proc/self/ns/time -> time:[4026531834]
/proc/self/ns/time_for_children -> time_for_children:[4026531834]
/proc/self/ns/user -> user:[4026531837]
...
The reference for 'time_for_children' should be a 'time' namespace, just as
the reference for 'pid_for_children' is a 'pid' namespace. In other words,
the above time_for_children link should read:
/proc/self/ns/time_for_children -> time:[4026531834]
Fixes: 769071ac9f20 ("ns: Introduce Time Namespace")
Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Dmitry Safonov <dima@arista.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Acked-by: Andrei Vagin <avagin@gmail.com>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/a2418c48-ed80-3afe-116e-6611cb799557@gmail.com
---
kernel/time/namespace.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/time/namespace.c b/kernel/time/namespace.c
index e6ba064..3b30288 100644
--- a/kernel/time/namespace.c
+++ b/kernel/time/namespace.c
@@ -447,6 +447,7 @@ const struct proc_ns_operations timens_operations = {
const struct proc_ns_operations timens_for_children_operations = {
.name = "time_for_children",
+ .real_ns_name = "time",
.type = CLONE_NEWTIME,
.get = timens_for_children_get,
.put = timens_put,
prev parent reply other threads:[~2020-04-07 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 12:11 [PATCH] ns: Fix time_for_children symlink Michael Kerrisk (man-pages)
2020-04-03 12:34 ` Christian Brauner
2020-04-03 12:49 ` Dmitry Safonov
2020-04-07 3:33 ` Andrei Vagin
2020-04-07 10:42 ` tip-bot2 for Michael Kerrisk (man-pages) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158625612023.28353.17886180270911841813.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=avagin@gmail.com \
--cc=christian.brauner@ubuntu.com \
--cc=dima@arista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).