From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Dmitry Safonov <dima@arista.com>, Andrei Vagin <avagin@openvz.or>
Cc: mtk.manpages@gmail.com, Adrian Reber <adrian@lisas.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrei Vagin <avagin@gmail.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
Dmitry Safonov <0x7f454c46@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Andy Lutomirski <luto@kernel.org>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Containers <containers@lists.linux-foundation.org>
Subject: [PATCH] ns: Fix time_for_children symlink
Date: Fri, 3 Apr 2020 14:11:39 +0200 [thread overview]
Message-ID: <a2418c48-ed80-3afe-116e-6611cb799557@gmail.com> (raw)
Dmitry, Andrei,
Looking at the contents of the /proc/PID/ns/time_for_children
symlink shows an anomaly:
$ ls -l /proc/self/ns/* |awk '{print $9, $10, $11}'
...
/proc/self/ns/pid -> pid:[4026531836]
/proc/self/ns/pid_for_children -> pid:[4026531836]
/proc/self/ns/time -> time:[4026531834]
/proc/self/ns/time_for_children -> time_for_children:[4026531834]
/proc/self/ns/user -> user:[4026531837]
...
The reference for 'time_for_children' should be a 'time' namespace,
just as the reference for 'pid_for_children' is a 'pid' namespace.
In other words, I think the above time_for_children link should read:
/proc/self/ns/time_for_children -> time:[4026531834]
If you agree with this patch, then it should be marked for
stable@vger.kernel.org.
Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
---
kernel/time/namespace.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/time/namespace.c b/kernel/time/namespace.c
index e6ba064ce773..3b30288793fe 100644
--- a/kernel/time/namespace.c
+++ b/kernel/time/namespace.c
@@ -447,6 +447,7 @@ const struct proc_ns_operations timens_operations = {
const struct proc_ns_operations timens_for_children_operations = {
.name = "time_for_children",
+ .real_ns_name = "time",
.type = CLONE_NEWTIME,
.get = timens_for_children_get,
.put = timens_put,
--
2.25.1
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next reply other threads:[~2020-04-03 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 12:11 Michael Kerrisk (man-pages) [this message]
2020-04-03 12:34 ` [PATCH] ns: Fix time_for_children symlink Christian Brauner
2020-04-03 12:49 ` Dmitry Safonov
2020-04-07 3:33 ` Andrei Vagin
2020-04-07 10:42 ` [tip: timers/urgent] time/namespace: " tip-bot2 for Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2418c48-ed80-3afe-116e-6611cb799557@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=0x7f454c46@gmail.com \
--cc=adrian@lisas.de \
--cc=avagin@gmail.com \
--cc=avagin@openvz.or \
--cc=containers@lists.linux-foundation.org \
--cc=dima@arista.com \
--cc=ebiederm@xmission.com \
--cc=gorcunov@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).