* [PATCH] scsi: gdth: Make __gdth_execute static
@ 2020-04-07 16:21 Wang Hai
2020-04-15 1:33 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2020-04-07 16:21 UTC (permalink / raw)
To: achim_leubner, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel, wanghai38
Fix sparse warning:
drivers/scsi/gdth.c:332:5: warning:
symbol '__gdth_execute' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/scsi/gdth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index fe03410..7f150d5 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -329,8 +329,8 @@ static void gdth_scsi_done(struct scsi_cmnd *scp)
scp->scsi_done(scp);
}
-int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, char *cmnd,
- int timeout, u32 *info)
+static int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd,
+ char *cmnd, int timeout, u32 *info)
{
gdth_ha_str *ha = shost_priv(sdev->host);
struct scsi_cmnd *scp;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: gdth: Make __gdth_execute static
2020-04-07 16:21 [PATCH] scsi: gdth: Make __gdth_execute static Wang Hai
@ 2020-04-15 1:33 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-04-15 1:33 UTC (permalink / raw)
To: Wang Hai; +Cc: achim_leubner, jejb, martin.petersen, linux-scsi, linux-kernel
Wang,
> Fix sparse warning:
>
> drivers/scsi/gdth.c:332:5: warning:
> symbol '__gdth_execute' was not declared. Should it be static?
Applied to 5.8/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-15 1:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07 16:21 [PATCH] scsi: gdth: Make __gdth_execute static Wang Hai
2020-04-15 1:33 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).