* [PATCH] clk: asm9260: fix __clk_hw_register_fixed_rate_with_accuracy typo
@ 2020-04-08 15:53 Arnd Bergmann
2020-04-11 2:06 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2020-04-08 15:53 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: Arnd Bergmann, Manivannan Sadhasivam, linux-clk, linux-kernel
The __clk_hw_register_fixed_rate_with_accuracy() function (with two '_')
does not exist, and apparently never did:
drivers/clk/clk-asm9260.c: In function 'asm9260_acc_init':
drivers/clk/clk-asm9260.c:279:7: error: implicit declaration of function '__clk_hw_register_fixed_rate_with_accuracy'; did you mean 'clk_hw_register_fixed_rate_with_accuracy'? [-Werror=implicit-function-declaration]
279 | hw = __clk_hw_register_fixed_rate_with_accuracy(NULL, NULL, pll_clk,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| clk_hw_register_fixed_rate_with_accuracy
drivers/clk/clk-asm9260.c:279:5: error: assignment to 'struct clk_hw *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
279 | hw = __clk_hw_register_fixed_rate_with_accuracy(NULL, NULL, pll_clk,
| ^
From what I can tell, __clk_hw_register_fixed_rate() is the correct
API here, so use that instead.
Fixes: 728e3096741a ("clk: asm9260: Use parent accuracy in fixed rate clk")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/clk-asm9260.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk-asm9260.c b/drivers/clk/clk-asm9260.c
index 536b59aabd2c..bacebd457e6f 100644
--- a/drivers/clk/clk-asm9260.c
+++ b/drivers/clk/clk-asm9260.c
@@ -276,7 +276,7 @@ static void __init asm9260_acc_init(struct device_node *np)
/* TODO: Convert to DT parent scheme */
ref_clk = of_clk_get_parent_name(np, 0);
- hw = __clk_hw_register_fixed_rate_with_accuracy(NULL, NULL, pll_clk,
+ hw = __clk_hw_register_fixed_rate(NULL, NULL, pll_clk,
ref_clk, NULL, NULL, 0, rate, 0,
CLK_FIXED_RATE_PARENT_ACCURACY);
--
2.26.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: asm9260: fix __clk_hw_register_fixed_rate_with_accuracy typo
2020-04-08 15:53 [PATCH] clk: asm9260: fix __clk_hw_register_fixed_rate_with_accuracy typo Arnd Bergmann
@ 2020-04-11 2:06 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2020-04-11 2:06 UTC (permalink / raw)
To: Arnd Bergmann, Michael Turquette
Cc: Arnd Bergmann, Manivannan Sadhasivam, linux-clk, linux-kernel
Quoting Arnd Bergmann (2020-04-08 08:53:43)
> The __clk_hw_register_fixed_rate_with_accuracy() function (with two '_')
> does not exist, and apparently never did:
>
> drivers/clk/clk-asm9260.c: In function 'asm9260_acc_init':
> drivers/clk/clk-asm9260.c:279:7: error: implicit declaration of function '__clk_hw_register_fixed_rate_with_accuracy'; did you mean 'clk_hw_register_fixed_rate_with_accuracy'? [-Werror=implicit-function-declaration]
> 279 | hw = __clk_hw_register_fixed_rate_with_accuracy(NULL, NULL, pll_clk,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | clk_hw_register_fixed_rate_with_accuracy
> drivers/clk/clk-asm9260.c:279:5: error: assignment to 'struct clk_hw *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> 279 | hw = __clk_hw_register_fixed_rate_with_accuracy(NULL, NULL, pll_clk,
> | ^
>
> From what I can tell, __clk_hw_register_fixed_rate() is the correct
> API here, so use that instead.
>
> Fixes: 728e3096741a ("clk: asm9260: Use parent accuracy in fixed rate clk")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to clk-fixes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-11 2:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-08 15:53 [PATCH] clk: asm9260: fix __clk_hw_register_fixed_rate_with_accuracy typo Arnd Bergmann
2020-04-11 2:06 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).