* [PATCH] tools/bpf/bpftool: Remove duplicate headers
@ 2020-04-19 5:39 jagdsh.linux
2020-04-20 8:27 ` Quentin Monnet
2020-04-21 3:28 ` Alexei Starovoitov
0 siblings, 2 replies; 3+ messages in thread
From: jagdsh.linux @ 2020-04-19 5:39 UTC (permalink / raw)
To: ast, daniel, kafai, songliubraving, yhs, andriin, john.fastabend,
kpsingh, kuba, quentin, jolsa, toke, paul.chaignon
Cc: netdev, bpf, linux-kernel, Jagadeesh Pagadala
From: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
Code cleanup: Remove duplicate headers which are included twice.
Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
---
tools/bpf/bpftool/btf.c | 1 -
tools/bpf/bpftool/gen.c | 1 -
tools/bpf/bpftool/jit_disasm.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c
index bcaf55b..41a1346 100644
--- a/tools/bpf/bpftool/btf.c
+++ b/tools/bpf/bpftool/btf.c
@@ -15,7 +15,6 @@
#include <linux/hashtable.h>
#include <sys/types.h>
#include <sys/stat.h>
-#include <unistd.h>
#include "json_writer.h"
#include "main.h"
diff --git a/tools/bpf/bpftool/gen.c b/tools/bpf/bpftool/gen.c
index f8113b3..0e5f023 100644
--- a/tools/bpf/bpftool/gen.c
+++ b/tools/bpf/bpftool/gen.c
@@ -17,7 +17,6 @@
#include <sys/types.h>
#include <sys/stat.h>
#include <sys/mman.h>
-#include <unistd.h>
#include <bpf/btf.h>
#include "bpf/libbpf_internal.h"
diff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c
index f7f5885..e7e7eee 100644
--- a/tools/bpf/bpftool/jit_disasm.c
+++ b/tools/bpf/bpftool/jit_disasm.c
@@ -15,7 +15,6 @@
#include <stdio.h>
#include <stdarg.h>
#include <stdint.h>
-#include <stdio.h>
#include <stdlib.h>
#include <assert.h>
#include <unistd.h>
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/bpf/bpftool: Remove duplicate headers
2020-04-19 5:39 [PATCH] tools/bpf/bpftool: Remove duplicate headers jagdsh.linux
@ 2020-04-20 8:27 ` Quentin Monnet
2020-04-21 3:28 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Quentin Monnet @ 2020-04-20 8:27 UTC (permalink / raw)
To: jagdsh.linux, ast, daniel, kafai, songliubraving, yhs, andriin,
john.fastabend, kpsingh, kuba, jolsa, toke, Paul Chaigno
Cc: netdev, bpf, linux-kernel
2020-04-19 11:09 UTC+0530 ~ jagdsh.linux@gmail.com
> From: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
>
> Code cleanup: Remove duplicate headers which are included twice.
>
> Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
Reviewed-by: Quentin Monnet <quentin@isovalent.com>
Thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/bpf/bpftool: Remove duplicate headers
2020-04-19 5:39 [PATCH] tools/bpf/bpftool: Remove duplicate headers jagdsh.linux
2020-04-20 8:27 ` Quentin Monnet
@ 2020-04-21 3:28 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2020-04-21 3:28 UTC (permalink / raw)
To: jagdsh.linux
Cc: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, Andrii Nakryiko, John Fastabend, KP Singh,
Jakub Kicinski, Quentin Monnet, Jiri Olsa,
Toke Høiland-Jørgensen, Paul Chaignon,
Network Development, bpf, LKML
On Sat, Apr 18, 2020 at 10:40 PM <jagdsh.linux@gmail.com> wrote:
>
> From: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
>
> Code cleanup: Remove duplicate headers which are included twice.
>
> Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
Applied. Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-21 3:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-19 5:39 [PATCH] tools/bpf/bpftool: Remove duplicate headers jagdsh.linux
2020-04-20 8:27 ` Quentin Monnet
2020-04-21 3:28 ` Alexei Starovoitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).