* [PATCH] drivers/char/hw_random/cctrng.c: Compilation fix.
@ 2020-04-19 9:51 jagdsh.linux
2020-04-19 14:14 ` Hadar Gat
0 siblings, 1 reply; 2+ messages in thread
From: jagdsh.linux @ 2020-04-19 9:51 UTC (permalink / raw)
To: hadar.gat, mpm, herbert, arnd, gregkh
Cc: linux-crypto, linux-kernel, Jagadeesh Pagadala
From: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
Adding the needed header <linux/fips.h> to fix following compilation error.
CC drivers/char/hw_random/cctrng.o
drivers/char/hw_random/cctrng.c: In function ‘cc_trng_compwork_handler’:
drivers/char/hw_random/cctrng.c:334:49: error: ‘fips_enabled’ undeclared (first use in this function)
if (CC_REG_FLD_GET(RNG_ISR, CRNGT_ERR, isr) && fips_enabled) {
^
drivers/char/hw_random/cctrng.c:334:49: note: each undeclared identifier is reported only once for each function it appears in
drivers/char/hw_random/cctrng.c:335:3: error: implicit declaration of function ‘fips_fail_notify’ [-Werror=implicit-function-declaration]
fips_fail_notify();
^
cc1: some warnings being treated as errors
make[4]: *** [drivers/char/hw_random/cctrng.o] Error 1
Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
---
drivers/char/hw_random/cctrng.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/char/hw_random/cctrng.c b/drivers/char/hw_random/cctrng.c
index bdcd562..3124269 100644
--- a/drivers/char/hw_random/cctrng.c
+++ b/drivers/char/hw_random/cctrng.c
@@ -18,6 +18,10 @@
#include "cctrng.h"
+#ifdef CONFIG_CRYPTO_FIPS
+#include <linux/fips.h>
+#endif
+
#define CC_REG_LOW(name) (name ## _BIT_SHIFT)
#define CC_REG_HIGH(name) (CC_REG_LOW(name) + name ## _BIT_SIZE - 1)
#define CC_GENMASK(name) GENMASK(CC_REG_HIGH(name), CC_REG_LOW(name))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] drivers/char/hw_random/cctrng.c: Compilation fix.
2020-04-19 9:51 [PATCH] drivers/char/hw_random/cctrng.c: Compilation fix jagdsh.linux
@ 2020-04-19 14:14 ` Hadar Gat
0 siblings, 0 replies; 2+ messages in thread
From: Hadar Gat @ 2020-04-19 14:14 UTC (permalink / raw)
To: jagdsh.linux, mpm, herbert, arnd, gregkh
Cc: linux-crypto, linux-kernel, Gilad Ben-Yossef, Ofir Drang, nd
> From: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
>
> Adding the needed header <linux/fips.h> to fix following compilation error.
>
> CC drivers/char/hw_random/cctrng.o
> drivers/char/hw_random/cctrng.c: In function
> ‘cc_trng_compwork_handler’:
> drivers/char/hw_random/cctrng.c:334:49: error: ‘fips_enabled’
> undeclared (first use in this function)
> if (CC_REG_FLD_GET(RNG_ISR, CRNGT_ERR, isr) && fips_enabled) {
> ^
> drivers/char/hw_random/cctrng.c:334:49: note: each undeclared
> identifier is reported only once for each function it appears in
> drivers/char/hw_random/cctrng.c:335:3: error: implicit declaration of
> function ‘fips_fail_notify’ [-Werror=implicit-function-declaration]
> fips_fail_notify();
> ^
> cc1: some warnings being treated as errors
> make[4]: *** [drivers/char/hw_random/cctrng.o] Error 1
>
> Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
> ---
> drivers/char/hw_random/cctrng.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/char/hw_random/cctrng.c
> b/drivers/char/hw_random/cctrng.c index bdcd562..3124269 100644
> --- a/drivers/char/hw_random/cctrng.c
> +++ b/drivers/char/hw_random/cctrng.c
> @@ -18,6 +18,10 @@
>
> #include "cctrng.h"
>
> +#ifdef CONFIG_CRYPTO_FIPS
> +#include <linux/fips.h>
> +#endif
> +
> #define CC_REG_LOW(name) (name ## _BIT_SHIFT) #define
> CC_REG_HIGH(name) (CC_REG_LOW(name) + name ## _BIT_SIZE - 1)
> #define CC_GENMASK(name) GENMASK(CC_REG_HIGH(name),
> CC_REG_LOW(name))
> --
> 1.8.3.1
Hi Jagadeesh,
Thanks for your fix but this compilation issue is already fixed.
It was pushed few days ago and is waiting to be applied.
BR,
Hadar
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-19 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-19 9:51 [PATCH] drivers/char/hw_random/cctrng.c: Compilation fix jagdsh.linux
2020-04-19 14:14 ` Hadar Gat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).