* [PATCH -next] mmc: sdhci-pci-o2micro: Make some symbols static
@ 2020-04-23 6:43 Zou Wei
2020-04-23 6:40 ` Adrian Hunter
2020-04-23 12:22 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2020-04-23 6:43 UTC (permalink / raw)
To: adrian.hunter, ulf.hansson; +Cc: linux-mmc, linux-kernel, Zou Wei
Fix the following sparse warning:
drivers/mmc/host/sdhci-pci-o2micro.c:497:6: warning: symbol
'sdhci_pci_o2_set_clock' was not declared. Should it be static?
drivers/mmc/host/sdhci-pci-o2micro.c:512:5: warning: symbol
'sdhci_pci_o2_probe_slot' was not declared. Should it be static?
drivers/mmc/host/sdhci-pci-o2micro.c:581:5: warning: symbol
'sdhci_pci_o2_probe' was not declared. Should it be static?
drivers/mmc/host/sdhci-pci-o2micro.c:786:5: warning: symbol
'sdhci_pci_o2_resume' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/mmc/host/sdhci-pci-o2micro.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
index fa81050..e2a8468 100644
--- a/drivers/mmc/host/sdhci-pci-o2micro.c
+++ b/drivers/mmc/host/sdhci-pci-o2micro.c
@@ -494,7 +494,7 @@ static void sdhci_o2_enable_clk(struct sdhci_host *host, u16 clk)
}
}
-void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
+static void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
{
u16 clk;
@@ -509,7 +509,7 @@ void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
sdhci_o2_enable_clk(host, clk);
}
-int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
+static int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
{
struct sdhci_pci_chip *chip;
struct sdhci_host *host;
@@ -578,7 +578,7 @@ int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
return 0;
}
-int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
+static int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
{
int ret;
u8 scratch;
@@ -783,7 +783,7 @@ int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
}
#ifdef CONFIG_PM_SLEEP
-int sdhci_pci_o2_resume(struct sdhci_pci_chip *chip)
+static int sdhci_pci_o2_resume(struct sdhci_pci_chip *chip)
{
sdhci_pci_o2_probe(chip);
return sdhci_pci_resume_host(chip);
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] mmc: sdhci-pci-o2micro: Make some symbols static
2020-04-23 6:43 [PATCH -next] mmc: sdhci-pci-o2micro: Make some symbols static Zou Wei
@ 2020-04-23 6:40 ` Adrian Hunter
2020-04-23 12:22 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2020-04-23 6:40 UTC (permalink / raw)
To: Zou Wei, ulf.hansson; +Cc: linux-mmc, linux-kernel
On 23/04/20 9:43 am, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/mmc/host/sdhci-pci-o2micro.c:497:6: warning: symbol
> 'sdhci_pci_o2_set_clock' was not declared. Should it be static?
> drivers/mmc/host/sdhci-pci-o2micro.c:512:5: warning: symbol
> 'sdhci_pci_o2_probe_slot' was not declared. Should it be static?
> drivers/mmc/host/sdhci-pci-o2micro.c:581:5: warning: symbol
> 'sdhci_pci_o2_probe' was not declared. Should it be static?
> drivers/mmc/host/sdhci-pci-o2micro.c:786:5: warning: symbol
> 'sdhci_pci_o2_resume' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-pci-o2micro.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
> index fa81050..e2a8468 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -494,7 +494,7 @@ static void sdhci_o2_enable_clk(struct sdhci_host *host, u16 clk)
> }
> }
>
> -void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
> +static void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
> {
> u16 clk;
>
> @@ -509,7 +509,7 @@ void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
> sdhci_o2_enable_clk(host, clk);
> }
>
> -int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
> +static int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
> {
> struct sdhci_pci_chip *chip;
> struct sdhci_host *host;
> @@ -578,7 +578,7 @@ int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
> return 0;
> }
>
> -int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
> +static int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
> {
> int ret;
> u8 scratch;
> @@ -783,7 +783,7 @@ int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
> }
>
> #ifdef CONFIG_PM_SLEEP
> -int sdhci_pci_o2_resume(struct sdhci_pci_chip *chip)
> +static int sdhci_pci_o2_resume(struct sdhci_pci_chip *chip)
> {
> sdhci_pci_o2_probe(chip);
> return sdhci_pci_resume_host(chip);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] mmc: sdhci-pci-o2micro: Make some symbols static
2020-04-23 6:43 [PATCH -next] mmc: sdhci-pci-o2micro: Make some symbols static Zou Wei
2020-04-23 6:40 ` Adrian Hunter
@ 2020-04-23 12:22 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-04-23 12:22 UTC (permalink / raw)
To: Zou Wei; +Cc: Adrian Hunter, linux-mmc, Linux Kernel Mailing List
On Thu, 23 Apr 2020 at 08:37, Zou Wei <zou_wei@huawei.com> wrote:
>
> Fix the following sparse warning:
>
> drivers/mmc/host/sdhci-pci-o2micro.c:497:6: warning: symbol
> 'sdhci_pci_o2_set_clock' was not declared. Should it be static?
> drivers/mmc/host/sdhci-pci-o2micro.c:512:5: warning: symbol
> 'sdhci_pci_o2_probe_slot' was not declared. Should it be static?
> drivers/mmc/host/sdhci-pci-o2micro.c:581:5: warning: symbol
> 'sdhci_pci_o2_probe' was not declared. Should it be static?
> drivers/mmc/host/sdhci-pci-o2micro.c:786:5: warning: symbol
> 'sdhci_pci_o2_resume' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-pci-o2micro.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
> index fa81050..e2a8468 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -494,7 +494,7 @@ static void sdhci_o2_enable_clk(struct sdhci_host *host, u16 clk)
> }
> }
>
> -void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
> +static void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
> {
> u16 clk;
>
> @@ -509,7 +509,7 @@ void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
> sdhci_o2_enable_clk(host, clk);
> }
>
> -int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
> +static int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
> {
> struct sdhci_pci_chip *chip;
> struct sdhci_host *host;
> @@ -578,7 +578,7 @@ int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
> return 0;
> }
>
> -int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
> +static int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
> {
> int ret;
> u8 scratch;
> @@ -783,7 +783,7 @@ int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
> }
>
> #ifdef CONFIG_PM_SLEEP
> -int sdhci_pci_o2_resume(struct sdhci_pci_chip *chip)
> +static int sdhci_pci_o2_resume(struct sdhci_pci_chip *chip)
> {
> sdhci_pci_o2_probe(chip);
> return sdhci_pci_resume_host(chip);
> --
> 2.6.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-23 12:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 6:43 [PATCH -next] mmc: sdhci-pci-o2micro: Make some symbols static Zou Wei
2020-04-23 6:40 ` Adrian Hunter
2020-04-23 12:22 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).