* [PATCH -next] ACPI / CPPC: Make some symbols static
@ 2020-04-23 7:21 Zou Wei
2020-04-26 16:31 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2020-04-23 7:21 UTC (permalink / raw)
To: rjw, lenb; +Cc: linux-acpi, linux-kernel, Zou Wei
Fix the following sparse warnings:
drivers/acpi/cppc_acpi.c:353:20: warning: symbol 'cppc_mbox_cl' was not declared. Should it be static?
drivers/acpi/cppc_acpi.c:600:5: warning: symbol 'pcc_data_alloc' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/acpi/cppc_acpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
index 8b2e89c..f818400 100644
--- a/drivers/acpi/cppc_acpi.c
+++ b/drivers/acpi/cppc_acpi.c
@@ -350,7 +350,7 @@ static void cppc_chan_tx_done(struct mbox_client *cl, void *msg, int ret)
*(u16 *)msg, ret);
}
-struct mbox_client cppc_mbox_cl = {
+static struct mbox_client cppc_mbox_cl = {
.tx_done = cppc_chan_tx_done,
.knows_txdone = true,
};
@@ -597,7 +597,7 @@ bool __weak cpc_ffh_supported(void)
*
* Return: 0 for success, errno for failure
*/
-int pcc_data_alloc(int pcc_ss_id)
+static int pcc_data_alloc(int pcc_ss_id)
{
if (pcc_ss_id < 0 || pcc_ss_id >= MAX_PCC_SUBSPACES)
return -EINVAL;
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ACPI / CPPC: Make some symbols static
2020-04-23 7:21 [PATCH -next] ACPI / CPPC: Make some symbols static Zou Wei
@ 2020-04-26 16:31 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-04-26 16:31 UTC (permalink / raw)
To: Zou Wei; +Cc: lenb, linux-acpi, linux-kernel
On Thursday, April 23, 2020 9:21:58 AM CEST Zou Wei wrote:
> Fix the following sparse warnings:
>
> drivers/acpi/cppc_acpi.c:353:20: warning: symbol 'cppc_mbox_cl' was not declared. Should it be static?
> drivers/acpi/cppc_acpi.c:600:5: warning: symbol 'pcc_data_alloc' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/acpi/cppc_acpi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 8b2e89c..f818400 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -350,7 +350,7 @@ static void cppc_chan_tx_done(struct mbox_client *cl, void *msg, int ret)
> *(u16 *)msg, ret);
> }
>
> -struct mbox_client cppc_mbox_cl = {
> +static struct mbox_client cppc_mbox_cl = {
> .tx_done = cppc_chan_tx_done,
> .knows_txdone = true,
> };
> @@ -597,7 +597,7 @@ bool __weak cpc_ffh_supported(void)
> *
> * Return: 0 for success, errno for failure
> */
> -int pcc_data_alloc(int pcc_ss_id)
> +static int pcc_data_alloc(int pcc_ss_id)
> {
> if (pcc_ss_id < 0 || pcc_ss_id >= MAX_PCC_SUBSPACES)
> return -EINVAL;
>
Applied as 5.8-candidate material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-26 16:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 7:21 [PATCH -next] ACPI / CPPC: Make some symbols static Zou Wei
2020-04-26 16:31 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).