* [tip: objtool/core] objtool: Remove redundant checks on operand type
@ 2020-04-23 7:49 tip-bot2 for Julien Thierry
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Julien Thierry @ 2020-04-23 7:49 UTC (permalink / raw)
To: linux-tip-commits
Cc: Julien Thierry, Peter Zijlstra (Intel),
Miroslav Benes, Josh Poimboeuf, Ingo Molnar, x86, LKML
The following commit has been merged into the objtool/core branch of tip:
Commit-ID: a70266b5b2e1c4262566a52f2ef16bdcde90f99b
Gitweb: https://git.kernel.org/tip/a70266b5b2e1c4262566a52f2ef16bdcde90f99b
Author: Julien Thierry <jthierry@redhat.com>
AuthorDate: Fri, 27 Mar 2020 15:28:39
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Wed, 22 Apr 2020 10:53:49 +02:00
objtool: Remove redundant checks on operand type
POP operations are already in the code path where the destination
operand is OP_DEST_REG. There is no need to check the operand type
again.
Signed-off-by: Julien Thierry <jthierry@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
tools/objtool/check.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 4b170fd..c18eca1 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1715,15 +1715,13 @@ static int update_insn_state(struct instruction *insn, struct insn_state *state)
case OP_SRC_POP:
case OP_SRC_POPF:
- if (!state->drap && op->dest.type == OP_DEST_REG &&
- op->dest.reg == cfa->base) {
+ if (!state->drap && op->dest.reg == cfa->base) {
/* pop %rbp */
cfa->base = CFI_SP;
}
if (state->drap && cfa->base == CFI_BP_INDIRECT &&
- op->dest.type == OP_DEST_REG &&
op->dest.reg == state->drap_reg &&
state->drap_offset == -state->stack_size) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip: objtool/core] objtool: Remove redundant checks on operand type
@ 2020-04-22 22:24 tip-bot2 for Julien Thierry
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Julien Thierry @ 2020-04-22 22:24 UTC (permalink / raw)
To: linux-tip-commits
Cc: Julien Thierry, Peter Zijlstra (Intel),
Miroslav Benes, Josh Poimboeuf, x86, LKML
The following commit has been merged into the objtool/core branch of tip:
Commit-ID: a60e3f18ee0a280911b3aa4a5d756006cf766397
Gitweb: https://git.kernel.org/tip/a60e3f18ee0a280911b3aa4a5d756006cf766397
Author: Julien Thierry <jthierry@redhat.com>
AuthorDate: Fri, 27 Mar 2020 15:28:39
Committer: Josh Poimboeuf <jpoimboe@redhat.com>
CommitterDate: Tue, 14 Apr 2020 10:39:24 -05:00
objtool: Remove redundant checks on operand type
POP operations are already in the code path where the destination
operand is OP_DEST_REG. There is no need to check the operand type
again.
Signed-off-by: Julien Thierry <jthierry@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
tools/objtool/check.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 93fa7be..ed01059 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1733,15 +1733,13 @@ static int update_insn_state(struct instruction *insn, struct insn_state *state)
case OP_SRC_POP:
case OP_SRC_POPF:
- if (!state->drap && op->dest.type == OP_DEST_REG &&
- op->dest.reg == cfa->base) {
+ if (!state->drap && op->dest.reg == cfa->base) {
/* pop %rbp */
cfa->base = CFI_SP;
}
if (state->drap && cfa->base == CFI_BP_INDIRECT &&
- op->dest.type == OP_DEST_REG &&
op->dest.reg == state->drap_reg &&
state->drap_offset == -state->stack_size) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-23 7:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 7:49 [tip: objtool/core] objtool: Remove redundant checks on operand type tip-bot2 for Julien Thierry
-- strict thread matches above, loose matches on Subject: below --
2020-04-22 22:24 tip-bot2 for Julien Thierry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).