* [PATCH net-next v2] ptp: clockmatrix: remove unnecessary comparison
@ 2020-04-24 12:52 Yang Yingliang
2020-04-24 13:22 ` Vincent Cheng
2020-04-26 3:41 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2020-04-24 12:52 UTC (permalink / raw)
To: richardcochran, vincent.cheng.xh, davem, yangyingliang
Cc: netdev, linux-kernel
The type of loaddr is u8 which is always '<=' 0xff, so the
loaddr <= 0xff is always true, we can remove this comparison.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/ptp/ptp_clockmatrix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
index 032e112..56aee4f 100644
--- a/drivers/ptp/ptp_clockmatrix.c
+++ b/drivers/ptp/ptp_clockmatrix.c
@@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm,
/* Page size 128, last 4 bytes of page skipped */
if (((loaddr > 0x7b) && (loaddr <= 0x7f))
- || ((loaddr > 0xfb) && (loaddr <= 0xff)))
+ || loaddr > 0xfb)
continue;
err = idtcm_write(idtcm, regaddr, 0, &val, sizeof(val));
--
1.8.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] ptp: clockmatrix: remove unnecessary comparison
2020-04-24 12:52 [PATCH net-next v2] ptp: clockmatrix: remove unnecessary comparison Yang Yingliang
@ 2020-04-24 13:22 ` Vincent Cheng
2020-04-26 3:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vincent Cheng @ 2020-04-24 13:22 UTC (permalink / raw)
To: Yang Yingliang; +Cc: richardcochran, davem, netdev, linux-kernel
>Reported-by: Hulk Robot <hulkci@huawei.com>
>Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>---
> drivers/ptp/ptp_clockmatrix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
>index 032e112..56aee4f 100644
>--- a/drivers/ptp/ptp_clockmatrix.c
>+++ b/drivers/ptp/ptp_clockmatrix.c
>@@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm,
>
> /* Page size 128, last 4 bytes of page skipped */
> if (((loaddr > 0x7b) && (loaddr <= 0x7f))
>- || ((loaddr > 0xfb) && (loaddr <= 0xff)))
>+ || loaddr > 0xfb)
> continue;
>
> err = idtcm_write(idtcm, regaddr, 0, &val, sizeof(val));
Thank-you for the fix.
Reviewed-by: Vincent Cheng <vincent.cheng.xh@renesas.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] ptp: clockmatrix: remove unnecessary comparison
2020-04-24 12:52 [PATCH net-next v2] ptp: clockmatrix: remove unnecessary comparison Yang Yingliang
2020-04-24 13:22 ` Vincent Cheng
@ 2020-04-26 3:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-04-26 3:41 UTC (permalink / raw)
To: yangyingliang; +Cc: richardcochran, vincent.cheng.xh, netdev, linux-kernel
From: Yang Yingliang <yangyingliang@huawei.com>
Date: Fri, 24 Apr 2020 20:52:26 +0800
> The type of loaddr is u8 which is always '<=' 0xff, so the
> loaddr <= 0xff is always true, we can remove this comparison.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-26 3:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 12:52 [PATCH net-next v2] ptp: clockmatrix: remove unnecessary comparison Yang Yingliang
2020-04-24 13:22 ` Vincent Cheng
2020-04-26 3:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).