* [PATCH -next] perf report: fix warning Comparison of 0/1 to bool variable
@ 2020-04-26 12:38 Zou Wei
2020-04-28 17:51 ` Arnaldo Carvalho de Melo
2020-05-08 13:05 ` [tip: perf/core] perf report: Fix warning assignment " tip-bot2 for Zou Wei
0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2020-04-26 12:38 UTC (permalink / raw)
To: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa, namhyung
Cc: linux-kernel, Zou Wei
Fixes coccicheck warning:
tools/perf/builtin-report.c:1403:2-34: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
tools/perf/builtin-report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 26d8fc2..02c09fd 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1400,7 +1400,7 @@ int cmd_report(int argc, const char **argv)
}
if (branch_call_mode) {
callchain_param.key = CCKEY_ADDRESS;
- callchain_param.branch_callstack = 1;
+ callchain_param.branch_callstack = true;
symbol_conf.use_callchain = true;
callchain_register_param(&callchain_param);
if (sort_order == NULL)
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] perf report: fix warning Comparison of 0/1 to bool variable
2020-04-26 12:38 [PATCH -next] perf report: fix warning Comparison of 0/1 to bool variable Zou Wei
@ 2020-04-28 17:51 ` Arnaldo Carvalho de Melo
2020-05-08 13:05 ` [tip: perf/core] perf report: Fix warning assignment " tip-bot2 for Zou Wei
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-04-28 17:51 UTC (permalink / raw)
To: Zou Wei
Cc: peterz, mingo, mark.rutland, alexander.shishkin, jolsa, namhyung,
linux-kernel
Em Sun, Apr 26, 2020 at 08:38:03PM +0800, Zou Wei escreveu:
> Fixes coccicheck warning:
>
> tools/perf/builtin-report.c:1403:2-34: WARNING: Assignment of 0/1 to bool variable
Fixed the subject line to have "assignment", not "comparison",
Thanks, applied,
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: perf/core] perf report: Fix warning assignment of 0/1 to bool variable
2020-04-26 12:38 [PATCH -next] perf report: fix warning Comparison of 0/1 to bool variable Zou Wei
2020-04-28 17:51 ` Arnaldo Carvalho de Melo
@ 2020-05-08 13:05 ` tip-bot2 for Zou Wei
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Zou Wei @ 2020-05-08 13:05 UTC (permalink / raw)
To: linux-tip-commits
Cc: Hulk Robot, Zou Wei, Alexander Shishkin, Jiri Olsa, Mark Rutland,
Namhyung Kim, Peter Zijlstra, Arnaldo Carvalho de Melo, x86,
LKML
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 6fa9c3e779b89612c56f8ee0096b2252d906357a
Gitweb: https://git.kernel.org/tip/6fa9c3e779b89612c56f8ee0096b2252d906357a
Author: Zou Wei <zou_wei@huawei.com>
AuthorDate: Sun, 26 Apr 2020 20:38:03 +08:00
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitterDate: Thu, 30 Apr 2020 10:48:33 -03:00
perf report: Fix warning assignment of 0/1 to bool variable
Fixes coccicheck warning:
tools/perf/builtin-report.c:1403:2-34: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/1587904683-3510-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 0c32767..7da1342 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1413,7 +1413,7 @@ repeat:
}
if (branch_call_mode) {
callchain_param.key = CCKEY_ADDRESS;
- callchain_param.branch_callstack = 1;
+ callchain_param.branch_callstack = true;
symbol_conf.use_callchain = true;
callchain_register_param(&callchain_param);
if (sort_order == NULL)
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-08 13:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26 12:38 [PATCH -next] perf report: fix warning Comparison of 0/1 to bool variable Zou Wei
2020-04-28 17:51 ` Arnaldo Carvalho de Melo
2020-05-08 13:05 ` [tip: perf/core] perf report: Fix warning assignment " tip-bot2 for Zou Wei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).