* [PATCH v3] dmaengine: mediatek-cqdma: add dt-bindings and remove redundant queue @ 2020-04-27 2:52 EastL 2020-04-27 2:52 ` [PATCH v3 1/2] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings EastL 0 siblings, 1 reply; 4+ messages in thread From: EastL @ 2020-04-27 2:52 UTC (permalink / raw) To: Sean Wang Cc: vkoul, robh+dt, mark.rutland, matthias.bgg, dmaengine, linux-kernel, linux-arm-kernel, linux-mediatek, devicetree, wsd_upstream This patch set adds document the devicetree bindings for MediaTek Command-Queue DMA controller, and remove redundant queue structure. Changes since v2: - add devicetree bindings for MediaTek Command-Queue DMA controller Changes since v1: - remove redundant queue structure - fix wrong description and tags in the earlier patch - add dma-channel-mask for DMA capability EastL (2): dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings dmaengine: mediatek-cqdma: remove redundant queue structure .../devicetree/bindings/dma/mtk-cqdma.yaml | 98 ++++ drivers/dma/mediatek/mtk-cqdma.c | 422 +++++------------- 2 files changed, 218 insertions(+), 302 deletions(-) create mode 100644 Documentation/devicetree/bindings/dma/mtk-cqdma.yaml -- 2.18.0 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 1/2] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings 2020-04-27 2:52 [PATCH v3] dmaengine: mediatek-cqdma: add dt-bindings and remove redundant queue EastL @ 2020-04-27 2:52 ` EastL 2020-04-27 21:32 ` Rob Herring [not found] ` <1588125274311004.11906.seg@mailgw02.mediatek.com> 0 siblings, 2 replies; 4+ messages in thread From: EastL @ 2020-04-27 2:52 UTC (permalink / raw) To: Sean Wang Cc: vkoul, robh+dt, mark.rutland, matthias.bgg, dmaengine, linux-kernel, linux-arm-kernel, linux-mediatek, devicetree, wsd_upstream, EastL Document the devicetree bindings for MediaTek Command-Queue DMA controller which could be found on MT6779 SoC or other similar Mediatek SoCs. Signed-off-by: EastL <EastL.Lee@mediatek.com> --- .../devicetree/bindings/dma/mtk-cqdma.yaml | 98 ++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 Documentation/devicetree/bindings/dma/mtk-cqdma.yaml diff --git a/Documentation/devicetree/bindings/dma/mtk-cqdma.yaml b/Documentation/devicetree/bindings/dma/mtk-cqdma.yaml new file mode 100644 index 0000000..cd265e8 --- /dev/null +++ b/Documentation/devicetree/bindings/dma/mtk-cqdma.yaml @@ -0,0 +1,98 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/dma/mtk-cqdma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek Command-Queue DMA controller Device Tree Binding + +maintainers: + - EastL <EastL.Lee@mediatek.com> + +description: + MediaTek Command-Queue DMA controller (CQDMA) on Mediatek SoC + is dedicated to memory-to-memory transfer through queue based + descriptor management. + +properties: + "#dma-cells": + minimum: 1 + # Should be enough + maximum: 255 + description: + Used to provide DMA controller specific information. + + compatible: + const: mediatek,cqdma + + reg: + maxItems: 255 + + interrupts: + maxItems: 255 + + clocks: + maxItems: 1 + + clock-names: + const: cqdma + + dma-channel-mask: + description: + Bitmask of available DMA channels in ascending order that are + not reserved by firmware and are available to the + kernel. i.e. first channel corresponds to LSB. + The first item in the array is for channels 0-31, the second is for + channels 32-63, etc. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32-array + items: + minItems: 1 + # Should be enough + maxItems: 255 + + dma-channels: + $ref: /schemas/types.yaml#definitions/uint32 + description: + Number of DMA channels supported by the controller. + + dma-requests: + $ref: /schemas/types.yaml#definitions/uint32 + description: + Number of DMA request signals supported by the controller. + +required: + - "#dma-cells" + - compatible + - reg + - interrupts + - clocks + - clock-names + - dma-channel-mask + - dma-channels + - dma-requests + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/mt6779-clk.h> + cqdma: dma-controller@10212000 { + compatible = "mediatek,cqdma"; + reg = <0 0x10212000 0 0x80>, + <0 0x10212080 0 0x80>, + <0 0x10212100 0 0x80>; + interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_LOW>, + <GIC_SPI 140 IRQ_TYPE_LEVEL_LOW>, + <GIC_SPI 141 IRQ_TYPE_LEVEL_LOW>; + clocks = <&infracfg_ao CLK_INFRA_CQ_DMA>; + clock-names = "cqdma"; + dma-channel-mask = <63>; + dma-channels = <3>; + dma-requests = <32>; + #dma-cells = <1>; + }; + +... -- 1.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings 2020-04-27 2:52 ` [PATCH v3 1/2] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings EastL @ 2020-04-27 21:32 ` Rob Herring [not found] ` <1588125274311004.11906.seg@mailgw02.mediatek.com> 1 sibling, 0 replies; 4+ messages in thread From: Rob Herring @ 2020-04-27 21:32 UTC (permalink / raw) To: EastL Cc: Sean Wang, vkoul, robh+dt, mark.rutland, matthias.bgg, dmaengine, linux-kernel, linux-arm-kernel, linux-mediatek, devicetree, wsd_upstream, EastL On Mon, 27 Apr 2020 10:52:56 +0800, EastL wrote: > Document the devicetree bindings for MediaTek Command-Queue DMA controller > which could be found on MT6779 SoC or other similar Mediatek SoCs. > > Signed-off-by: EastL <EastL.Lee@mediatek.com> > --- > .../devicetree/bindings/dma/mtk-cqdma.yaml | 98 ++++++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/mtk-cqdma.yaml > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/mtk-cqdma.example.dt.yaml: dma-controller@10212000: interrupts: [[0, 139, 8], [0, 140, 8], [0, 141, 8]] is too short /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/mtk-cqdma.example.dt.yaml: dma-controller@10212000: reg: [[0, 270606336, 0, 128], [0, 270606464, 0, 128], [0, 270606592, 0, 128]] is too short See https://patchwork.ozlabs.org/patch/1277292 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit. ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1588125274311004.11906.seg@mailgw02.mediatek.com>]
* Re: [PATCH v3 1/2] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings [not found] ` <1588125274311004.11906.seg@mailgw02.mediatek.com> @ 2020-04-29 3:53 ` EastL 0 siblings, 0 replies; 4+ messages in thread From: EastL @ 2020-04-29 3:53 UTC (permalink / raw) To: Rob Herring Cc: Sean Wang, vkoul, robh+dt, mark.rutland, matthias.bgg, dmaengine, linux-kernel, linux-arm-kernel, linux-mediatek, devicetree, wsd_upstream On Mon, 2020-04-27 at 16:32 -0500, Rob Herring wrote: > On Mon, 27 Apr 2020 10:52:56 +0800, EastL wrote: > > Document the devicetree bindings for MediaTek Command-Queue DMA controller > > which could be found on MT6779 SoC or other similar Mediatek SoCs. > > > > Signed-off-by: EastL <EastL.Lee@mediatek.com> > > --- > > .../devicetree/bindings/dma/mtk-cqdma.yaml | 98 ++++++++++++++++++++++ > > 1 file changed, 98 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/dma/mtk-cqdma.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/mtk-cqdma.example.dt.yaml: dma-controller@10212000: interrupts: [[0, 139, 8], [0, 140, 8], [0, 141, 8]] is too short > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/mtk-cqdma.example.dt.yaml: dma-controller@10212000: reg: [[0, 270606336, 0, 128], [0, 270606464, 0, 128], [0, 270606592, 0, 128]] is too short > > See https://patchwork.ozlabs.org/patch/1277292 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. OK, I'll fix it in next version. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-29 3:53 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-04-27 2:52 [PATCH v3] dmaengine: mediatek-cqdma: add dt-bindings and remove redundant queue EastL 2020-04-27 2:52 ` [PATCH v3 1/2] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings EastL 2020-04-27 21:32 ` Rob Herring [not found] ` <1588125274311004.11906.seg@mailgw02.mediatek.com> 2020-04-29 3:53 ` EastL
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).